[GitHub] [superset] kgabryje commented on a change in pull request #15583: chore: Preserve native filters selection after refresh

[GitBox <gi...@apache.org>]

kgabryje commented on a change in pull request #15583:
URL: https://github.com/apache/superset/pull/15583#discussion_r667802338



##########
File path: superset-frontend/src/dashboard/util/replaceUndefinedByNull.ts
##########
@@ -0,0 +1,31 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { cloneDeep } from 'lodash';
+
+export default function replaceUndefinedByNull(object: Object) {

Review comment:
       We run `cloneDeep` on every level of recursion - I think doing it once, in the first level of recursion, would be enough. However, I'd like to propose a different solution:
   ```
   const replacer = (key, val) => {
     if (val === undefined) return null;
     return val;
   }
   
   const replaceUndefinedByNull = (object) => JSON.parse(JSON.stringify(object, replacer));
   ```
   I'm not sure if it would be faster than your solution (we could time it to verify), but I think it's easier to understand. WDYT?

##########
File path: superset-frontend/src/dataMask/reducer.ts
##########
@@ -128,6 +131,7 @@ const dataMaskReducer = produce(
             [],
           cleanState,
           draft,
+          undefined,

Review comment:
       Why do we pass `undefined` here? `fillNativeFilters` seems to accept only 4 arguments

##########
File path: superset-frontend/src/dataMask/reducer.ts
##########
@@ -128,6 +131,7 @@ const dataMaskReducer = produce(
             [],
           cleanState,
           draft,
+          undefined,

Review comment:
       Why do we need pass `undefined` here explicitely? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org