You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by GitBox <gi...@apache.org> on 2020/10/19 18:07:03 UTC
[GitHub] [jena] afs opened a new pull request #815: JENA-1981 unicode substr
afs opened a new pull request #815:
URL: https://github.com/apache/jena/pull/815
This fixed a problem identified from the W3C rdf-tests work. (JENA-1981)
It also includes improvements to JavaCC grammar for Turtle and SHACL Compact Syntax.
The Turtle grammar is kept for reference - it is not used to parse .ttl. The idea is to keep this as reusable input for other languages - SHACL Compact Syntax, for example.
But JENA-1982 is not fixed for SPARQL yet. That needs care to ensure compatibility of corner cases.
As part of general tidying up in the area, rename the SPARQL template javacc file as main.jj.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on a change in pull request #815: JENA-1981 Unicode and SUBSTR
Posted by GitBox <gi...@apache.org>.
afs commented on a change in pull request #815:
URL: https://github.com/apache/jena/pull/815#discussion_r508694950
##########
File path: jena-arq/src/test/java/org/apache/jena/sparql/expr/TestFunctions2.java
##########
@@ -165,6 +167,23 @@
public void substr_21() { test("substr('', 'one', 3)", "''") ; }
@Test(expected=ExprEvalException.class)
public void substr_22() { test("substr('', 1, 'three')", "''") ; }
+
+ // Codepoint outside UTF-16.
+ // These are U+0001F46A 👪 - FAMILY
Review comment:
:-)
I didn't put them raw in the tests themselves because of portability concerns over binary/text.
I did test with 👪.
(ARQ is not handling \U in SPARQL properly yet.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs merged pull request #815: JENA-1981 Unicode and SUBSTR
Posted by GitBox <gi...@apache.org>.
afs merged pull request #815:
URL: https://github.com/apache/jena/pull/815
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] kinow commented on a change in pull request #815: JENA-1981 Unicode and SUBSTR
Posted by GitBox <gi...@apache.org>.
kinow commented on a change in pull request #815:
URL: https://github.com/apache/jena/pull/815#discussion_r508008416
##########
File path: jena-arq/src/test/java/org/apache/jena/sparql/expr/TestFunctions2.java
##########
@@ -165,6 +167,23 @@
public void substr_21() { test("substr('', 'one', 3)", "''") ; }
@Test(expected=ExprEvalException.class)
public void substr_22() { test("substr('', 1, 'three')", "''") ; }
+
+ // Codepoint outside UTF-16.
+ // These are U+0001F46A 👪 - FAMILY
Review comment:
Emoticons being useful for testing :tada:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org