You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/11/21 14:58:16 UTC
[GitHub] [apisix] Xunzhuo opened a new pull request #5566: docs(style): add space between zh and en letters
Xunzhuo opened a new pull request #5566:
URL: https://github.com/apache/apisix/pull/5566
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
add space between zh and en letters
### Pre-submission checklist:
<!--
Please follow the requirements:
1. Use Draft if the PR is not ready to be reviewed
2. Test is required for the feat/fix PR, unless you have a good reason
3. Doc is required for the feat PR
4. Use a new commit to resolve review instead of `push -f`
5. Use "request review" to notify the reviewer once you have resolved the review
-->
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5566: docs(style): fix non-standard spaces between letters
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #5566:
URL: https://github.com/apache/apisix/pull/5566#discussion_r754024138
##########
File path: docs/zh/latest/plugins/consumer-restriction.md
##########
@@ -118,7 +118,7 @@ HTTP/1.1 403 Forbidden
### 如何限制 `service_id`
-`service_id`方式需要与授权插件一起配合使用，这里以key-auth授权插件为例。
+`service_id` 方式需要与授权插件一起配合使用，这里以key-auth授权插件为例。
Review comment:
```suggestion
`service_id` 方式需要与授权插件一起配合使用，这里以 key-auth 授权插件为例。
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Xunzhuo commented on pull request #5566: docs(style): fix non-standard spaces between letters
Posted by GitBox <gi...@apache.org>.
Xunzhuo commented on pull request #5566:
URL: https://github.com/apache/apisix/pull/5566#issuecomment-975146727
@spacewander Yes, I can try to start the other PR to do this later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #5566: docs(style): fix non-standard spaces between letters
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #5566:
URL: https://github.com/apache/apisix/pull/5566
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Xunzhuo commented on a change in pull request #5566: docs(style): fix non-standard spaces between letters
Posted by GitBox <gi...@apache.org>.
Xunzhuo commented on a change in pull request #5566:
URL: https://github.com/apache/apisix/pull/5566#discussion_r754075527
##########
File path: docs/zh/latest/plugins/consumer-restriction.md
##########
@@ -118,7 +118,7 @@ HTTP/1.1 403 Forbidden
### 如何限制 `service_id`
-`service_id`方式需要与授权插件一起配合使用，这里以key-auth授权插件为例。
+`service_id` 方式需要与授权插件一起配合使用，这里以key-auth授权插件为例。
Review comment:
Done.
##########
File path: docs/zh/latest/FAQ.md
##########
@@ -27,7 +27,7 @@ title: 常见问题
## APISIX 和其他的 API 网关有什么不同之处？
-APISIX 基于 etcd 来完成配置的保存和同步，而不是 postgres 或者 MySQL 这类关系型数据库。
+APISIX 基于 etcd 来完成配置的保存和同步，而不是 Postgre 或者 MySQL 这类关系型数据库。
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming commented on a change in pull request #5566: docs(style): fix non-standard spaces between letters
Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #5566:
URL: https://github.com/apache/apisix/pull/5566#discussion_r753977306
##########
File path: docs/zh/latest/FAQ.md
##########
@@ -27,7 +27,7 @@ title: 常见问题
## APISIX 和其他的 API 网关有什么不同之处？
-APISIX 基于 etcd 来完成配置的保存和同步，而不是 postgres 或者 MySQL 这类关系型数据库。
+APISIX 基于 etcd 来完成配置的保存和同步，而不是 Postgre 或者 MySQL 这类关系型数据库。
Review comment:
typo: PostgreSQL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org