source-map compiler argument : path to source

[Idylog - Nicolas Granon <ng...@idylog.com>]

It appears that, when generating the source map for debugging js output, the
path to the source file ("sources" property) is using a relative path.

Since it is possible (and often desirable) to send the output outside the
workspace/project folder (with js-output argument) it seems to me that the
path to the main source file should be an absolute path.

Also, the map is named with a .js.map suffix even for a MXML main source
file. It should follow the extension of the main source file (.js.map or
.mxml.map, depending on the main source file).

Nicolas Granon

RE: source-map compiler argument : path to source

[Idylog - Nicolas Granon <ng...@idylog.com>]

Sorry for my ignorance. I thought that it had to match the "main source"
file extension.
Thank you for this information.

Regarding the source path in the .map file, I personally do not know what
the TS compiler produces.
If I understand correctly, it means that, depending where the output is
sent, the path could be relative (output sent to the project dir) or
absolute (output sent elsewhere) ? In that case, I think we can live with
that ! (assuming the -js-output argument works as expected).

Nicolas Granon




> -----Message d'origine-----
> De : Josh Tynjala [mailto:joshtynjala@apache.org]
> Envoyé : mardi 7 novembre 2017 19:36
> À : dev@royale.apache.org
> Objet : Re: source-map compiler argument : path to source
> 
> The .js.map extension is the correct behavior. The name of a source map
> file is based on extension of the output file rather then the input
> file. Both .as and .mxml files will produce .js output, so the source
> map's extension should be .js.map for both. Every tool that I've seen
> produce source maps for other languages works this way. Compile-to-JS
> languages create .js.map files. Compile-to-CSS languages create
> .css.map files.
> 
> In regards to relative versus absolute paths, I'm pretty sure that I
> checked what the TypeScript compiler produced and made sure that the
> behavior was the same in our compiler.
> 
> - Josh
> 
> On 2017-11-06 02:52, "Idylog - Nicolas Granon" <ng...@idylog.com>
> wrote:
> > It appears that, when generating the source map for debugging js
> > output, the path to the source file ("sources" property) is using a
> relative path.
> >
> > Since it is possible (and often desirable) to send the output outside
> > the workspace/project folder (with js-output argument) it seems to me
> > that the path to the main source file should be an absolute path.
> >
> > Also, the map is named with a .js.map suffix even for a MXML main
> > source file. It should follow the extension of the main source file
> > (.js.map or .mxml.map, depending on the main source file).
> >
> > Nicolas Granon
> >
> >
> >
> >
> >
> >

Re: source-map compiler argument : path to source

[Josh Tynjala <jo...@apache.org>]

The .js.map extension is the correct behavior. The name of a source map file is based on extension of the output file rather then the input file. Both .as and .mxml files will produce .js output, so the source map's extension should be .js.map for both. Every tool that I've seen produce source maps for other languages works this way. Compile-to-JS languages create .js.map files. Compile-to-CSS languages create .css.map files.

In regards to relative versus absolute paths, I'm pretty sure that I checked what the TypeScript compiler produced and made sure that the behavior was the same in our compiler.

- Josh

On 2017-11-06 02:52, "Idylog - Nicolas Granon" <ng...@idylog.com> wrote: 
> It appears that, when generating the source map for debugging js output, the
> path to the source file ("sources" property) is using a relative path.
> 
> Since it is possible (and often desirable) to send the output outside the
> workspace/project folder (with js-output argument) it seems to me that the
> path to the main source file should be an absolute path.
> 
> Also, the map is named with a .js.map suffix even for a MXML main source
> file. It should follow the extension of the main source file (.js.map or
> .mxml.map, depending on the main source file).
> 
> Nicolas Granon
> 
> 
> 
> 
> 
>