Re: Review Request 58813: GEODE-2776 After region is updated with loader, the ClientEvent is set with current entry version tag

[anilkumar gingade <ag...@pivotal.io>]

> On April 28, 2017, 11:33 p.m., Darrel Schneider wrote:
> > geode-core/src/main/java/org/apache/geode/internal/cache/DistributedRegion.java
> > Lines 2358 (patched)
> > <https://reviews.apache.org/r/58813/diff/2/?file=1703674#file1703674line2358>
> >
> >     I just thought of one more possible issue.
> >     I think you want to get the versionTag and the value from "re" atomically.
> >     I remember a fix like this before in which you need to make sure the value you get from a region entry is the same as the version tag.

Good catch...Added this new changes posted.


- anilkumar


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58813/#review173400
-----------------------------------------------------------


On April 28, 2017, 11:23 p.m., anilkumar gingade wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58813/
> -----------------------------------------------------------
> 
> (Updated April 28, 2017, 11:23 p.m.)
> 
> 
> Review request for geode, Darrel Schneider, Eric Shu, and Lynn Gallinat.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> When client does a get() which results in adding an entry by calling loader on server side, the client event returned back is not updated with the version tag that is created with the new entry on server. This results in client having a different version tag than the server side entry. If client has registered event, and is concurrently updating the entry (from get() call and an register-event from server), it could result in data consistency between client and server.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/internal/cache/DistributedRegion.java 8cdc517 
>   geode-core/src/test/java/org/apache/geode/internal/cache/DistributedRegionSearchLoadJUnitTest.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/58813/diff/2/
> 
> 
> Testing
> -------
> 
> Manual testing.
> Running new unit test (added) with and without changes.
> precheckin in progress.
> 
> 
> Thanks,
> 
> anilkumar gingade
> 
>