You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/09/07 21:22:53 UTC
[GitHub] [tvm] Lunderberg opened a new pull request, #12726: [TVMScript][TIR] Clarify scope of BlockNode::iter_vars
Lunderberg opened a new pull request, #12726:
URL: https://github.com/apache/tvm/pull/12726
Previously, it was ambiguous whether `BlockNode::iter_vars` were in-scope for `BlockRealizeNode::predicate`. `ConvertBlocksToOpaque` treated them as in-scope, and applied a mapping from `iter_vars` to `iter_values`. Similarly, TVMScript printing places `T.where` statements below the `T.axis` statements, where `T.axis` definitions are in scope. However, `BlockRealizeNode::SEqualReduce` and `BlockRealizeNode::SHashReduce` do not visit the block and `iter_vars` until after visiting the predicate, placing the `iter_vars` out of scope.
This commit updates the printing of `T.where` to be above `T.axis`, and updates `ConvertBlocksToOpaque` to report an error if the predicate contains references to `BlockNode::iter_vars`. After this commit, these three usages all consistently treat
`BlockNode::iter_vars` as out of scope for `BlockRealizeNode::predicate`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #12726: [TVMScript][TIR] Clarify scope of BlockNode::iter_vars
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on PR #12726:
URL: https://github.com/apache/tvm/pull/12726#issuecomment-1239906408
Opposite of https://github.com/apache/tvm/pull/12724, with the same goal of clarifying when `BlockNode::iter_vars` are in-scope. From @vinx13, these are not intended to be in-scope for parameters in `BlockRealizeNode`, and so this PR enforces that design intent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] vinx13 merged pull request #12726: [TVMScript][TIR] Clarify scope of BlockNode::iter_vars
Posted by GitBox <gi...@apache.org>.
vinx13 merged PR #12726:
URL: https://github.com/apache/tvm/pull/12726
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org