[GitHub] [iceberg] RussellSpitzer commented on a change in pull request #3801: Core: fix deadlock in CachingCatalog

[GitBox <gi...@apache.org>]

RussellSpitzer commented on a change in pull request #3801:
URL: https://github.com/apache/iceberg/pull/3801#discussion_r775339360



##########
File path: core/src/test/java/org/apache/iceberg/hadoop/TestCachingCatalog.java
##########
@@ -257,6 +264,44 @@ public void testCacheExpirationEagerlyRemovesMetadataTables() throws IOException
             catalog.cache().asMap().containsKey(metadataTable)));
   }
 
+  @Test
+  @Ignore("reproduces https://github.com/apache/iceberg/issues/3791")

Review comment:
       This test should pass now right, so should we turn this on?

##########
File path: core/src/main/java/org/apache/iceberg/CachingCatalog.java
##########
@@ -47,10 +44,6 @@
  */
 public class CachingCatalog implements Catalog {
 
-  private static final Logger LOG = LoggerFactory.getLogger(CachingCatalog.class);
-  private static final RemovalListener<TableIdentifier, Table> identLoggingRemovalListener =

Review comment:
       Should we be logging this in the new removal listener?

##########
File path: core/src/main/java/org/apache/iceberg/CachingCatalog.java
##########
@@ -105,14 +94,14 @@ public void delete(TableIdentifier tableIdentifier, Table table, RemovalCause ca
   }
 
   private Cache<TableIdentifier, Table> createTableCache(Ticker ticker) {
-    Caffeine<TableIdentifier, Table> cacheBuilder = Caffeine
+    Caffeine<Object, Object> cacheBuilder = Caffeine

Review comment:
       Is there a reason we need the generic types here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org