You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/07/28 22:45:38 UTC

[GitHub] [spark] MyeongKim commented on a change in pull request #33544: [SPARK-34927][INFRA] Support TPCDSQueryBenchmark in Benchmarks

MyeongKim commented on a change in pull request #33544:
URL: https://github.com/apache/spark/pull/33544#discussion_r678701487



##########
File path: .github/workflows/benchmark.yml
##########
@@ -19,32 +19,107 @@ on:
         description: 'Number of job splits'
         required: true
         default: '1'
+      run-tcp-ds-query-benchmark:
+        description: 'Run TPCDSQueryBenchmark: true or false'
+        required: false
+        default: 'false'
 
 jobs:
   matrix-gen:
     name: Generate matrix for job splits
     runs-on: ubuntu-20.04
     outputs:
-      matrix: ${{ steps.set-matrix.outputs.matrix }}
+      class: ${{ steps.set-matrix.outputs.class }}
+      split: ${{ steps.set-matrix.outputs.split }}
+      num-split: ${{ steps.set-matrix.outputs.num-split }}
     env:
+      SPARK_BENCHMARK_CLASS: ${{ github.event.inputs.class }}
       SPARK_BENCHMARK_NUM_SPLITS: ${{ github.event.inputs.num-splits }}
     steps:
     - name: Generate matrix
       id: set-matrix
-      run: echo "::set-output name=matrix::["`seq -s, 1 $SPARK_BENCHMARK_NUM_SPLITS`"]"
+      run: |
+        echo "::set-output name=class::['"$SPARK_BENCHMARK_CLASS"']"
+        echo "::set-output name=split::["`seq -s, 1 $SPARK_BENCHMARK_NUM_SPLITS`"]"
+        echo "::set-output name=num-split::['"$SPARK_BENCHMARK_NUM_SPLITS"']"
+
+  generate-TCP-DS-dataset:

Review comment:
       thank you for your comment! Addressed in an additional commit




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org