You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by br...@apache.org on 2014/07/14 19:11:14 UTC

git commit: TS-1475: Fix bug where you could allow a null string to strncasecmp

Repository: trafficserver
Updated Branches:
  refs/heads/master 4c31232d2 -> 057ef2b17


TS-1475: Fix bug where you could allow a null string to strncasecmp


Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/057ef2b1
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/057ef2b1
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/057ef2b1

Branch: refs/heads/master
Commit: 057ef2b178715b3036e9fe196bbe5182c7dd3566
Parents: 4c31232
Author: Brian Geffon <br...@apache.org>
Authored: Mon Jul 14 10:10:59 2014 -0700
Committer: Brian Geffon <br...@apache.org>
Committed: Mon Jul 14 10:11:06 2014 -0700

----------------------------------------------------------------------
 Vagrantfile                                             | 2 +-
 plugins/experimental/esi/fetcher/HttpDataFetcherImpl.cc | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/trafficserver/blob/057ef2b1/Vagrantfile
----------------------------------------------------------------------
diff --git a/Vagrantfile b/Vagrantfile
index 594ccf9..193a2a4 100644
--- a/Vagrantfile
+++ b/Vagrantfile
@@ -73,7 +73,7 @@ Vagrant.configure("2") do |config|
 
   # Default all VMs to 1GB.
   config.vm.provider :virtualbox do |v|
-    v.customize ["modifyvm", :id, "--memory", 1024]
+    v.customize ["modifyvm", :id, "--memory", 2048]
   end
 
   # Mount the Traffic Server source code in a fixed location everywhere. Use NFS

http://git-wip-us.apache.org/repos/asf/trafficserver/blob/057ef2b1/plugins/experimental/esi/fetcher/HttpDataFetcherImpl.cc
----------------------------------------------------------------------
diff --git a/plugins/experimental/esi/fetcher/HttpDataFetcherImpl.cc b/plugins/experimental/esi/fetcher/HttpDataFetcherImpl.cc
index 762bf05..7de78cf 100644
--- a/plugins/experimental/esi/fetcher/HttpDataFetcherImpl.cc
+++ b/plugins/experimental/esi/fetcher/HttpDataFetcherImpl.cc
@@ -234,7 +234,7 @@ HttpDataFetcherImpl::_checkHeaderValue(TSMBuffer bufp, TSMLoc hdr_loc, const cha
 
     for (int i = 0; i < n_values; ++i) {
       value = TSMimeHdrFieldValueStringGet(bufp, hdr_loc, field_loc, i, &value_len);
-      if ( NULL != value || value_len ) {
+      if ( NULL != value && value_len ) {
         if (prefix) {
           if ((value_len >= exp_value_len) &&
               (strncasecmp(value, exp_value, exp_value_len) == 0)) {