You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by "Patrick Mueller (Created) (JIRA)" <ji...@apache.org> on 2012/02/20 17:13:36 UTC

[jira] [Created] (CB-267) add test cases for require() and friends in codova-js

add test cases for require() and friends in codova-js
-----------------------------------------------------

                 Key: CB-267
                 URL: https://issues.apache.org/jira/browse/CB-267
             Project: Apache Callback
          Issue Type: Improvement
          Components: CordovaJS
            Reporter: Patrick Mueller


We should add some test cases to cordova-js to test the require() and friends bits.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (CB-267) add test cases for require() and friends in codova-js

Posted by "Patrick Mueller (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CB-267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Mueller resolved CB-267.
--------------------------------

    Resolution: Fixed

pushed the following commit to cordova-js for this fix:

https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-js.git;a=commit;h=d7341998e657598a8419aa421d84e5bebbb26494

I was unable to run '{{jake test}}', due to some kind of runtime issue with my system (I guess).
                
> add test cases for require() and friends in codova-js
> -----------------------------------------------------
>
>                 Key: CB-267
>                 URL: https://issues.apache.org/jira/browse/CB-267
>             Project: Apache Callback
>          Issue Type: Improvement
>          Components: CordovaJS
>            Reporter: Patrick Mueller
>            Assignee: Patrick Mueller
>         Attachments: cordova-module-tests-1st-pass.pdf
>
>
> We should add some test cases to cordova-js to test the require() and friends bits.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CB-267) add test cases for require() and friends in codova-js

Posted by "Patrick Mueller (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CB-267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Mueller updated CB-267:
-------------------------------

    Attachment: cordova-module-tests-1st-pass.pdf

output of running the tests on the current require()
                
> add test cases for require() and friends in codova-js
> -----------------------------------------------------
>
>                 Key: CB-267
>                 URL: https://issues.apache.org/jira/browse/CB-267
>             Project: Apache Callback
>          Issue Type: Improvement
>          Components: CordovaJS
>            Reporter: Patrick Mueller
>            Assignee: Patrick Mueller
>         Attachments: cordova-module-tests-1st-pass.pdf
>
>
> We should add some test cases to cordova-js to test the require() and friends bits.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CB-267) add test cases for require() and friends in codova-js

Posted by "Patrick Mueller (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CB-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211954#comment-13211954 ] 

Patrick Mueller commented on CB-267:
------------------------------------

There are test cases for CommonJS bits that we should probably support, here: 

bq. https://github.com/commonjs/commonjs/tree/master/tests

The license for the test cases is here:

bq. https://github.com/commonjs/commonjs/blob/master/docs/license.html.markdown

Proposal is to pull those into cordova-js in a new directory '{{cjs-tests}}' under the '{{thirdparty}}' directory.

We'll need to update the LICENSE file to indicate the licensing of that (and add the jasmine bits as a "drive by" fix).

To run the test cases, we'll need a separate loader/runner, as the tests have a distinct set of runtime requirements.  I've already built and used a loader/runner for this with modjewel, so I'll pull those in, I guess under '{{test}}' as '{{cjs-tests}}'.  Not sure if it's appropriate or desired to have these tests folded into some uber-test suite or not, given the different runtime set up, and the fact that these tests shouldn't need to be run all that often anyway - they are generally orthogonal to the existing cordova test cases.
In order to run the
                
> add test cases for require() and friends in codova-js
> -----------------------------------------------------
>
>                 Key: CB-267
>                 URL: https://issues.apache.org/jira/browse/CB-267
>             Project: Apache Callback
>          Issue Type: Improvement
>          Components: CordovaJS
>            Reporter: Patrick Mueller
>
> We should add some test cases to cordova-js to test the require() and friends bits.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CB-267) add test cases for require() and friends in codova-js

Posted by "Patrick Mueller (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CB-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211957#comment-13211957 ] 

Patrick Mueller commented on CB-267:
------------------------------------

I suppose I should mention: I fully expect these tests to fail with our current version of {{require()}}.  That's to be expected.

Once the test cases are integrated and basically running - and failing - I'll open another bug to fix the issues in our version of {{require()}}.
                
> add test cases for require() and friends in codova-js
> -----------------------------------------------------
>
>                 Key: CB-267
>                 URL: https://issues.apache.org/jira/browse/CB-267
>             Project: Apache Callback
>          Issue Type: Improvement
>          Components: CordovaJS
>            Reporter: Patrick Mueller
>
> We should add some test cases to cordova-js to test the require() and friends bits.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (CB-267) add test cases for require() and friends in codova-js

Posted by "Patrick Mueller (Assigned) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CB-267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Mueller reassigned CB-267:
----------------------------------

    Assignee: Patrick Mueller
    
> add test cases for require() and friends in codova-js
> -----------------------------------------------------
>
>                 Key: CB-267
>                 URL: https://issues.apache.org/jira/browse/CB-267
>             Project: Apache Callback
>          Issue Type: Improvement
>          Components: CordovaJS
>            Reporter: Patrick Mueller
>            Assignee: Patrick Mueller
>
> We should add some test cases to cordova-js to test the require() and friends bits.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira