You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/07/16 19:54:28 UTC
[GitHub] [incubator-mxnet] ys2843 opened a new pull request #18738: set website default version - test redirect
ys2843 opened a new pull request #18738:
URL: https://github.com/apache/incubator-mxnet/pull/18738
## Description ##
#18429 , This PR contains the following redirect rules:
When user lands on main page "/"
1. If coming from domains except `mxnet.apache.org` or `mxnet.incubator.apache.org`, redirect users to v1.6 website
2. If coming from urls on MXNet domain, don't redirect to avoid any looping.
Because sometimes Apache server can have unexpected behavior on redirect, this PR only contains a test for this rules. If everything works well, I will submit another PR, delete the test code and uncomment the origin lines.
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage:
### Changes ###
- [ ] Test redirect based on HTTP referer header.
## Comments ##
- Preview: http://ec2-34-219-134-42.us-west-2.compute.amazonaws.com/versions/1.1.0/community/contribute.html
> Should land on the same URI but on v1.6 website if clicking on this link
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 commented on pull request #18738: set website default version - test redirect
Posted by GitBox <gi...@apache.org>.
ys2843 commented on pull request #18738:
URL: https://github.com/apache/incubator-mxnet/pull/18738#issuecomment-660371019
> If `/versions/1.6/get_started` becomes the default, we need to backport the license fixes to that page. Is it possible? Or do we require using the 1.x branch given this constraint?
Yes, my plan is to copy the `get_started.html` directly from master branch to v1.6 static artifact (maybe need some change in the header)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha merged pull request #18738: set website default version to current stable (1.6) version
Posted by GitBox <gi...@apache.org>.
szha merged pull request #18738:
URL: https://github.com/apache/incubator-mxnet/pull/18738
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 edited a comment on pull request #18738: set website default version - test redirect
Posted by GitBox <gi...@apache.org>.
ys2843 edited a comment on pull request #18738:
URL: https://github.com/apache/incubator-mxnet/pull/18738#issuecomment-660381271
> Not sure, but this didn't work: http://ec2-34-219-134-42.us-west-2.compute.amazonaws.com/community/contribute.html
> Shouldn't the dropdown read 1.6 if the redirect worked?
>
> You can use the beta site for testing redirects. It's perfect for this kind of testing.
> https://github.com/apache/incubator-mxnet-site/tree/beta-site
I will add more clarification about this PR. The redirect test in this PR is described below
Start: http://ec2-34-219-134-42.us-west-2.compute.amazonaws.com/versions/1.1.0/community/contribute.html
To: http://ec2-34-219-134-42.us-west-2.compute.amazonaws.com/versions/1.6/community/contribute.html
The redirect only takes effect when user visit `/versions/1.1.0/community/contribute.html` from outside of mxnet website. It could be from a google search result, or type this url into the browser directly. ( check HTTP `referer` is "apache.mxnet.org" or not)
And to prevent redirect looping, if user goes to `/versions/1.1.0` => top nav bar => community => contribute, this also goes to contribution page but redirect won't be triggered because user is coming from mxnet website.
It looks like this beta git repo is too large to clone...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 edited a comment on pull request #18738: set website default version - test redirect
Posted by GitBox <gi...@apache.org>.
ys2843 edited a comment on pull request #18738:
URL: https://github.com/apache/incubator-mxnet/pull/18738#issuecomment-660381271
> Not sure, but this didn't work: http://ec2-34-219-134-42.us-west-2.compute.amazonaws.com/community/contribute.html
> Shouldn't the dropdown read 1.6 if the redirect worked?
>
> You can use the beta site for testing redirects. It's perfect for this kind of testing.
> https://github.com/apache/incubator-mxnet-site/tree/beta-site
I will add more clarification about this PR. The only working redirect in this PR for testing is from
Start: http://ec2-34-219-134-42.us-west-2.compute.amazonaws.com/versions/1.1.0/community/contribute.html
To: http://ec2-34-219-134-42.us-west-2.compute.amazonaws.com/versions/1.6/community/contribute.html
The redirect only works when user enter `/versions/1.1.0/community/contribute.html` from outside of mxnet website. It could be from a google search result, or type this url into the browser directly. ( check HTTP `referer` is "apache.mxnet.org" or not)
And to prevent redirect looping, if user goes to `/versions/1.1.0` => top nav bar => community => contribute, this also goes to contribution page but redirect won't be triggered because user is coming from mxnet website.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 edited a comment on pull request #18738: set website default version - test redirect
Posted by GitBox <gi...@apache.org>.
ys2843 edited a comment on pull request #18738:
URL: https://github.com/apache/incubator-mxnet/pull/18738#issuecomment-660381271
> Not sure, but this didn't work: http://ec2-34-219-134-42.us-west-2.compute.amazonaws.com/community/contribute.html
> Shouldn't the dropdown read 1.6 if the redirect worked?
>
> You can use the beta site for testing redirects. It's perfect for this kind of testing.
> https://github.com/apache/incubator-mxnet-site/tree/beta-site
I will add more clarification about this PR. The redirect test in this PR is described below
Start: http://ec2-34-219-134-42.us-west-2.compute.amazonaws.com/versions/1.1.0/community/contribute.html
To: http://ec2-34-219-134-42.us-west-2.compute.amazonaws.com/versions/1.6/community/contribute.html
The redirect only takes effect when user visit `/versions/1.1.0/community/contribute.html` from outside of mxnet website. It could be from a google search result, or type this url into the browser directly. We get this info by checking whether HTTP request header `referer` is "apache.mxnet.org" or not. This is the behavior that I would like to verify on mxnet website server, it works well on preview host.
And to prevent redirect looping, if user goes to `/versions/1.1.0` => top nav bar => community => contribute, this also goes to contribution page but redirect won't be triggered because user is coming from mxnet website.
It looks like this beta git repo is too large to clone...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 commented on pull request #18738: set website default version - test redirect
Posted by GitBox <gi...@apache.org>.
ys2843 commented on pull request #18738:
URL: https://github.com/apache/incubator-mxnet/pull/18738#issuecomment-662224643
Will test this redirect on beta-stage site, https://github.com/apache/incubator-mxnet-site/pull/64
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 commented on pull request #18738: set website default version to current stable (1.6) version
Posted by GitBox <gi...@apache.org>.
ys2843 commented on pull request #18738:
URL: https://github.com/apache/incubator-mxnet/pull/18738#issuecomment-663215095
> @ys2843 - Can you please document the steps to update whenever there is new release in MXNet release process document?
Sure, will do. I will add documents to apache wiki and internal quip.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 commented on pull request #18738: set website default version - test redirect
Posted by GitBox <gi...@apache.org>.
ys2843 commented on pull request #18738:
URL: https://github.com/apache/incubator-mxnet/pull/18738#issuecomment-659646149
@mxnet-label-bot add [Website]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #18738: set website default version - test redirect
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #18738:
URL: https://github.com/apache/incubator-mxnet/pull/18738#issuecomment-660377875
> Yes, my plan is to copy the get_started.html directly from master branch to v1.6 static artifact (maybe need some change in the header)
Thank you. Do you mean only `get_started.html` or all pages under the `get_started` hierarchy?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on pull request #18738: set website default version to current stable (1.6) version
Posted by GitBox <gi...@apache.org>.
szha commented on pull request #18738:
URL: https://github.com/apache/incubator-mxnet/pull/18738#issuecomment-663165537
@ys2843 agreed. it would be great to see a proposal on how `.htaccess` usage limitation can happen. I'm merging this change now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] connorgoggins commented on pull request #18738: set website default version - test redirect
Posted by GitBox <gi...@apache.org>.
connorgoggins commented on pull request #18738:
URL: https://github.com/apache/incubator-mxnet/pull/18738#issuecomment-660340224
Instead of just testing redirects on the contribute page in the preview, shouldn't we be testing redirects across all pages?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 edited a comment on pull request #18738: set website default version - test redirect
Posted by GitBox <gi...@apache.org>.
ys2843 edited a comment on pull request #18738:
URL: https://github.com/apache/incubator-mxnet/pull/18738#issuecomment-660381271
> Not sure, but this didn't work: http://ec2-34-219-134-42.us-west-2.compute.amazonaws.com/community/contribute.html
> Shouldn't the dropdown read 1.6 if the redirect worked?
>
> You can use the beta site for testing redirects. It's perfect for this kind of testing.
> https://github.com/apache/incubator-mxnet-site/tree/beta-site
I will add more clarification about this PR. The redirect test in this PR is described below
Start: http://ec2-34-219-134-42.us-west-2.compute.amazonaws.com/versions/1.1.0/community/contribute.html
To: http://ec2-34-219-134-42.us-west-2.compute.amazonaws.com/versions/1.6/community/contribute.html
The redirect only takes effect when user visit `/versions/1.1.0/community/contribute.html` from outside of mxnet website. It could be from a google search result, or type this url into the browser directly. ( we get this info by checking whether HTTP request header `referer` is "apache.mxnet.org" or not)
And to prevent redirect looping, if user goes to `/versions/1.1.0` => top nav bar => community => contribute, this also goes to contribution page but redirect won't be triggered because user is coming from mxnet website.
It looks like this beta git repo is too large to clone...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 commented on pull request #18738: set website default version - test redirect
Posted by GitBox <gi...@apache.org>.
ys2843 commented on pull request #18738:
URL: https://github.com/apache/incubator-mxnet/pull/18738#issuecomment-660381271
> Not sure, but this didn't work: http://ec2-34-219-134-42.us-west-2.compute.amazonaws.com/community/contribute.html
> Shouldn't the dropdown read 1.6 if the redirect worked?
>
> You can use the beta site for testing redirects. It's perfect for this kind of testing.
> https://github.com/apache/incubator-mxnet-site/tree/beta-site
I will add more clarification about this PR. The only working redirect in this PR for testing is from
Start: http://ec2-34-219-134-42.us-west-2.compute.amazonaws.com/versions/1.1.0/community/contribute.html
To: http://ec2-34-219-134-42.us-west-2.compute.amazonaws.com/versions/1.6/community/contribute.html
The redirect only works when user enter `/versions/1.1.0/community/contribute.html` from outside of mxnet website. It could be from a google search result, or type this url into the browser and enter.
And to prevent redirect looping, if user goes to `/versions/1.1.0` => top nav bar => community => contribute, this also goes to contribution page but redirect won't be triggered because user is coming from mxnet website.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 commented on pull request #18738: set website default version - test redirect
Posted by GitBox <gi...@apache.org>.
ys2843 commented on pull request #18738:
URL: https://github.com/apache/incubator-mxnet/pull/18738#issuecomment-660372395
> Instead of just testing redirects on the contribute page in the preview, shouldn't we be testing redirects across all pages?
This PR is to ensure the redirect based on HTTP `referer` header works as expected in Apache Infra's server. Contribution page is just a random page for testing purpose, we will replace the lines with regex that applies to all pages.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 edited a comment on pull request #18738: set website default version - test redirect
Posted by GitBox <gi...@apache.org>.
ys2843 edited a comment on pull request #18738:
URL: https://github.com/apache/incubator-mxnet/pull/18738#issuecomment-660381271
> Not sure, but this didn't work: http://ec2-34-219-134-42.us-west-2.compute.amazonaws.com/community/contribute.html
> Shouldn't the dropdown read 1.6 if the redirect worked?
>
> You can use the beta site for testing redirects. It's perfect for this kind of testing.
> https://github.com/apache/incubator-mxnet-site/tree/beta-site
I will add more clarification about this PR. The redirect test in this PR is described below
Start: http://ec2-34-219-134-42.us-west-2.compute.amazonaws.com/versions/1.1.0/community/contribute.html
To: http://ec2-34-219-134-42.us-west-2.compute.amazonaws.com/versions/1.6/community/contribute.html
The redirect only takes effect when user enter `/versions/1.1.0/community/contribute.html` from outside of mxnet website. It could be from a google search result, or type this url into the browser directly. ( check HTTP `referer` is "apache.mxnet.org" or not)
And to prevent redirect looping, if user goes to `/versions/1.1.0` => top nav bar => community => contribute, this also goes to contribution page but redirect won't be triggered because user is coming from mxnet website.
It looks like this beta git repo is too large to clone...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #18738: set website default version - test redirect
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #18738:
URL: https://github.com/apache/incubator-mxnet/pull/18738#issuecomment-660339978
If `/versions/1.6/get_started` becomes the default, we need to backport the license fixes to that page. Is it possible? Or do we require using the 1.x branch given this constraint?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 edited a comment on pull request #18738: set website default version - test redirect
Posted by GitBox <gi...@apache.org>.
ys2843 edited a comment on pull request #18738:
URL: https://github.com/apache/incubator-mxnet/pull/18738#issuecomment-660381271
> Not sure, but this didn't work: http://ec2-34-219-134-42.us-west-2.compute.amazonaws.com/community/contribute.html
> Shouldn't the dropdown read 1.6 if the redirect worked?
>
> You can use the beta site for testing redirects. It's perfect for this kind of testing.
> https://github.com/apache/incubator-mxnet-site/tree/beta-site
I will add more clarification about this PR. The redirect test in this PR is described below
Start: http://ec2-34-219-134-42.us-west-2.compute.amazonaws.com/versions/1.1.0/community/contribute.html
To: http://ec2-34-219-134-42.us-west-2.compute.amazonaws.com/versions/1.6/community/contribute.html
The redirect only takes effect when user visit `/versions/1.1.0/community/contribute.html` from outside of mxnet website. It could be from a google search result, or type this url into the browser directly. ( we get this info by checking whether HTTP `referer` is "apache.mxnet.org" or not)
And to prevent redirect looping, if user goes to `/versions/1.1.0` => top nav bar => community => contribute, this also goes to contribution page but redirect won't be triggered because user is coming from mxnet website.
It looks like this beta git repo is too large to clone...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] aaronmarkham commented on pull request #18738: set website default version - test redirect
Posted by GitBox <gi...@apache.org>.
aaronmarkham commented on pull request #18738:
URL: https://github.com/apache/incubator-mxnet/pull/18738#issuecomment-660376969
Not sure, but this didn't work: http://ec2-34-219-134-42.us-west-2.compute.amazonaws.com/community/contribute.html
Shouldn't the dropdown read 1.6 if the redirect worked?
You can use the beta site for testing redirects. It's perfect for this kind of testing.
https://github.com/apache/incubator-mxnet-site/tree/beta-site
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18738: set website default version - test redirect
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18738:
URL: https://github.com/apache/incubator-mxnet/pull/18738#issuecomment-659635114
Hey @ys2843 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [edge, miscellaneous, unix-cpu, unix-gpu, windows-cpu, sanity, centos-cpu, website, windows-gpu, centos-gpu, clang]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on pull request #18738: set website default version to current stable (1.6) version
Posted by GitBox <gi...@apache.org>.
sandeep-krishnamurthy commented on pull request #18738:
URL: https://github.com/apache/incubator-mxnet/pull/18738#issuecomment-663174458
@ys2843 - Can you please document the steps to update whenever there is new release in MXNet release process document?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 commented on pull request #18738: set website default version - test redirect
Posted by GitBox <gi...@apache.org>.
ys2843 commented on pull request #18738:
URL: https://github.com/apache/incubator-mxnet/pull/18738#issuecomment-660382958
> > Yes, my plan is to copy the get_started.html directly from master branch to v1.6 static artifact (maybe need some change in the header)
>
> Thank you. Do you mean only `get_started.html` or all pages under the `get_started` hierarchy?
Should be all folder
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 edited a comment on pull request #18738: set website default version - test redirect
Posted by GitBox <gi...@apache.org>.
ys2843 edited a comment on pull request #18738:
URL: https://github.com/apache/incubator-mxnet/pull/18738#issuecomment-660381271
> Not sure, but this didn't work: http://ec2-34-219-134-42.us-west-2.compute.amazonaws.com/community/contribute.html
> Shouldn't the dropdown read 1.6 if the redirect worked?
>
> You can use the beta site for testing redirects. It's perfect for this kind of testing.
> https://github.com/apache/incubator-mxnet-site/tree/beta-site
I will add more clarification about this PR. The redirect test in this PR is described below
Start: http://ec2-34-219-134-42.us-west-2.compute.amazonaws.com/versions/1.1.0/community/contribute.html
To: http://ec2-34-219-134-42.us-west-2.compute.amazonaws.com/versions/1.6/community/contribute.html
The redirect only takes effect when user visit `/versions/1.1.0/community/contribute.html` from outside of mxnet website. It could be from a google search result, or type this url into the browser directly. We get this info by checking whether HTTP request header `referer` is "apache.mxnet.org" or not. This is the behavior that I would like to verify, it works well on preview host.
And to prevent redirect looping, if user goes to `/versions/1.1.0` => top nav bar => community => contribute, this also goes to contribution page but redirect won't be triggered because user is coming from mxnet website.
It looks like this beta git repo is too large to clone...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 edited a comment on pull request #18738: set website default version - test redirect
Posted by GitBox <gi...@apache.org>.
ys2843 edited a comment on pull request #18738:
URL: https://github.com/apache/incubator-mxnet/pull/18738#issuecomment-660381271
> Not sure, but this didn't work: http://ec2-34-219-134-42.us-west-2.compute.amazonaws.com/community/contribute.html
> Shouldn't the dropdown read 1.6 if the redirect worked?
>
> You can use the beta site for testing redirects. It's perfect for this kind of testing.
> https://github.com/apache/incubator-mxnet-site/tree/beta-site
I will add more clarification about this PR. The only working redirect in this PR for testing is described below
Start: http://ec2-34-219-134-42.us-west-2.compute.amazonaws.com/versions/1.1.0/community/contribute.html
To: http://ec2-34-219-134-42.us-west-2.compute.amazonaws.com/versions/1.6/community/contribute.html
The redirect only works when user enter `/versions/1.1.0/community/contribute.html` from outside of mxnet website. It could be from a google search result, or type this url into the browser directly. ( check HTTP `referer` is "apache.mxnet.org" or not)
And to prevent redirect looping, if user goes to `/versions/1.1.0` => top nav bar => community => contribute, this also goes to contribution page but redirect won't be triggered because user is coming from mxnet website.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 commented on pull request #18738: set website default version to current stable (1.6) version
Posted by GitBox <gi...@apache.org>.
ys2843 commented on pull request #18738:
URL: https://github.com/apache/incubator-mxnet/pull/18738#issuecomment-663164146
> while this change looks good, I think we definitely shouldn't make `.htaccess` a requirement for hosting as it precludes simple static hosting on file systems. This has been preventing a preview for website from being available in PRs and has caused many issues.
>
> I think removing website preview in PRs for using `.htaccess` was a wrong decision, and if the preview can't be re-enabled, we should deprecate the usage of `.htaccess`.
Thanks for reviewing. Since there are many content missing issues recently on master website reported from our customers.
@sandeep-krishnamurthy We decided to submit a fix ASAP without making large changes to website file structure and build process.
It would be good to reduce the usage of `.htaccess` to enable PR preview, but this need to start from fixing existing broken links since v1.6, which will take much longer time. Currently we think it is more critical to address customer complains in a short amount of time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 edited a comment on pull request #18738: set website default version - test redirect
Posted by GitBox <gi...@apache.org>.
ys2843 edited a comment on pull request #18738:
URL: https://github.com/apache/incubator-mxnet/pull/18738#issuecomment-660381271
> Not sure, but this didn't work: http://ec2-34-219-134-42.us-west-2.compute.amazonaws.com/community/contribute.html
> Shouldn't the dropdown read 1.6 if the redirect worked?
>
> You can use the beta site for testing redirects. It's perfect for this kind of testing.
> https://github.com/apache/incubator-mxnet-site/tree/beta-site
I will add more clarification about this PR. The only working redirect in this PR for testing is described below
Start: http://ec2-34-219-134-42.us-west-2.compute.amazonaws.com/versions/1.1.0/community/contribute.html
To: http://ec2-34-219-134-42.us-west-2.compute.amazonaws.com/versions/1.6/community/contribute.html
The redirect only works when user enter `/versions/1.1.0/community/contribute.html` from outside of mxnet website. It could be from a google search result, or type this url into the browser directly. ( check HTTP `referer` is "apache.mxnet.org" or not)
And to prevent redirect looping, if user goes to `/versions/1.1.0` => top nav bar => community => contribute, this also goes to contribution page but redirect won't be triggered because user is coming from mxnet website.
It looks like this beta git repo is too large to clone...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 edited a comment on pull request #18738: set website default version - test redirect
Posted by GitBox <gi...@apache.org>.
ys2843 edited a comment on pull request #18738:
URL: https://github.com/apache/incubator-mxnet/pull/18738#issuecomment-660381271
> Not sure, but this didn't work: http://ec2-34-219-134-42.us-west-2.compute.amazonaws.com/community/contribute.html
> Shouldn't the dropdown read 1.6 if the redirect worked?
>
> You can use the beta site for testing redirects. It's perfect for this kind of testing.
> https://github.com/apache/incubator-mxnet-site/tree/beta-site
I will add more clarification about this PR. The only working redirect in this PR for testing is described below
Start: http://ec2-34-219-134-42.us-west-2.compute.amazonaws.com/versions/1.1.0/community/contribute.html
To: http://ec2-34-219-134-42.us-west-2.compute.amazonaws.com/versions/1.6/community/contribute.html
The redirect only works when user enter `/versions/1.1.0/community/contribute.html` from outside of mxnet website. It could be from a google search result, or type this url into the browser directly. ( check HTTP `referer` is "apache.mxnet.org" or not)
And to prevent redirect looping, if user goes to `/versions/1.1.0` => top nav bar => community => contribute, this also goes to contribution page but redirect won't be triggered because user is coming from mxnet website.
Thanks for the suggestion, I will test it on beta site.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 edited a comment on pull request #18738: set website default version - test redirect
Posted by GitBox <gi...@apache.org>.
ys2843 edited a comment on pull request #18738:
URL: https://github.com/apache/incubator-mxnet/pull/18738#issuecomment-660381271
> Not sure, but this didn't work: http://ec2-34-219-134-42.us-west-2.compute.amazonaws.com/community/contribute.html
> Shouldn't the dropdown read 1.6 if the redirect worked?
>
> You can use the beta site for testing redirects. It's perfect for this kind of testing.
> https://github.com/apache/incubator-mxnet-site/tree/beta-site
I will add more clarification about this PR. The redirect test in this PR is described below
Start: http://ec2-34-219-134-42.us-west-2.compute.amazonaws.com/versions/1.1.0/community/contribute.html
To: http://ec2-34-219-134-42.us-west-2.compute.amazonaws.com/versions/1.6/community/contribute.html
The redirect only works when user enter `/versions/1.1.0/community/contribute.html` from outside of mxnet website. It could be from a google search result, or type this url into the browser directly. ( check HTTP `referer` is "apache.mxnet.org" or not)
And to prevent redirect looping, if user goes to `/versions/1.1.0` => top nav bar => community => contribute, this also goes to contribution page but redirect won't be triggered because user is coming from mxnet website.
It looks like this beta git repo is too large to clone...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org