You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/24 17:01:03 UTC
[GitHub] [arrow-rs] tustvold opened a new pull request, #3182: Support fixed length binary row
tustvold opened a new pull request, #3182:
URL: https://github.com/apache/arrow-rs/pull/3182
_Draft as builds upon #3180
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
We claim support for this data type, with the implementation actually panicking on `unreachable` if given such an array. It is fairly trivial to add support for this, so lets do so
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #3182: Support `FixedSizeBinary` in Row format
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #3182:
URL: https://github.com/apache/arrow-rs/pull/3182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on a diff in pull request #3182: Add support for FixedSizeBinary in Row format
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #3182:
URL: https://github.com/apache/arrow-rs/pull/3182#discussion_r1033949709
##########
arrow/src/row/mod.rs:
##########
@@ -809,6 +809,10 @@ fn new_empty_rows(
.iter()
.zip(lengths.iter_mut())
.for_each(|(slice, length)| *length += variable::encoded_len(slice)),
+ DataType::FixedSizeBinary(len) => {
Review Comment:
I double checked and there is no such thing as `FixedSizeLargeBinary` https://github.com/apache/arrow-rs/blob/6f41b95de4a0ac33319b9e96e179b47fcd71fdbf/arrow-schema/src/datatype.rs#L155-L157 👍
##########
arrow/src/row/fixed.rs:
##########
@@ -201,6 +201,29 @@ pub fn encode<T: FixedLengthEncoding, I: IntoIterator<Item = Option<T>>>(
}
}
+pub fn encode_fixed_size_binary(
+ out: &mut Rows,
+ array: &FixedSizeBinaryArray,
+ opts: SortOptions,
+) {
+ let len = array.value_length() as usize;
+ for (offset, maybe_val) in out.offsets.iter_mut().skip(1).zip(array.iter()) {
+ let end_offset = *offset + len + 1;
+ if let Some(val) = maybe_val {
+ let to_write = &mut out.buffer[*offset..end_offset];
+ to_write[0] = 1;
Review Comment:
Maybe it is worth noting that this value is chosen to be neither 0 or 0xff (the null sentinels)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #3182: Support `FixedSizeBinary` in Row format
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3182:
URL: https://github.com/apache/arrow-rs/pull/3182#issuecomment-1330498202
Benchmark runs are scheduled for baseline = 733d32e90b67bbc62bcff6fc4aa1873d43d4e686 and contender = ab3f384483c4fef645f9d1653f1adda3470594b2. ab3f384483c4fef645f9d1653f1adda3470594b2 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/90d19da96c394af5a6231f973a78d021...e909bcbd30214144ac7f396ba91c32e5/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/1e6cb17d62ce4b99ba8d6f6e07efa72a...cc00510f52494ab483ab5bac8b393f26/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/32dbbdaf952246c3bb8a56cd5da446f7...6fc3afde0e8f45aab44accb6db49019b/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/685225b2370948719ad516153439a557...3eb42c730e684100a69dfb25c45bf203/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org