You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/12 20:07:26 UTC
[GitHub] [arrow] jonkeane opened a new pull request #10703: ARROW-13215: [R] [CI] Add ENV TZ to docker files? [WIP]
jonkeane opened a new pull request #10703:
URL: https://github.com/apache/arrow/pull/10703
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on a change in pull request #10703: ARROW-13215: [R] [CI] Add ENV TZ to docker files?
Posted by GitBox <gi...@apache.org>.
rok commented on a change in pull request #10703:
URL: https://github.com/apache/arrow/pull/10703#discussion_r668885770
##########
File path: .github/workflows/r.yml
##########
@@ -89,7 +89,9 @@ jobs:
run: |
sudo sysctl -w kernel.core_pattern="core.%e.%p"
ulimit -c unlimited
- archery docker run ubuntu-r
+ # Setting a non-default and non-probable MArquesas French Polynesia time
Review comment:
```suggestion
# Setting a non-default and non-probable Marquesas French Polynesia time
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #10703: ARROW-13215: [R] [CI] Add ENV TZ to docker files? [WIP]
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #10703:
URL: https://github.com/apache/arrow/pull/10703#issuecomment-878456705
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson closed pull request #10703: ARROW-13215: [R] [CI] Add ENV TZ to docker files
Posted by GitBox <gi...@apache.org>.
nealrichardson closed pull request #10703:
URL: https://github.com/apache/arrow/pull/10703
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #10703: ARROW-13215: [R] [CI] Add ENV TZ to docker files?
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #10703:
URL: https://github.com/apache/arrow/pull/10703#issuecomment-879312187
@github-actions crossbow submit -g r
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on a change in pull request #10703: ARROW-13215: [R] [CI] Add ENV TZ to docker files?
Posted by GitBox <gi...@apache.org>.
jonkeane commented on a change in pull request #10703:
URL: https://github.com/apache/arrow/pull/10703#discussion_r669007854
##########
File path: .github/workflows/r.yml
##########
@@ -89,7 +89,9 @@ jobs:
run: |
sudo sysctl -w kernel.core_pattern="core.%e.%p"
ulimit -c unlimited
- archery docker run ubuntu-r
+ # Setting a non-default and non-probable Marquesas French Polynesia time
+ # it has both with a .45 offset and very very few people who live there.
+ archery docker run -e TZ=MART ubuntu-r
Review comment:
Yeah, you're right — this isn't totally parameterized the way we want.
The outcome _is_ similar to what we want: `TZ` is set to `"UTC"` (really any valid value that's not `""` will get rid of the nuisance warning) and then when during the docker run when the tests are run `TZ` is set to `"MART"` and so the tests are run in a non-UTC timezones (which is when we care about it being an improbable timezone).
It shouldn't matter what the TZ is set to during the build process, but I'm going to parameterize this fully so that this confusion doesn't bite us elsewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10703: ARROW-13215: [R] [CI] Add ENV TZ to docker files? [WIP]
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10703:
URL: https://github.com/apache/arrow/pull/10703#issuecomment-878360285
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on pull request #10703: ARROW-13215: [R] [CI] Add ENV TZ to docker files?
Posted by GitBox <gi...@apache.org>.
thisisnic commented on pull request #10703:
URL: https://github.com/apache/arrow/pull/10703#issuecomment-879139111
Great idea, much simpler than the other workarounds for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10703: ARROW-13215: [R] [CI] Add ENV TZ to docker files?
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10703:
URL: https://github.com/apache/arrow/pull/10703#issuecomment-879312746
Revision: 20ba50f286ba815b8afe9861c3cb0d39b6d99ec8
Submitted crossbow builds: [ursacomputing/crossbow @ actions-589](https://github.com/ursacomputing/crossbow/branches/all?query=actions-589)
|Task|Status|
|----|------|
|conda-linux-gcc-py36-cpu-r40|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-589-azure-conda-linux-gcc-py36-cpu-r40)|
|conda-linux-gcc-py37-cpu-r41|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-589-azure-conda-linux-gcc-py37-cpu-r41)|
|conda-osx-clang-py36-r40|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-589-azure-conda-osx-clang-py36-r40)|
|conda-osx-clang-py37-r41|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-589-azure-conda-osx-clang-py37-r41)|
|conda-win-vs2017-py36-r40|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-589-azure-conda-win-vs2017-py36-r40)|
|conda-win-vs2017-py37-r41|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-589-azure-conda-win-vs2017-py37-r41)|
|homebrew-r-autobrew|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-589-github-homebrew-r-autobrew)|
|test-r-devdocs|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-589-github-test-r-devdocs)|
|test-r-gcc-11|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-589-github-test-r-gcc-11)|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-589-github-test-r-install-local)|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-589-github-test-r-linux-as-cran)|
|test-r-linux-rchk|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-589-github-test-r-linux-rchk)|
|test-r-linux-valgrind|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-589-azure-test-r-linux-valgrind)|
|test-r-minimal-build|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-589-azure-test-r-minimal-build)|
|test-r-rhub-ubuntu-gcc-release-latest|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-589-azure-test-r-rhub-ubuntu-gcc-release-latest)|
|test-r-rocker-r-base-latest|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-589-azure-test-r-rocker-r-base-latest)|
|test-r-rstudio-r-base-3.6-bionic|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-589-azure-test-r-rstudio-r-base-3.6-bionic)|
|test-r-rstudio-r-base-3.6-centos7-devtoolset-8|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-589-azure-test-r-rstudio-r-base-3.6-centos7-devtoolset-8)|
|test-r-rstudio-r-base-3.6-centos8|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-589-azure-test-r-rstudio-r-base-3.6-centos8)|
|test-r-rstudio-r-base-3.6-opensuse15|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-589-azure-test-r-rstudio-r-base-3.6-opensuse15)|
|test-r-rstudio-r-base-3.6-opensuse42|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-589-azure-test-r-rstudio-r-base-3.6-opensuse42)|
|test-r-rtools-35|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-589-github-test-r-rtools-35)|
|test-r-ubuntu-21.04|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-589-github-test-r-ubuntu-21.04)|
|test-r-version-compatibility|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-589-github-test-r-version-compatibility)|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-589-github-test-r-versions)|
|test-r-without-arrow|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-589-azure-test-r-without-arrow)|
|test-ubuntu-18.04-r-sanitizer|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-589-azure-test-ubuntu-18.04-r-sanitizer)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on a change in pull request #10703: ARROW-13215: [R] [CI] Add ENV TZ to docker files?
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #10703:
URL: https://github.com/apache/arrow/pull/10703#discussion_r668972260
##########
File path: .github/workflows/r.yml
##########
@@ -89,7 +89,9 @@ jobs:
run: |
sudo sysctl -w kernel.core_pattern="core.%e.%p"
ulimit -c unlimited
- archery docker run ubuntu-r
+ # Setting a non-default and non-probable Marquesas French Polynesia time
+ # it has both with a .45 offset and very very few people who live there.
+ archery docker run -e TZ=MART ubuntu-r
Review comment:
Are you *sure* this works? I thought `-e` was for passing env vars into the runtime environment in the docker container, but you want to parametrize the dockerfile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #10703: ARROW-13215: [R] [CI] Add ENV TZ to docker files? [WIP]
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #10703:
URL: https://github.com/apache/arrow/pull/10703#issuecomment-878360194
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org