You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/12 17:16:37 UTC
[GitHub] [shardingsphere] DivvSaxena opened a new pull request, #22130: Update MetaDataContexts.java
DivvSaxena opened a new pull request, #22130:
URL: https://github.com/apache/shardingsphere/pull/22130
Fixes
Changes proposed in this pull request:
-Unify metadata naming
-
-
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on a diff in pull request #22130: Update MetaDataContexts.java
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on code in PR #22130:
URL: https://github.com/apache/shardingsphere/pull/22130#discussion_r1021223058
##########
infra/util/src/main/java/org/apache/shardingsphere/infra/util/spi/aware/SPIMetadataAware.java:
##########
@@ -20,7 +20,7 @@
import java.util.Collection;
/**
- * SPI metadata aware.
+ * SPI metadata aware.
Review Comment:
This whitespace is unnecessary, so can we close this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on a diff in pull request #22130: Update MetaDataContexts.java
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on code in PR #22130:
URL: https://github.com/apache/shardingsphere/pull/22130#discussion_r1021041734
##########
infra/util/src/main/java/org/apache/shardingsphere/infra/util/spi/aware/SPIMetadataAware.java:
##########
@@ -20,7 +20,7 @@
import java.util.Collection;
/**
- * SPI metadata aware.
+ * SPI metadata aware.
Review Comment:
Just added a space here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] DivvSaxena commented on a diff in pull request #22130: Update MetaDataContexts.java
Posted by GitBox <gi...@apache.org>.
DivvSaxena commented on code in PR #22130:
URL: https://github.com/apache/shardingsphere/pull/22130#discussion_r1021219022
##########
infra/util/src/main/java/org/apache/shardingsphere/infra/util/spi/aware/SPIMetadataAware.java:
##########
@@ -20,7 +20,7 @@
import java.util.Collection;
/**
- * SPI metadata aware.
+ * SPI metadata aware.
Review Comment:
Hi @RaigorJiang !
yes , I think while reviewing so many files I added that by mistake
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] DivvSaxena commented on a diff in pull request #22130: Update MetaDataContexts.java
Posted by GitBox <gi...@apache.org>.
DivvSaxena commented on code in PR #22130:
URL: https://github.com/apache/shardingsphere/pull/22130#discussion_r1021272809
##########
infra/util/src/main/java/org/apache/shardingsphere/infra/util/spi/aware/SPIMetadataAware.java:
##########
@@ -20,7 +20,7 @@
import java.util.Collection;
/**
- * SPI metadata aware.
+ * SPI metadata aware.
Review Comment:
Okay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] DivvSaxena closed pull request #22130: Update MetaDataContexts.java
Posted by GitBox <gi...@apache.org>.
DivvSaxena closed pull request #22130: Update MetaDataContexts.java
URL: https://github.com/apache/shardingsphere/pull/22130
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #22130: Update MetaDataContexts.java
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #22130:
URL: https://github.com/apache/shardingsphere/pull/22130#issuecomment-1312540209
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/22130?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22130](https://codecov.io/gh/apache/shardingsphere/pull/22130?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3c4441e) into [master](https://codecov.io/gh/apache/shardingsphere/commit/81837b76b1a95064cc6338e7fbe71515327377c8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (81837b7) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #22130 +/- ##
=========================================
Coverage 61.15% 61.15%
Complexity 2544 2544
=========================================
Files 4109 4109
Lines 57160 57160
Branches 9682 9682
=========================================
Hits 34955 34955
Misses 19253 19253
Partials 2952 2952
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] DivvSaxena commented on a diff in pull request #22130: Update MetaDataContexts.java
Posted by GitBox <gi...@apache.org>.
DivvSaxena commented on code in PR #22130:
URL: https://github.com/apache/shardingsphere/pull/22130#discussion_r1021219022
##########
infra/util/src/main/java/org/apache/shardingsphere/infra/util/spi/aware/SPIMetadataAware.java:
##########
@@ -20,7 +20,7 @@
import java.util.Collection;
/**
- * SPI metadata aware.
+ * SPI metadata aware.
Review Comment:
yes , I think while reviewing so many files I added that by mistake
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org