You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2017/11/07 12:58:41 UTC

Review Request 63612: Modified formatting of v1 scheduler test driver for consistency.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63612/
-----------------------------------------------------------

Review request for mesos, Michael Park and Vinod Kone.


Repository: mesos


Description
-------

See summary.


Diffs
-----

  src/tests/mesos.hpp e25defeb55608136e77363aa48cf820092a13a59 


Diff: https://reviews.apache.org/r/63612/diff/1/


Testing
-------

See https://reviews.apache.org/r/63615/


Thanks,

Alexander Rukletsov


Re: Review Request 63612: Modified formatting of v1 scheduler test driver for consistency.

Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63612/#review190837
-----------------------------------------------------------



AFAICT this was already formatted consistently with Mesos conventions. Now the `inverseOffers` and `rescindInverseOffers` declarations are different from the `offerOperationUpdate`, which makes it look weird.

- James Peach


On Nov. 7, 2017, 12:58 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63612/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2017, 12:58 p.m.)
> 
> 
> Review request for mesos, Michael Park and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.hpp e25defeb55608136e77363aa48cf820092a13a59 
> 
> 
> Diff: https://reviews.apache.org/r/63612/diff/1/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/63615/
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Re: Review Request 63612: Modified formatting of v1 scheduler test driver for consistency.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63612/
-----------------------------------------------------------

(Updated Nov. 13, 2017, 8:51 p.m.)


Review request for mesos, Michael Park and Vinod Kone.


Repository: mesos


Description
-------

See summary.


Diffs
-----

  src/tests/mesos.hpp e25defeb55608136e77363aa48cf820092a13a59 


Diff: https://reviews.apache.org/r/63612/diff/1/


Testing
-------

See https://reviews.apache.org/r/63615/


Thanks,

Alexander Rukletsov