You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "lingsamuel (via GitHub)" <gi...@apache.org> on 2023/06/16 07:03:47 UTC

[GitHub] [apisix-helm-chart] lingsamuel commented on a diff in pull request #553: feat: allow to override admin token for ingress controller

lingsamuel commented on code in PR #553:
URL: https://github.com/apache/apisix-helm-chart/pull/553#discussion_r1231861575


##########
charts/apisix-ingress-controller/templates/configmap.yaml:
##########
@@ -58,7 +58,11 @@ data:
       {{ else }}
       default_cluster_base_url: http://{{ .Values.config.apisix.serviceName }}.{{ .Values.config.apisix.serviceNamespace }}.svc.{{ .Values.clusterDomain }}:{{ .Values.config.apisix.servicePort }}/apisix/admin
       {{- end}}
+      {{- if .Values.config.apisix.existingSecret }}
+      default_cluster_admin_key: "{{"{{"}}.APISIX_ADMIN_KEY{{"}}"}}"

Review Comment:
   missing `$` prefix?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org