You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/02/10 19:17:01 UTC
[GitHub] [iceberg-docs] xccui opened a new pull request #52: Flink getting-started doc cleanup
xccui opened a new pull request #52:
URL: https://github.com/apache/iceberg-docs/pull/52
1. Refine the doc to improve readability;
2. Add some notes.
The uncertain sentences are marked with a series of question marks (????????????????).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] rdblue commented on a change in pull request #52: Flink getting-started doc cleanup
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #52:
URL: https://github.com/apache/iceberg-docs/pull/52#discussion_r821276441
##########
File path: docs/content/docs/flink/flink-getting-started.md
##########
@@ -22,31 +22,31 @@ url: flink
# Flink
-Apache Iceberg supports both [Apache Flink](https://flink.apache.org/)'s DataStream API and Table API. Currently,
-Iceberg integration for Apache Flink is available for Flink versions 1.12, 1.13, and 1.14. Previous versions of Iceberg also support Flink 1.11.
+Apache Iceberg supports both [Apache Flink](https://flink.apache.org/)'s DataStream API and Table API/SQL. Currently,
+Iceberg can with work Apache Flink versions 1.12, 1.13, and 1.14. Previous versions of Iceberg also support Flink 1.11.
Review comment:
Please revert this. This is no more clear than the previous statement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] xccui commented on pull request #52: Flink getting-started doc cleanup
Posted by GitBox <gi...@apache.org>.
xccui commented on pull request #52:
URL: https://github.com/apache/iceberg-docs/pull/52#issuecomment-1055492100
Hi @stevenzwu, would you take some time to take a look? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] rdblue commented on a change in pull request #52: Flink getting-started doc cleanup
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #52:
URL: https://github.com/apache/iceberg-docs/pull/52#discussion_r821276311
##########
File path: docs/content/docs/flink/flink-getting-started.md
##########
@@ -22,31 +22,31 @@ url: flink
# Flink
-Apache Iceberg supports both [Apache Flink](https://flink.apache.org/)'s DataStream API and Table API. Currently,
-Iceberg integration for Apache Flink is available for Flink versions 1.12, 1.13, and 1.14. Previous versions of Iceberg also support Flink 1.11.
+Apache Iceberg supports both [Apache Flink](https://flink.apache.org/)'s DataStream API and Table API/SQL. Currently,
+Iceberg can with work Apache Flink versions 1.12, 1.13, and 1.14. Previous versions of Iceberg also support Flink 1.11.
| Feature support | Flink | Notes |
| ----------------------------------------------------------- | ----- | ------------------------------------------------------------ |
| [SQL create catalog](#creating-catalogs-and-using-catalogs) | ✔️ | |
| [SQL create database](#create-database) | ✔️ | |
| [SQL create table](#create-table) | ✔️ | |
| [SQL create table like](#create-table-like) | ✔️ | |
-| [SQL alter table](#alter-table) | ✔️ | Only support altering table properties, column and partition changes are not supported |
+| [SQL alter table](#alter-table) | ✔️ | Only support altering table properties. Changing column and partition are not supported. |
Review comment:
There is no need for punctuation here and this rephrase isn't making the point more clear. Can you please revert this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] xccui commented on pull request #52: Flink getting-started doc cleanup
Posted by GitBox <gi...@apache.org>.
xccui commented on pull request #52:
URL: https://github.com/apache/iceberg-docs/pull/52#issuecomment-1075339630
Hi @rdblue @kbendick, would you take another look when it's convenient? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] kbendick commented on a change in pull request #52: Flink getting-started doc cleanup
Posted by GitBox <gi...@apache.org>.
kbendick commented on a change in pull request #52:
URL: https://github.com/apache/iceberg-docs/pull/52#discussion_r826147105
##########
File path: docs/content/docs/flink/flink-getting-started.md
##########
@@ -33,20 +33,20 @@ Iceberg integration for Apache Flink is available for Flink versions 1.12, 1.13,
| [SQL create table like](#create-table-like) | ✔️ | |
| [SQL alter table](#alter-table) | ✔️ | Only support altering table properties, column and partition changes are not supported |
| [SQL drop_table](#drop-table) | ✔️ | |
-| [SQL select](#querying-with-sql) | ✔️ | Support both streaming and batch mode |
-| [SQL insert into](#insert-into) | ✔️ ️ | Support both streaming and batch mode |
+| [SQL select](#querying-with-sql) | ✔️ | Support both streaming and batch mode. |
+| [SQL insert into](#insert-into) | ✔️ ️ | Support both streaming and batch mode. |
| [SQL insert overwrite](#insert-overwrite) | ✔️ ️ | |
| [DataStream read](#reading-with-datastream) | ✔️ ️ | |
| [DataStream append](#appending-data) | ✔️ ️ | |
| [DataStream overwrite](#overwrite-data) | ✔️ ️ | |
-| [Metadata tables](#inspecting-tables) | ️ | Support Java API but does not support Flink SQL |
+| [Metadata tables](#inspecting-tables) | ️ | Only support in Java API but not in Flink SQL. |
Review comment:
Nit:`Only supported with the Java API, not with Flink SQL.`
If you're updating the others, I'd update them as well to be more correctly phrased English sentences / phrases (so basically changing `only support` -> `only supports` or `only supported with` etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] xccui commented on pull request #52: Flink getting-started doc cleanup
Posted by GitBox <gi...@apache.org>.
xccui commented on pull request #52:
URL: https://github.com/apache/iceberg-docs/pull/52#issuecomment-1080976253
@rdblue @kbendick Sorry for bothering you again. I know you must have been busy working on some more urgent stuff. Just wonder if you still think this PR makes sense and would like me to keep it up to date with the latest change. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] xccui edited a comment on pull request #52: Flink getting-started doc cleanup
Posted by GitBox <gi...@apache.org>.
xccui edited a comment on pull request #52:
URL: https://github.com/apache/iceberg-docs/pull/52#issuecomment-1055492100
Hi @stevenzwu, would you have some time to take a look? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org