You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/03/25 00:02:02 UTC

[GitHub] [lucene] gsmiller commented on pull request #747: LUCENE-10325: Add getTopDims functionality to Facets

gsmiller commented on pull request #747:
URL: https://github.com/apache/lucene/pull/747#issuecomment-1078517172


   This looks good to me at this point. Since this changes the code path for existing faceting functionality, it would be a good idea to run `luceneutil` benchmarks and make sure there are no obvious regressions. I wouldn't suspect there to be, but it would be nice to catch them now if there are. @Yuti-G would you mind posting those results here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org