You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2016/12/07 05:09:16 UTC
Review Request 54470: Windows: Fixed default isolators in Agent.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54470/
-----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
Bugs: MESOS-6717
https://issues.apache.org/jira/browse/MESOS-6717
Repository: mesos
Description
-------
Windows: Fixed default isolators in Agent.
This commit partially addresses MESOS-6717, specifically the fact that
some of the default isolators currently used by the Agent are
POSIX-specific, and will cause every Agent test to crash.
In particular, this commit will transition Windows builds of the agent
away from using the `posix/cpu`, `posix/mem`, and `filesystem/posix`
isolators by default, replacing them with `windows/cpu` and
`filesystem/windows` (sadly, there is not yet a memory isolator for
Windows).
Diffs
-----
src/slave/containerizer/mesos/containerizer.cpp 6d50755fa24eb67bb72a78f9acc69c7e5eecabe2
src/slave/flags.cpp 67326eece05e6300d1407ed8887aabb2f06fe9cd
src/slave/http.cpp 91eebe117d3dc86dd5b1fd47156c01e147165cef
src/tests/mesos.cpp 8fd8bcb033f47e2538aa36cd373c892a882afdfd
Diff: https://reviews.apache.org/r/54470/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 54470: Windows: Fixed default isolators in Agent.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54470/#review158324
-----------------------------------------------------------
Patch looks great!
Reviews applied: [54324, 53550, 53551, 53552, 52778, 54395, 54415, 54446, 54453, 54462, 54470]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 7, 2016, 5:09 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54470/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2016, 5:09 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
>
>
> Bugs: MESOS-6717
> https://issues.apache.org/jira/browse/MESOS-6717
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Fixed default isolators in Agent.
>
> This commit partially addresses MESOS-6717, specifically the fact that
> some of the default isolators currently used by the Agent are
> POSIX-specific, and will cause every Agent test to crash.
>
> In particular, this commit will transition Windows builds of the agent
> away from using the `posix/cpu`, `posix/mem`, and `filesystem/posix`
> isolators by default, replacing them with `windows/cpu` and
> `filesystem/windows` (sadly, there is not yet a memory isolator for
> Windows).
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp 6d50755fa24eb67bb72a78f9acc69c7e5eecabe2
> src/slave/flags.cpp 67326eece05e6300d1407ed8887aabb2f06fe9cd
> src/slave/http.cpp 91eebe117d3dc86dd5b1fd47156c01e147165cef
> src/tests/mesos.cpp 8fd8bcb033f47e2538aa36cd373c892a882afdfd
>
> Diff: https://reviews.apache.org/r/54470/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 54470: Windows: Fixed default isolators in Agent.
Posted by Joseph Wu <jo...@mesosphere.io>.
> On Dec. 7, 2016, 5:18 p.m., Joseph Wu wrote:
> > LGTM.
Oh, one more thing:
We can remove the `--isolation=windows/cpu,filesystem/windows` in `docs/windows.md` now.
- Joseph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54470/#review158434
-----------------------------------------------------------
On Dec. 6, 2016, 9:09 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54470/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2016, 9:09 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
>
>
> Bugs: MESOS-6717
> https://issues.apache.org/jira/browse/MESOS-6717
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Fixed default isolators in Agent.
>
> This commit partially addresses MESOS-6717, specifically the fact that
> some of the default isolators currently used by the Agent are
> POSIX-specific, and will cause every Agent test to crash.
>
> In particular, this commit will transition Windows builds of the agent
> away from using the `posix/cpu`, `posix/mem`, and `filesystem/posix`
> isolators by default, replacing them with `windows/cpu` and
> `filesystem/windows` (sadly, there is not yet a memory isolator for
> Windows).
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp 6d50755fa24eb67bb72a78f9acc69c7e5eecabe2
> src/slave/flags.cpp 67326eece05e6300d1407ed8887aabb2f06fe9cd
> src/slave/http.cpp 91eebe117d3dc86dd5b1fd47156c01e147165cef
> src/tests/mesos.cpp 8fd8bcb033f47e2538aa36cd373c892a882afdfd
>
> Diff: https://reviews.apache.org/r/54470/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 54470: Windows: Fixed default isolators in Agent.
Posted by Alex Clemmer <cl...@gmail.com>.
> On Dec. 8, 2016, 1:18 a.m., Joseph Wu wrote:
> > src/slave/http.cpp, lines 952-956
> > <https://reviews.apache.org/r/54470/diff/1/?file=1578509#file1578509line952>
> >
> > This is just an example JSON blob. I don't think ifdef-ing this is worthwhile :)
> >
> > I can remove it before committing if you agree.
Agreed, take it out. Actually I wasn't sure what the implications were here so I just `#ifdef`'d it. I do think it's worth putting the windows isolators in the examples, though.
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54470/#review158434
-----------------------------------------------------------
On Dec. 7, 2016, 5:09 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54470/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2016, 5:09 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
>
>
> Bugs: MESOS-6717
> https://issues.apache.org/jira/browse/MESOS-6717
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Fixed default isolators in Agent.
>
> This commit partially addresses MESOS-6717, specifically the fact that
> some of the default isolators currently used by the Agent are
> POSIX-specific, and will cause every Agent test to crash.
>
> In particular, this commit will transition Windows builds of the agent
> away from using the `posix/cpu`, `posix/mem`, and `filesystem/posix`
> isolators by default, replacing them with `windows/cpu` and
> `filesystem/windows` (sadly, there is not yet a memory isolator for
> Windows).
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp 6d50755fa24eb67bb72a78f9acc69c7e5eecabe2
> src/slave/flags.cpp 67326eece05e6300d1407ed8887aabb2f06fe9cd
> src/slave/http.cpp 91eebe117d3dc86dd5b1fd47156c01e147165cef
> src/tests/mesos.cpp 8fd8bcb033f47e2538aa36cd373c892a882afdfd
>
> Diff: https://reviews.apache.org/r/54470/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 54470: Windows: Fixed default isolators in Agent.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54470/#review158434
-----------------------------------------------------------
Ship it!
LGTM.
src/slave/http.cpp (lines 952 - 956)
<https://reviews.apache.org/r/54470/#comment229209>
This is just an example JSON blob. I don't think ifdef-ing this is worthwhile :)
I can remove it before committing if you agree.
- Joseph Wu
On Dec. 6, 2016, 9:09 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54470/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2016, 9:09 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
>
>
> Bugs: MESOS-6717
> https://issues.apache.org/jira/browse/MESOS-6717
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Fixed default isolators in Agent.
>
> This commit partially addresses MESOS-6717, specifically the fact that
> some of the default isolators currently used by the Agent are
> POSIX-specific, and will cause every Agent test to crash.
>
> In particular, this commit will transition Windows builds of the agent
> away from using the `posix/cpu`, `posix/mem`, and `filesystem/posix`
> isolators by default, replacing them with `windows/cpu` and
> `filesystem/windows` (sadly, there is not yet a memory isolator for
> Windows).
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp 6d50755fa24eb67bb72a78f9acc69c7e5eecabe2
> src/slave/flags.cpp 67326eece05e6300d1407ed8887aabb2f06fe9cd
> src/slave/http.cpp 91eebe117d3dc86dd5b1fd47156c01e147165cef
> src/tests/mesos.cpp 8fd8bcb033f47e2538aa36cd373c892a882afdfd
>
> Diff: https://reviews.apache.org/r/54470/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>