You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "Gary-Hobson (via GitHub)" <gi...@apache.org> on 2023/02/23 09:22:09 UTC
[GitHub] [nuttx] Gary-Hobson opened a new pull request, #8635: Perfcount
Gary-Hobson opened a new pull request, #8635:
URL: https://github.com/apache/nuttx/pull/8635
## Summary
use perfcount as the clock source for tv_nsec to achieve higher precision time.
systime has insufficient time precision and will not display correctly when viewing finer-grained traces
## Impact
Affects trace_dump.c: https://github.com/apache/nuttx-apps/pull/1593
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 merged pull request #8635: correct systime with perf count
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #8635:
URL: https://github.com/apache/nuttx/pull/8635
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8635: correct systime with perf count
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #8635:
URL: https://github.com/apache/nuttx/pull/8635#discussion_r1115432655
##########
sched/Kconfig:
##########
@@ -973,12 +973,6 @@ config SCHED_INSTRUMENTATION_CPUSET
---help---
Monitor only CPUs in the bitset. Bit 0=CPU0, Bit1=CPU1, etc.
-config SCHED_INSTRUMENTATION_HIRES
Review Comment:
remove SCHED_INSTRUMENTATION_HIRES in the whole code base.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] Gary-Hobson commented on a diff in pull request #8635: correct systime with perf count
Posted by "Gary-Hobson (via GitHub)" <gi...@apache.org>.
Gary-Hobson commented on code in PR #8635:
URL: https://github.com/apache/nuttx/pull/8635#discussion_r1115440849
##########
sched/Kconfig:
##########
@@ -973,12 +973,6 @@ config SCHED_INSTRUMENTATION_CPUSET
---help---
Monitor only CPUs in the bitset. Bit 0=CPU0, Bit1=CPU1, etc.
-config SCHED_INSTRUMENTATION_HIRES
Review Comment:
All removed, others in this PR： https://github.com/apache/nuttx-apps/pull/1593
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8635: correct systime with perf count
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #8635:
URL: https://github.com/apache/nuttx/pull/8635#discussion_r1115479381
##########
sched/Kconfig:
##########
@@ -973,12 +973,6 @@ config SCHED_INSTRUMENTATION_CPUSET
---help---
Monitor only CPUs in the bitset. Bit 0=CPU0, Bit1=CPU1, etc.
-config SCHED_INSTRUMENTATION_HIRES
Review Comment:
but here has one left: https://github.com/apache/nuttx/blob/master/Documentation/guides/tasktraceuser.rst
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] Gary-Hobson commented on pull request #8635: correct systime with perf count
Posted by "Gary-Hobson (via GitHub)" <gi...@apache.org>.
Gary-Hobson commented on PR #8635:
URL: https://github.com/apache/nuttx/pull/8635#issuecomment-1441614619
CI compilation needs to depend on https://github.com/apache/nuttx-apps/pull/1593
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org