You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "ding-young (via GitHub)" <gi...@apache.org> on 2025/05/19 13:42:01 UTC

[I] Migrate memory_pool/pool tests to insta [datafusion]

ding-young opened a new issue, #16099:
URL: https://github.com/apache/datafusion/issues/16099

   ### Description
   In https://github.com/apache/datafusion/issues/15178, we're switching hard-coded constants in tests to insta. 
   
   This issue targets updating tests in pool.rs (datafusion/execution/memory_pool/pool) so that testing long string err messages is easier via snapshot tests.
   
   One example that needs to be switched to insta is 
   https://github.com/apache/datafusion/blob/3e30f77f08aa9184029da80c7f7e2ec00999fa44/datafusion/execution/src/memory_pool/pool.rs#L512
   
   ### Reference 
   - https://datafusion.apache.org/contributor-guide/testing.html#snapshot-testing
   - PRs linked to [original issue](https://github.com/apache/datafusion/issues/15178) will help how to migrate these tests. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [I] Migrate memory_pool/pool tests to insta [datafusion]

Posted by "lifan-ake (via GitHub)" <gi...@apache.org>.
lifan-ake commented on issue #16099:
URL: https://github.com/apache/datafusion/issues/16099#issuecomment-2900509704

   take


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [I] Migrate memory_pool/pool tests to insta [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #16099:
URL: https://github.com/apache/datafusion/issues/16099#issuecomment-2891517594

   cc @qstommyshu 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [I] Migrate memory_pool/pool tests to insta [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed issue #16099: Migrate memory_pool/pool tests to insta
URL: https://github.com/apache/datafusion/issues/16099


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org