You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/06 18:47:10 UTC
[GitHub] [arrow] kou commented on a change in pull request #11991: ARROW-13554: [C++] Remove deprecated Scanner::Scan
kou commented on a change in pull request #11991:
URL: https://github.com/apache/arrow/pull/11991#discussion_r779774043
##########
File path: c_glib/arrow-dataset-glib/scanner.cpp
##########
@@ -48,63 +48,47 @@ enum {
PROP_SCANNER = 1,
};
-G_DEFINE_TYPE_WITH_PRIVATE(GADatasetScanner,
- gadataset_scanner,
- G_TYPE_OBJECT)
+G_DEFINE_TYPE_WITH_PRIVATE(GADatasetScanner, gadataset_scanner, G_TYPE_OBJECT)
-#define GADATASET_SCANNER_GET_PRIVATE(obj) \
- static_cast<GADatasetScannerPrivate *>( \
- gadataset_scanner_get_instance_private( \
- GADATASET_SCANNER(obj)))
+#define GADATASET_SCANNER_GET_PRIVATE(obj) \
+ static_cast<GADatasetScannerPrivate*>( \
+ gadataset_scanner_get_instance_private(GADATASET_SCANNER(obj)))
Review comment:
Please don't format `c_glib/` files automatically.
`c_glib/` doesn't use auto format tool.
Please keep the current style as much as possible.
##########
File path: c_glib/arrow-dataset-glib/scanner.cpp
##########
@@ -132,95 +113,59 @@ gadataset_scanner_to_table(GADatasetScanner *scanner,
}
}
-
typedef struct GADatasetScannerBuilderPrivate_ {
std::shared_ptr<arrow::dataset::ScannerBuilder> scanner_builder;
} GADatasetScannerBuilderPrivate;
-enum {
- PROP_SCANNER_BUILDER = 1,
- PROP_USE_ASYNC,
-};
+enum { PROP_SCANNER_BUILDER = 1 };
-G_DEFINE_TYPE_WITH_PRIVATE(GADatasetScannerBuilder,
- gadataset_scanner_builder,
+G_DEFINE_TYPE_WITH_PRIVATE(GADatasetScannerBuilder, gadataset_scanner_builder,
G_TYPE_OBJECT)
-#define GADATASET_SCANNER_BUILDER_GET_PRIVATE(obj) \
- static_cast<GADatasetScannerBuilderPrivate *>( \
- gadataset_scanner_builder_get_instance_private( \
- GADATASET_SCANNER_BUILDER(obj)))
+#define GADATASET_SCANNER_BUILDER_GET_PRIVATE(obj) \
+ static_cast<GADatasetScannerBuilderPrivate*>( \
+ gadataset_scanner_builder_get_instance_private(GADATASET_SCANNER_BUILDER(obj)))
-static void
-gadataset_scanner_builder_finalize(GObject *object)
-{
+static void gadataset_scanner_builder_finalize(GObject* object) {
auto priv = GADATASET_SCANNER_BUILDER_GET_PRIVATE(object);
priv->scanner_builder.~shared_ptr();
G_OBJECT_CLASS(gadataset_scanner_builder_parent_class)->finalize(object);
}
-static void
-gadataset_scanner_builder_set_property(GObject *object,
- guint prop_id,
- const GValue *value,
- GParamSpec *pspec)
-{
+static void gadataset_scanner_builder_set_property(GObject* object, guint prop_id,
+ const GValue* value,
+ GParamSpec* pspec) {
auto priv = GADATASET_SCANNER_BUILDER_GET_PRIVATE(object);
switch (prop_id) {
- case PROP_SCANNER_BUILDER:
- priv->scanner_builder =
- *static_cast<std::shared_ptr<arrow::dataset::ScannerBuilder> *>(
- g_value_get_pointer(value));
- break;
- case PROP_USE_ASYNC:
- garrow::check(nullptr,
- priv->scanner_builder->UseAsync(g_value_get_boolean(value)),
- "[scanner-builder][use-async][set]");
- break;
- default:
- G_OBJECT_WARN_INVALID_PROPERTY_ID(object, prop_id, pspec);
- break;
+ case PROP_SCANNER_BUILDER:
+ priv->scanner_builder =
+ *static_cast<std::shared_ptr<arrow::dataset::ScannerBuilder>*>(
+ g_value_get_pointer(value));
+ break;
+ default:
+ G_OBJECT_WARN_INVALID_PROPERTY_ID(object, prop_id, pspec);
+ break;
}
}
-static void
-gadataset_scanner_builder_init(GADatasetScannerBuilder *object)
-{
+static void gadataset_scanner_builder_init(GADatasetScannerBuilder* object) {
auto priv = GADATASET_SCANNER_BUILDER_GET_PRIVATE(object);
- new(&priv->scanner_builder) std::shared_ptr<arrow::dataset::ScannerBuilder>;
+ new (&priv->scanner_builder) std::shared_ptr<arrow::dataset::ScannerBuilder>;
}
-static void
-gadataset_scanner_builder_class_init(GADatasetScannerBuilderClass *klass)
-{
+static void gadataset_scanner_builder_class_init(GADatasetScannerBuilderClass* klass) {
auto gobject_class = G_OBJECT_CLASS(klass);
- gobject_class->finalize = gadataset_scanner_builder_finalize;
+ gobject_class->finalize = gadataset_scanner_builder_finalize;
gobject_class->set_property = gadataset_scanner_builder_set_property;
- GParamSpec *spec;
- spec = g_param_spec_pointer("scanner-builder",
- "Scanner builder",
- "The raw "
- "std::shared<arrow::dataset::ScannerBuilder> *",
- static_cast<GParamFlags>(G_PARAM_WRITABLE |
- G_PARAM_CONSTRUCT_ONLY));
+ GParamSpec* spec;
+ spec = g_param_spec_pointer(
+ "scanner-builder", "Scanner builder",
+ "The raw "
+ "std::shared<arrow::dataset::ScannerBuilder> *",
+ static_cast<GParamFlags>(G_PARAM_WRITABLE | G_PARAM_CONSTRUCT_ONLY));
g_object_class_install_property(gobject_class, PROP_SCANNER_BUILDER, spec);
-
- arrow::dataset::ScanOptions default_options;
- /**
- * GADatasetScannerBuilder:use-async:
- *
- * Whether or not async mode is used.
- *
- * Since: 6.0.0
- */
- spec = g_param_spec_boolean("use-async",
Review comment:
We can use `g_warning()` for deprecating.
But we can remove it without deprecating in this case because it was only used internally for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org