You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by bryongloden <gi...@git.apache.org> on 2016/08/11 23:05:57 UTC
[GitHub] trafficserver pull request #855: fix the memory leaks
GitHub user bryongloden opened a pull request:
https://github.com/apache/trafficserver/pull/855
fix the memory leaks
On line no. 74 of '[test_P_DNS.cc](https://github.com/apache/trafficserver/blob/master/iocore/dns/test_P_DNS.cc#L74)' there is a memory leak and on line no. 72 of '[test_P_Net.cc](https://github.com/apache/trafficserver/blob/master/iocore/net/test_P_Net.cc#L72)' there is memory leak -- both memory leaks are errors.
Found by https://github.com/bryongloden/cppcheck
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryongloden/trafficserver patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/855.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #855
----
commit 9a7a865a4bc9d981d367d0d856cda853677a4a85
Author: Bryon Gloden, CISSP� <ci...@bryongloden.com>
Date: 2016-08-11T22:57:56Z
Update test_P_DNS.cc
[iocore/dns/test_P_DNS.cc:74]: (error) Memory leak: str
commit 43baedea3a2107f04eaba459e426e956b4e75c29
Author: Bryon Gloden, CISSP� <ci...@bryongloden.com>
Date: 2016-08-11T22:59:36Z
Update test_P_Net.cc
[iocore/net/test_P_Net.cc:72]: (error) Memory leak: str
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #855: TS-4794 fix the memory leaks
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/855
@bryongloden please address James' concern, and we can land this (after we run it on the CI again).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #855: fix the memory leaks
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/855
Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/421/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #855: fix the memory leaks
Posted by bryongloden <gi...@git.apache.org>.
Github user bryongloden commented on the issue:
https://github.com/apache/trafficserver/pull/855
Greetings @zwoop \U0001f62c
Sorry, what is a JIRA number? I've never heard this before. And I know how to change the commit message; is this the same as the subject line? If so, what should I update it to say? \U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #855: fix the memory leaks
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/855
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #855: TS-4794 fix the memory leaks
Posted by bryongloden <gi...@git.apache.org>.
Github user bryongloden commented on the issue:
https://github.com/apache/trafficserver/pull/855
Thank you @zwoop \U0001f44d
REF: https://issues.apache.org/jira/browse/TS-4794
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #855: fix the memory leaks
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/855
Ah, so you have to create a Jira ticket (for now at least) in conjunction with the Github PR. Go to https://issues.apache.org/jira/browse/TS/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel and create an account (unless you already did), create a new Issue for the Traffic Server project, and it will give you a TS-<nnnn> number. That's the Jira issue number, and you should refer to it in all commits etc. for this particular issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #855: fix the memory leaks
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/855
Also would have a Jira # in the subject line please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #855: fix the memory leaks
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/855
Needs to run "make clang-format". :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #855: TS-4794 fix the memory leaks
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/855
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #855: TS-4794 fix the memory leaks
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/855#discussion_r77410158
--- Diff: iocore/dns/test_P_DNS.cc ---
@@ -70,6 +70,7 @@ struct NetTesterSM : public Continuation {
default:
ink_release_assert(!"unknown event");
}
+ delete[] str;
--- End diff --
``str`` needs to be initialized to NULL.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #855: TS-4794 fix the memory leaks
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/855#discussion_r77410114
--- Diff: iocore/net/test_P_Net.cc ---
@@ -68,6 +68,7 @@ struct NetTesterSM : public Continuation {
default:
ink_release_assert(!"unknown event");
}
+ delete[] str;
--- End diff --
``str`` needs to be initialized to NULL.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #855: fix the memory leaks
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/855
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/524/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---