You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "lhotari (via GitHub)" <gi...@apache.org> on 2023/10/27 02:10:47 UTC
[PR] [fix][test] Fix thread leaks related to unclosed WebSocketService [pulsar]
lhotari opened a new pull request, #21453:
URL: https://github.com/apache/pulsar/pull/21453
### Motivation
There are a few tests where threads are leaked since WebSocketService isn't closed.
### Additional context
This type of issues can now be detected with #21450 improvements to CI.
### Modifications
Close WebSocketService properly in tests.
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][test] Fix thread leaks related to unclosed WebSocketService [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari merged PR #21453:
URL: https://github.com/apache/pulsar/pull/21453
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][test] Fix thread leaks related to unclosed WebSocketService [pulsar]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #21453:
URL: https://github.com/apache/pulsar/pull/21453#issuecomment-1783885784
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/21453?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#21453](https://app.codecov.io/gh/apache/pulsar/pull/21453?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (09ef5f6) into [master](https://app.codecov.io/gh/apache/pulsar/commit/2b5c199053a5b2d7f849e6604d619bae9197a8c9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (2b5c199) will **decrease** coverage by `0.10%`.
> Report is 3 commits behind head on master.
> The diff coverage is `n/a`.
[](https://app.codecov.io/gh/apache/pulsar/pull/21453?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #21453 +/- ##
============================================
- Coverage 73.31% 73.21% -0.10%
+ Complexity 32599 32565 -34
============================================
Files 1890 1890
Lines 140357 140357
Branches 15425 15425
============================================
- Hits 102903 102765 -138
- Misses 29361 29495 +134
- Partials 8093 8097 +4
```
| [Flag](https://app.codecov.io/gh/apache/pulsar/pull/21453/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [inttests](https://app.codecov.io/gh/apache/pulsar/pull/21453/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `24.24% <ø> (+0.01%)` | :arrow_up: |
| [systests](https://app.codecov.io/gh/apache/pulsar/pull/21453/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `24.71% <ø> (-0.08%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pulsar/pull/21453/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `72.50% <ø> (-0.09%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 76 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/21453/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org