You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by bi...@apache.org on 2018/09/27 13:17:56 UTC
[kylin] branch master updated: Use parseInt() to parse a primitive
instead of to use boxing/unboxing
This is an automated email from the ASF dual-hosted git repository.
billyliu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kylin.git
The following commit(s) were added to refs/heads/master by this push:
new 08c451f Use parseInt() to parse a primitive instead of to use boxing/unboxing
08c451f is described below
commit 08c451fb901eb252797be945f31dd113da79d983
Author: Lijun Cao <64...@qq.com>
AuthorDate: Thu Sep 27 17:17:22 2018 +0800
Use parseInt() to parse a primitive instead of to use boxing/unboxing
---
.../org/apache/kylin/storage/hbase/lookup/HBaseLookupRowEncoder.java | 2 +-
tool/src/main/java/org/apache/kylin/tool/JobInstanceExtractor.java | 2 +-
tool/src/main/java/org/apache/kylin/tool/KylinLogExtractor.java | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/lookup/HBaseLookupRowEncoder.java b/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/lookup/HBaseLookupRowEncoder.java
index 9ceabd2..7269465 100644
--- a/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/lookup/HBaseLookupRowEncoder.java
+++ b/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/lookup/HBaseLookupRowEncoder.java
@@ -109,7 +109,7 @@ public class HBaseLookupRowEncoder extends AbstractLookupRowEncoder<HBaseRow> {
for (Entry<byte[], byte[]> qualifierValEntry : qualifierValMap.entrySet()) {
byte[] qualifier = qualifierValEntry.getKey();
byte[] value = qualifierValEntry.getValue();
- int valIdx = Integer.valueOf(Bytes.toString(qualifier));
+ int valIdx = Integer.parseInt(Bytes.toString(qualifier));
result[valIdx] = fromBytes(value);
}
}
diff --git a/tool/src/main/java/org/apache/kylin/tool/JobInstanceExtractor.java b/tool/src/main/java/org/apache/kylin/tool/JobInstanceExtractor.java
index bc61f94..18ace6f 100644
--- a/tool/src/main/java/org/apache/kylin/tool/JobInstanceExtractor.java
+++ b/tool/src/main/java/org/apache/kylin/tool/JobInstanceExtractor.java
@@ -83,7 +83,7 @@ public class JobInstanceExtractor extends AbstractInfoExtractor {
protected void executeExtract(OptionsHelper optionsHelper, File exportDir) throws Exception {
String cube = optionsHelper.hasOption(OPTION_CUBE) ? optionsHelper.getOptionValue(OPTION_CUBE) : null;
String project = optionsHelper.hasOption(OPTION_PROJECT) ? optionsHelper.getOptionValue(OPTION_PROJECT) : null;
- int period = optionsHelper.hasOption(OPTION_PERIOD) ? Integer.valueOf(optionsHelper.getOptionValue(OPTION_PERIOD)) : DEFAULT_PERIOD;
+ int period = optionsHelper.hasOption(OPTION_PERIOD) ? Integer.parseInt(optionsHelper.getOptionValue(OPTION_PERIOD)) : DEFAULT_PERIOD;
long endTime = System.currentTimeMillis();
long startTime = endTime - period * 24 * 3600 * 1000; // time in Millis
diff --git a/tool/src/main/java/org/apache/kylin/tool/KylinLogExtractor.java b/tool/src/main/java/org/apache/kylin/tool/KylinLogExtractor.java
index 80af352..a84345b 100644
--- a/tool/src/main/java/org/apache/kylin/tool/KylinLogExtractor.java
+++ b/tool/src/main/java/org/apache/kylin/tool/KylinLogExtractor.java
@@ -73,7 +73,7 @@ public class KylinLogExtractor extends AbstractInfoExtractor {
protected void executeExtract(OptionsHelper optionsHelper, File exportDir) throws Exception {
beforeExtract();
- int logPeriod = optionsHelper.hasOption(OPTION_LOG_PERIOD) ? Integer.valueOf(optionsHelper.getOptionValue(OPTION_LOG_PERIOD)) : DEFAULT_LOG_PERIOD;
+ int logPeriod = optionsHelper.hasOption(OPTION_LOG_PERIOD) ? Integer.parseInt(optionsHelper.getOptionValue(OPTION_LOG_PERIOD)) : DEFAULT_LOG_PERIOD;
if (logPeriod < 1) {
logger.warn("No logs to extract.");