You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/04/28 20:44:41 UTC
[GitHub] [trafficserver] shinrich opened a new pull request #7757: Add dead server policy control and metric. Improve messages.
shinrich opened a new pull request #7757:
URL: https://github.com/apache/trafficserver/pull/7757
This should help debug #7638. Also addresses some issues in #7290
We are running with this changes in production. I have exercised the new proxy.config.http.connect.dead.policy setting in production on a box, but @djcarlin needs to exercise it more widely.
This PR adds a setting proxy.config.http.connect.dead.policy to add some control over what kind of failures should count towards a dead server. In our deployment, we want to only mark a server dead it if is failing the TCP level connection. TLS failures like bad certificates may just be applicable to certain traffic to the server, so failures there should not mark the entire server dead.
The PR also adds a metric proxy.process.http.dead_server.no_requests to track how many client requests are returned immediately because the server is dead and retries is set to 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich commented on pull request #7757: Add dead server policy control and metric. Improve messages.
Posted by GitBox <gi...@apache.org>.
shinrich commented on pull request #7757:
URL: https://github.com/apache/trafficserver/pull/7757#issuecomment-828778875
[approve ci clang-format]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich commented on pull request #7757: Add dead server policy control and metric. Improve messages.
Posted by GitBox <gi...@apache.org>.
shinrich commented on pull request #7757:
URL: https://github.com/apache/trafficserver/pull/7757#issuecomment-828778622
[ci approve clang-format]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich merged pull request #7757: Add dead server policy control and metric. Improve messages.
Posted by GitBox <gi...@apache.org>.
shinrich merged pull request #7757:
URL: https://github.com/apache/trafficserver/pull/7757
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #7757: Add dead server policy control and metric. Improve messages.
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #7757:
URL: https://github.com/apache/trafficserver/pull/7757#issuecomment-893613048
@bneradt This has some merge conflicts, and as discussed, we'd like to change those Errors() for now for the 9.1.0 branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #7757: Add dead server policy control and metric. Improve messages.
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #7757:
URL: https://github.com/apache/trafficserver/pull/7757#issuecomment-893698435
Backported in #8213
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich removed a comment on pull request #7757: Add dead server policy control and metric. Improve messages.
Posted by GitBox <gi...@apache.org>.
shinrich removed a comment on pull request #7757:
URL: https://github.com/apache/trafficserver/pull/7757#issuecomment-828778622
[ci approve clang-format]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit commented on pull request #7757: Add dead server policy control and metric. Improve messages.
Posted by GitBox <gi...@apache.org>.
maskit commented on pull request #7757:
URL: https://github.com/apache/trafficserver/pull/7757#issuecomment-867860309
I'm curious how `proxy.config.http.connect.dead.policy` would work for QUIC connections. The current description explicitly says "TCP handshake failures", but it's not limited to the "handshake", right? I assume it includes connection failures due to DNS issue and packet routing issue as well.
If so, we might want to generalize the description (or clarifying the border) before we make a release with this to avoid incompatible changes in the future. That would also help implementing this for QUIC connections. If I read current description literally, QUIC connection failures would never be counted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org