You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by conker84 <gi...@git.apache.org> on 2017/03/12 09:45:09 UTC
[GitHub] zeppelin pull request #2125: [ZEPPELIN-2222] Add Network Visualization
GitHub user conker84 opened a pull request:
https://github.com/apache/zeppelin/pull/2125
[ZEPPELIN-2222] Add Network Visualization
### What is this PR for?
This issue is about a new network visualization that can leverage the Property Graph Model (https://github.com/tinkerpop/gremlin/wiki/Defining-a-Property-Graph), but also simple graphs in order to provide a set of base apis that can be used by graph dbs (like Neo4j) or graph processing frameworks (like GraphX or Giraph).
### What type of PR is it?
[Feature]
Is related to the #1582
### Todos
* [x] - Added the intepreter apis to manage graphs (under the pakage **org.apache.zeppelin.interpreter.graph**)
* [x] - Added the frontend apis to manage graphs (via d3js)
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2222
### How should this be tested?
You can download [this notebook](https://gist.github.com/conker84/9574127c2389d08164423894aa93b67f) to test the PR
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/conker84/zeppelin master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2125.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2125
----
commit a1fcb2248b8facb68795c4c48d663d1030707f8c
Author: conker84 <sa...@gmail.com>
Date: 2017-03-06T23:29:26Z
Created Network Visualization
commit ec9fd6367e00644fb0912fb69cb0281a86c27293
Author: conker84 <sa...@gmail.com>
Date: 2017-03-06T23:33:49Z
Commit to trigger travis
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2125
I think this is introducing a new result type from interpreter on the backend side that could be useful for this new Neo4J interpreter and other graph-base ones in the future?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization
Posted by conker84 <gi...@git.apache.org>.
Github user conker84 commented on the issue:
https://github.com/apache/zeppelin/pull/2125
i tried but it still fails...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization
Posted by conker84 <gi...@git.apache.org>.
Github user conker84 commented on the issue:
https://github.com/apache/zeppelin/pull/2125
It should be ok now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization
Posted by conker84 <gi...@git.apache.org>.
Github user conker84 commented on the issue:
https://github.com/apache/zeppelin/pull/2125
Thank you guys now I'll proceed with the second part of the original PR. The Neo4j's interpreter:)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2125
@conker84 Hi, could you take care this issue might be related without NETWORK viz?
- https://issues.apache.org/jira/browse/ZEPPELIN-2663
```html
<div ng-if="type == 'TABLE' || type == 'NETWORK'" class="btn-group">
<button type="button" class="btn btn-default btn-sm"
ng-repeat="viz in builtInTableDataVisualizationList track by $index"
ng-if="viz.supports.indexOf(type) > -1"
ng-class="{'active' : viz.id == graphMode && !config.helium.activeApp}"
ng-click="switchViz(viz.id)"
tooltip-placement="bottom" uib-tooltip="{{viz.name ? viz.name : ''}}"
ng-bind-html="viz.icon">
</button>
</div>
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization
Posted by conker84 <gi...@git.apache.org>.
Github user conker84 commented on the issue:
https://github.com/apache/zeppelin/pull/2125
Still no news?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2125
Congrats! And thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2125
UI can be improved in the following PRs. So it's ok not to resolve the whole things in this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization
Posted by conker84 <gi...@git.apache.org>.
Github user conker84 commented on the issue:
https://github.com/apache/zeppelin/pull/2125
Hi, could you please update me about the status of the review? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization
Posted by conker84 <gi...@git.apache.org>.
Github user conker84 commented on the issue:
https://github.com/apache/zeppelin/pull/2125
No news?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization
Posted by conker84 <gi...@git.apache.org>.
Github user conker84 commented on the issue:
https://github.com/apache/zeppelin/pull/2125
@jongyoul thanks for the answer, i checked the [Spel](https://zeppelin.apache.org/docs/snapshot/development/writingzeppelinspell.html) and the [Visualization](https://zeppelin.apache.org/docs/latest/development/writingzeppelinvisualization.html) and i understood they are **front-end only**. This contribution is a mixed front/back-end becouse it want to provide a set of base api in order to enable graph-databases's exploration (like Neo4j or others) with Zeppelin.
This contribution is the first step of #1582 the second is to implement the Neo4j Interpreter on top to the GraphResult apis.
If you guys think there is a more valuable solution to this i'm happy to talk about!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2125
Hi, @conker84
Here is failed JOB and looks irrelevant. But could you make CI green?
- https://travis-ci.org/conker84/zeppelin/jobs/227364420
you can click `restart` button in travis.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2125
@conker84 you should rebase based on master, not other branch. Currently, your change mixed with others.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2125
Do you mean the conflicts ? You need to do git rebase
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2125
@conker84 Hi, I have a question. I'm not sure but classes under org.apache.zeppelin.interpreter.graph is used only for testing it. Can you verify it? If it does, can you move these classes under test?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization
Posted by conker84 <gi...@git.apache.org>.
Github user conker84 commented on the issue:
https://github.com/apache/zeppelin/pull/2125
Hi guys,
i'm still waiting an answer, maybe there is no interest to this PR, it's ok for me but just give me some feedback. Sorry if i bother you but I need this with the Neo4jIntepreter for a small PoC that i have to develop so I need infos in order to plan my work.
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2125
I will test and give you feedback soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2125
Oh, I'm sorry for the late reply. I think you'd better to move those classes into another PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2125
Really sorry for late reply. I missed notification for a while.
- Spell might use JSON output of neo4j interpreter utilizing [sigma.js](http://sigmajs.org/), [vis.js](http://visjs.org/network_examples.html)
- Having default network display system using generalized graph model (Property Graph Model) would be good idea.
- Personally, hope to get more refined, pretty graph UI instead of d3 network.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization
Posted by conker84 <gi...@git.apache.org>.
Github user conker84 commented on the issue:
https://github.com/apache/zeppelin/pull/2125
The #1582 initally was with sigma.js but i found a strange memory consuption that broke the browser after the #1529 so i migrated to d3 network visualization, i chose d3 instead of vis.js in order to reduce project's dependencies.
I you want i can try with vis.js!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2125
It's just my opinion. Thus, it's ok to use d3 if you think it's reasonable \U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization
Posted by conker84 <gi...@git.apache.org>.
Github user conker84 commented on the issue:
https://github.com/apache/zeppelin/pull/2125
@1ambda the graph is flatten by javascript apis so we can leverage the other visualizations provided by Zeppelin
I'll add a video asap to show how it works!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2125
Can you make CI green?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2125
FYI, i didn't mean you have to create other PRs. Others can improve UI.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization
Posted by conker84 <gi...@git.apache.org>.
Github user conker84 commented on the issue:
https://github.com/apache/zeppelin/pull/2125
Ok! So i'll rebase the code ASAP.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization
Posted by conker84 <gi...@git.apache.org>.
Github user conker84 commented on the issue:
https://github.com/apache/zeppelin/pull/2125
Is it now ok?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2125
Thanks, Will merge it after CI become green
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization
Posted by conker84 <gi...@git.apache.org>.
Github user conker84 commented on the issue:
https://github.com/apache/zeppelin/pull/2125
Let me know if you want go ahead with this PR or i have to close it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2125
@conker84 Thanks for this nice contribution. We introduced Spell in the latest release. Spell helps you contribute this kind of wonderful visualization as easier than now. @1ambda Can you guide to convert it to Spell?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization
Posted by conker84 <gi...@git.apache.org>.
Github user conker84 commented on the issue:
https://github.com/apache/zeppelin/pull/2125
We are talk about graphdb, the UI is an important part of the PR, as well as the new interpreter apis!
I'm looking forward to your feedback.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2125
Please rebase it upon upstream master branch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2125
@felixcheung Yes, I already checked it but I was confused the branch name is master. :-) Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization
Posted by conker84 <gi...@git.apache.org>.
Github user conker84 commented on the issue:
https://github.com/apache/zeppelin/pull/2125
Hi guys i'm still here, let me know if i can do something to simplify the review!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2125
@conker84 Pretty graph! I have one question.
- It's looks like new display system works with backend interpreter.
- And enabled when we click the `network` visualization icon.
So, what happens when we click 'table` or other visualization icons in the situation? (the screenshot you attached.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2125
@conker84 I found it's your first contribution. Thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization
Posted by conker84 <gi...@git.apache.org>.
Github user conker84 commented on the issue:
https://github.com/apache/zeppelin/pull/2125
Done!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization
Posted by conker84 <gi...@git.apache.org>.
Github user conker84 commented on the issue:
https://github.com/apache/zeppelin/pull/2125
Hi @1ambda I created the #2421
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2125: [ZEPPELIN-2222] Add Network Visualization
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2125
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2125
1. Regarding to `continuous-integration/appveyor/pr — AppVeyor build failed`, you should rebase. Since master has `.appvepor.yml` file.
2. In case of Jenkins, you are failing to profile 3 (selenium test)
- [raw log](https://s3.amazonaws.com/archive.travis-ci.org/jobs/227364420/log.txt?X-Amz-Expires=30&X-Amz-Date=20170504T121444Z&X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAJRYRXRSVGNKPKO5A/20170504/us-east-1/s3/aws4_request&X-Amz-SignedHeaders=host&X-Amz-Signature=1a7a934aff18da242587c547c957ace22807c6a84edcc70be96d48465c161611)
```
Tests in error:
AuthenticationIT.testGroupPermission:190->AbstractZeppelinIT.pollingWait:94 » Timeout
InterpreterIT.testShowDescriptionOnInterpreterCreate:69 » ElementNotVisible El...
```
They might be flaky tests. You can simply pass them by clicking `restart` button in travis.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization
Posted by conker84 <gi...@git.apache.org>.
Github user conker84 commented on the issue:
https://github.com/apache/zeppelin/pull/2125
@jongyoul this contribution is the result of the split of #1582 in two little PR; the classes under `org.apache.zeppelin.interpreter.graph` provide the basic abstraction that can be used by graph dbs (like Neo4j, OrientDB, ArangoDB etc...) or graph processing frameworks (like GraphX or Giraph) and they will be used by the second part of the contribution which is the Neo4j interpreter, if you think is more appropriate I can move these classes into the second contribution.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization
Posted by conker84 <gi...@git.apache.org>.
Github user conker84 commented on the issue:
https://github.com/apache/zeppelin/pull/2125
I think i made some error with git commits please can someone help me?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization
Posted by conker84 <gi...@git.apache.org>.
Github user conker84 commented on the issue:
https://github.com/apache/zeppelin/pull/2125
Yes i made the rebase but it starts from the history **dc7b100** instead of **43352ae** and i can't understand why.
Have you some ideas?
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2125
looks like everything is green on travis but jenkins isn't picking them up
https://travis-ci.org/conker84/zeppelin/builds/240773799
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization
Posted by conker84 <gi...@git.apache.org>.
Github user conker84 commented on the issue:
https://github.com/apache/zeppelin/pull/2125
Yes it is!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization
Posted by tae-jun <gi...@git.apache.org>.
Github user tae-jun commented on the issue:
https://github.com/apache/zeppelin/pull/2125
@conker84 FYI, you can simply just take a GIF using software called **LICEcap**, and upload it directly here with drag and drop :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization
Posted by conker84 <gi...@git.apache.org>.
Github user conker84 commented on the issue:
https://github.com/apache/zeppelin/pull/2125
Hi guys any news/feedback?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization
Posted by conker84 <gi...@git.apache.org>.
Github user conker84 commented on the issue:
https://github.com/apache/zeppelin/pull/2125
Is it now ok?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---