You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gastón Kleiman <ga...@mesosphere.io> on 2017/09/22 18:18:34 UTC
Review Request 62168: Added a test using a file URI and the
DefaultExecutor.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62168/
-----------------------------------------------------------
Review request for mesos, Greg Mann and Vinod Kone.
Bugs: MESOS-7916
https://issues.apache.org/jira/browse/MESOS-7916
Repository: mesos
Description
-------
This test verifies that URIs are fetched and made available to tasks
started by the DefaultExecutor.
Diffs
-----
src/tests/default_executor_tests.cpp dd1a6ad0d4e2bf74972e15b478652196ee9cd927
Diff: https://reviews.apache.org/r/62168/diff/1/
Testing
-------
Thanks,
Gastón Kleiman
Re: Review Request 62168: Added a test using a file URI and the
DefaultExecutor.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62168/#review186044
-----------------------------------------------------------
Patch looks great!
Reviews applied: [62197, 61982, 62042, 62168]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Sept. 22, 2017, 6:18 p.m., Gastón Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62168/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2017, 6:18 p.m.)
>
>
> Review request for mesos, Greg Mann and Vinod Kone.
>
>
> Bugs: MESOS-7916
> https://issues.apache.org/jira/browse/MESOS-7916
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test verifies that URIs are fetched and made available to tasks
> started by the DefaultExecutor.
>
>
> Diffs
> -----
>
> src/tests/default_executor_tests.cpp dd1a6ad0d4e2bf74972e15b478652196ee9cd927
>
>
> Diff: https://reviews.apache.org/r/62168/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gastón Kleiman
>
>
Re: Review Request 62168: Added a test using a file URI and the
DefaultExecutor.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62168/#review186006
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/default_executor_tests.cpp
Lines 1375 (patched)
<https://reviews.apache.org/r/62168/#comment262358>
s/URIs/URIs set on the task/
- Vinod Kone
On Sept. 22, 2017, 6:18 p.m., Gastón Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62168/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2017, 6:18 p.m.)
>
>
> Review request for mesos, Greg Mann and Vinod Kone.
>
>
> Bugs: MESOS-7916
> https://issues.apache.org/jira/browse/MESOS-7916
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test verifies that URIs are fetched and made available to tasks
> started by the DefaultExecutor.
>
>
> Diffs
> -----
>
> src/tests/default_executor_tests.cpp dd1a6ad0d4e2bf74972e15b478652196ee9cd927
>
>
> Diff: https://reviews.apache.org/r/62168/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gastón Kleiman
>
>
Re: Review Request 62168: Added a test using a file URI and the
DefaultExecutor.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62168/#review186015
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 62197.
Failed command: `python.exe .\support\apply-reviews.py -n -r 62197`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62168
Relevant logs:
- [apply-review-62197-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62168/logs/apply-review-62197-stdout.log):
```
error: patch failed: src/tests/mesos.hpp:472
error: src/tests/mesos.hpp: patch does not apply
```
- Mesos Reviewbot Windows
On Sept. 22, 2017, 6:18 p.m., Gastón Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62168/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2017, 6:18 p.m.)
>
>
> Review request for mesos, Greg Mann and Vinod Kone.
>
>
> Bugs: MESOS-7916
> https://issues.apache.org/jira/browse/MESOS-7916
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test verifies that URIs are fetched and made available to tasks
> started by the DefaultExecutor.
>
>
> Diffs
> -----
>
> src/tests/default_executor_tests.cpp dd1a6ad0d4e2bf74972e15b478652196ee9cd927
>
>
> Diff: https://reviews.apache.org/r/62168/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gastón Kleiman
>
>
Re: Review Request 62168: Added a test using a file URI and the
DefaultExecutor.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62168/
-----------------------------------------------------------
(Updated Sept. 29, 2017, 12:06 p.m.)
Review request for mesos, Greg Mann and Vinod Kone.
Changes
-------
Rebased.
Bugs: MESOS-7916
https://issues.apache.org/jira/browse/MESOS-7916
Repository: mesos
Description
-------
This test verifies that URIs set on tasks are fetched and made available
to them when started by the DefaultExecutor.
Diffs (updated)
-----
src/tests/default_executor_tests.cpp dd1a6ad0d4e2bf74972e15b478652196ee9cd927
Diff: https://reviews.apache.org/r/62168/diff/3/
Changes: https://reviews.apache.org/r/62168/diff/2-3/
Testing
-------
The test succeeded for over 500 iterations on GNU/Linux.
Thanks,
Gaston Kleiman
Re: Review Request 62168: Added a test using a file URI and the
DefaultExecutor.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62168/#review186465
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 62197.
Failed command: `python.exe .\support\apply-reviews.py -n -r 62197`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62168
Relevant logs:
- [apply-review-62197-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62168/logs/apply-review-62197-stdout.log):
```
error: patch failed: src/tests/mesos.hpp:472
error: src/tests/mesos.hpp: patch does not apply
```
- Mesos Reviewbot Windows
On Sept. 27, 2017, 3:07 p.m., Gastón Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62168/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2017, 3:07 p.m.)
>
>
> Review request for mesos, Greg Mann and Vinod Kone.
>
>
> Bugs: MESOS-7916
> https://issues.apache.org/jira/browse/MESOS-7916
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test verifies that URIs set on tasks are fetched and made available
> to them when started by the DefaultExecutor.
>
>
> Diffs
> -----
>
> src/tests/default_executor_tests.cpp dd1a6ad0d4e2bf74972e15b478652196ee9cd927
>
>
> Diff: https://reviews.apache.org/r/62168/diff/2/
>
>
> Testing
> -------
>
> The test succeeded for over 500 iterations on GNU/Linux.
>
>
> Thanks,
>
> Gastón Kleiman
>
>
Re: Review Request 62168: Added a test using a file URI and the
DefaultExecutor.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62168/
-----------------------------------------------------------
(Updated Sept. 27, 2017, 7:07 p.m.)
Review request for mesos, Greg Mann and Vinod Kone.
Changes
-------
Updated the test description.
Bugs: MESOS-7916
https://issues.apache.org/jira/browse/MESOS-7916
Repository: mesos
Description (updated)
-------
This test verifies that URIs set on tasks are fetched and made available
to them when started by the DefaultExecutor.
Diffs (updated)
-----
src/tests/default_executor_tests.cpp dd1a6ad0d4e2bf74972e15b478652196ee9cd927
Diff: https://reviews.apache.org/r/62168/diff/2/
Changes: https://reviews.apache.org/r/62168/diff/1-2/
Testing (updated)
-------
The test succeeded for over 500 iterations on GNU/Linux.
Thanks,
Gastón Kleiman