You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "yf13 (via GitHub)" <gi...@apache.org> on 2024/02/22 01:29:21 UTC
[PR] build/ci: fix unused variables/functions issues [nuttx]
yf13 opened a new pull request, #11739:
URL: https://github.com/apache/nuttx/pull/11739
## Summary
This patch attetmps to fix CI blocking issues encountered in build 6374 for apps/pull/2300. They happened at various places, including the getprime app.
## Impact
CI checks
## Testing
CI checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build/ci: fix CI blocking unused warning issues (nuttx repo part) [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 closed pull request #11739: build/ci: fix CI blocking unused warning issues (nuttx repo part)
URL: https://github.com/apache/nuttx/pull/11739
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build/ci: fix CI blocking unused warning issues (nuttx repo part) [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #11739:
URL: https://github.com/apache/nuttx/pull/11739#discussion_r1498537947
##########
arch/arm/src/sama5/sam_ohci.c:
##########
@@ -2861,8 +2861,9 @@ static int sam_epfree(struct usbhost_driver_s *drvr, usbhost_ep_t ep)
int ret;
int ret2;
- DEBUGASSERT(rhport != NULL && eplist != NULL &&
+ DEBUGASSERT(drvr != NULL && eplist != NULL &&
eplist->ed != NULL && eplist->tail != NULL);
+ UNUSED(rhport);
Review Comment:
remove this, and line 2858
##########
fs/hostfs/hostfs.c:
##########
@@ -590,6 +593,7 @@ static int hostfs_ioctl(FAR struct file *filep, int cmd, unsigned long arg)
fs = inode->i_private;
DEBUGASSERT(fs != NULL);
+ UNUSED(fs);
Review Comment:
I mean remove ALL `DEBUGASSERT(fs != NULL);` and `FAR struct hostfs_mountpt_s *fs;` from this file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build/ci: fix CI blocking unused warning issues (nuttx repo part) [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #11739:
URL: https://github.com/apache/nuttx/pull/11739#issuecomment-1958752328
No need, close.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build/ci: fix CI blocking unused warning issues (nuttx repo part) [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #11739:
URL: https://github.com/apache/nuttx/pull/11739#discussion_r1498518228
##########
arch/arm/src/sama5/sam_ohci.c:
##########
@@ -2863,6 +2863,7 @@ static int sam_epfree(struct usbhost_driver_s *drvr, usbhost_ep_t ep)
DEBUGASSERT(rhport != NULL && eplist != NULL &&
Review Comment:
change to "drvr != NULL"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build/ci: fix CI blocking unused warning issues (nuttx repo part) [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #11739:
URL: https://github.com/apache/nuttx/pull/11739#discussion_r1498514487
##########
fs/hostfs/hostfs.c:
##########
@@ -590,6 +593,7 @@ static int hostfs_ioctl(FAR struct file *filep, int cmd, unsigned long arg)
fs = inode->i_private;
DEBUGASSERT(fs != NULL);
+ UNUSED(fs);
Review Comment:
the assert look like unnecessary, let's remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org