[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29762: [SPARK-32892][CORE][SQL] Fix hash functions on big-endian platforms.

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #29762:
URL: https://github.com/apache/spark/pull/29762#discussion_r489932308



##########
File path: common/sketch/src/main/java/org/apache/spark/util/sketch/Murmur3_x86_32.java
##########
@@ -92,8 +96,10 @@ private static int hashBytesByInt(Object base, long offset, int lengthInBytes, i
     int h1 = seed;
     for (int i = 0; i < lengthInBytes; i += 4) {
       int halfWord = Platform.getInt(base, offset + i);
-      int k1 = mixK1(halfWord);
-      h1 = mixH1(h1, k1);
+      if (isBigEndian) {

Review comment:
       cc @rednaxelafx 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org