You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "snazy (via GitHub)" <gi...@apache.org> on 2026/01/28 14:01:25 UTC
[PR] Telemetry guide: fix setup-polaris service [polaris]
snazy opened a new pull request, #3597:
URL: https://github.com/apache/polaris/pull/3597
Fixes the polaris-setup service to use the "working" way/syntax, in alignment to other guides.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Telemetry guide: fix setup-polaris service [polaris]
Posted by "MonkeyCanCode (via GitHub)" <gi...@apache.org>.
MonkeyCanCode commented on code in PR #3597:
URL: https://github.com/apache/polaris/pull/3597#discussion_r2738157016
##########
getting-started/telemetry/docker-compose.yml:
##########
@@ -65,7 +65,12 @@ services:
- CLIENT_SECRET=s3cr3t
volumes:
- ../assets/polaris/:/polaris
- entrypoint: '/bin/sh -c "chmod +x /polaris/create-catalog.sh && /polaris/create-catalog.sh"'
+ entrypoint: "/bin/sh"
+ command:
+ - "-c"
+ - >-
+ chmod +x /polaris/create-catalog.sh;
Review Comment:
will it be more cleaner if we just do `exec /polaris/create-catalog.sh;` as change file permission then run without implicitly shell is a bit unnecessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Telemetry guide: fix setup-polaris service [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #3597:
URL: https://github.com/apache/polaris/pull/3597#discussion_r2738562755
##########
getting-started/telemetry/docker-compose.yml:
##########
@@ -65,7 +65,12 @@ services:
- CLIENT_SECRET=s3cr3t
volumes:
- ../assets/polaris/:/polaris
- entrypoint: '/bin/sh -c "chmod +x /polaris/create-catalog.sh && /polaris/create-catalog.sh"'
+ entrypoint: "/bin/sh"
+ command:
+ - "-c"
+ - >-
+ chmod +x /polaris/create-catalog.sh;
Review Comment:
Actually, could we just fix UNIX permission on `create-catalog.sh` in git?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Telemetry guide: fix setup-polaris service [polaris]
Posted by "MonkeyCanCode (via GitHub)" <gi...@apache.org>.
MonkeyCanCode commented on code in PR #3597:
URL: https://github.com/apache/polaris/pull/3597#discussion_r2738585326
##########
getting-started/telemetry/docker-compose.yml:
##########
@@ -65,7 +65,12 @@ services:
- CLIENT_SECRET=s3cr3t
volumes:
- ../assets/polaris/:/polaris
- entrypoint: '/bin/sh -c "chmod +x /polaris/create-catalog.sh && /polaris/create-catalog.sh"'
+ entrypoint: "/bin/sh"
+ command:
+ - "-c"
+ - >-
+ chmod +x /polaris/create-catalog.sh;
Review Comment:
Well, that is very good point. Upon checking, we can just remove chmod line completely as the file is 755 already and here is the mounted file permission:
```
/ # ls -l /polaris/create-catalog.sh
-rwxr-xr-x 1 root root 2559 Dec 20 20:51 /polaris/create-catalog.sh
```
So we should just move chmod line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Telemetry guide: fix setup-polaris service [polaris]
Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy merged PR #3597:
URL: https://github.com/apache/polaris/pull/3597
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Telemetry guide: fix setup-polaris service [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #3597:
URL: https://github.com/apache/polaris/pull/3597#discussion_r2738562755
##########
getting-started/telemetry/docker-compose.yml:
##########
@@ -65,7 +65,12 @@ services:
- CLIENT_SECRET=s3cr3t
volumes:
- ../assets/polaris/:/polaris
- entrypoint: '/bin/sh -c "chmod +x /polaris/create-catalog.sh && /polaris/create-catalog.sh"'
+ entrypoint: "/bin/sh"
+ command:
+ - "-c"
+ - >-
+ chmod +x /polaris/create-catalog.sh;
Review Comment:
Actually, could we just fix UNIX permissions on `create-catalog.sh` in git?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Telemetry guide: fix setup-polaris service [polaris]
Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy commented on code in PR #3597:
URL: https://github.com/apache/polaris/pull/3597#discussion_r2740687175
##########
getting-started/telemetry/docker-compose.yml:
##########
@@ -65,7 +65,12 @@ services:
- CLIENT_SECRET=s3cr3t
volumes:
- ../assets/polaris/:/polaris
- entrypoint: '/bin/sh -c "chmod +x /polaris/create-catalog.sh && /polaris/create-catalog.sh"'
+ entrypoint: "/bin/sh"
+ command:
+ - "-c"
+ - >-
+ chmod +x /polaris/create-catalog.sh;
Review Comment:
good point, removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org