You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by ijuma <gi...@git.apache.org> on 2016/06/23 08:15:16 UTC

[GitHub] kafka pull request #1544: MINOR: Clean `Metrics.defaultRegistry` to avoid tr...

GitHub user ijuma opened a pull request:

    https://github.com/apache/kafka/pull/1544

    MINOR: Clean `Metrics.defaultRegistry` to avoid transient failures in `testSessionExpireListenerMetrics`

    The failure could manifest itself if the default metrics registry had some entries from other tests:
    
    java.lang.AssertionError: Unexpected meter count expected:<0> but was:<3>
    
    I also removed an unused variable and improved the error message to include the metric name.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijuma/kafka fix-transient-session-expire-listener-metrics-failure

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1544.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1544
    
----
commit 0e4e7eda2f54d53e68b2df0f8316d17ec2d29b99
Author: Ismael Juma <is...@juma.me.uk>
Date:   2016-06-23T08:12:20Z

    Clean `Metrics.defaultRegistry` to avoid transient failures in `testSessionExpireListenerMetrics`

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #1544: MINOR: Clean `Metrics.defaultRegistry` to avoid tr...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/1544


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---