You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2016/12/10 02:45:59 UTC
[kudu-CR] [delete table-test] parameterized DeleteTableWhileScanInProgress
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5455
Change subject: [delete_table-test] parameterized DeleteTableWhileScanInProgress
......................................................................
[delete_table-test] parameterized DeleteTableWhileScanInProgress
Replaced in-body for() loops with parameterized fixture for the
DeleteTableWhileScanInProgress test.
There are no functional changes in this patch.
Change-Id: I5ae2c3a9d2b9711e2788932768a4386cf692f677
---
M src/kudu/integration-tests/delete_table-test.cc
1 file changed, 98 insertions(+), 85 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/5455/1
--
To view, visit http://gerrit.cloudera.org:8080/5455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5ae2c3a9d2b9711e2788932768a4386cf692f677
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [delete table-test] parameterized DeleteTableWhileScanInProgress
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [delete_table-test] parameterized DeleteTableWhileScanInProgress
......................................................................
Patch Set 3: Code-Review+2
Propagating +2 from Will and David to the version 3 of this patch.
--
To view, visit http://gerrit.cloudera.org:8080/5455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ae2c3a9d2b9711e2788932768a4386cf692f677
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] [delete table-test] parameterized DeleteTableWhileScanInProgress
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [delete_table-test] parameterized DeleteTableWhileScanInProgress
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/5455/2/src/kudu/integration-tests/delete_table-test.cc
File src/kudu/integration-tests/delete_table-test.cc:
PS2, Line 1326: way how
> Nit/while you're here: delete "how"
Done
PS2, Line 1333: the
> unneeded "the"
Done
PS2, Line 1405: prepare for the next iteration of the loop
> Stale comment
Done
--
To view, visit http://gerrit.cloudera.org:8080/5455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ae2c3a9d2b9711e2788932768a4386cf692f677
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] [delete table-test] parameterized DeleteTableWhileScanInProgress
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has uploaded a new patch set (#2).
Change subject: [delete_table-test] parameterized DeleteTableWhileScanInProgress
......................................................................
[delete_table-test] parameterized DeleteTableWhileScanInProgress
Replaced in-body for() loops with parameterized fixture for the
DeleteTableWhileScanInProgress test.
There are no functional changes in this patch.
Change-Id: I5ae2c3a9d2b9711e2788932768a4386cf692f677
---
M src/kudu/integration-tests/delete_table-test.cc
1 file changed, 98 insertions(+), 85 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/5455/2
--
To view, visit http://gerrit.cloudera.org:8080/5455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5ae2c3a9d2b9711e2788932768a4386cf692f677
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [delete table-test] parameterized DeleteTableWhileScanInProgress
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello David Ribeiro Alves, Will Berkeley, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5455
to look at the new patch set (#3).
Change subject: [delete_table-test] parameterized DeleteTableWhileScanInProgress
......................................................................
[delete_table-test] parameterized DeleteTableWhileScanInProgress
Replaced in-body for() loops with parameterized fixture for the
DeleteTableWhileScanInProgress test.
There are no functional changes in this patch.
Change-Id: I5ae2c3a9d2b9711e2788932768a4386cf692f677
---
M src/kudu/integration-tests/delete_table-test.cc
1 file changed, 98 insertions(+), 85 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/5455/3
--
To view, visit http://gerrit.cloudera.org:8080/5455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5ae2c3a9d2b9711e2788932768a4386cf692f677
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [delete table-test] parameterized DeleteTableWhileScanInProgress
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: [delete_table-test] parameterized DeleteTableWhileScanInProgress
......................................................................
Patch Set 2: Code-Review+2
lgtm modulo Will's nits
--
To view, visit http://gerrit.cloudera.org:8080/5455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ae2c3a9d2b9711e2788932768a4386cf692f677
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] [delete table-test] parameterized DeleteTableWhileScanInProgress
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change.
Change subject: [delete_table-test] parameterized DeleteTableWhileScanInProgress
......................................................................
Patch Set 2: Code-Review+2
(3 comments)
Just a couple nits on comments...you can fix them if you want or feel free to just push it.
http://gerrit.cloudera.org:8080/#/c/5455/2/src/kudu/integration-tests/delete_table-test.cc
File src/kudu/integration-tests/delete_table-test.cc:
PS2, Line 1326: way how
Nit/while you're here: delete "how"
PS2, Line 1333: the
unneeded "the"
PS2, Line 1405: prepare for the next iteration of the loop
Stale comment
--
To view, visit http://gerrit.cloudera.org:8080/5455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ae2c3a9d2b9711e2788932768a4386cf692f677
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] [delete table-test] parameterized DeleteTableWhileScanInProgress
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged.
Change subject: [delete_table-test] parameterized DeleteTableWhileScanInProgress
......................................................................
[delete_table-test] parameterized DeleteTableWhileScanInProgress
Replaced in-body for() loops with parameterized fixture for the
DeleteTableWhileScanInProgress test.
There are no functional changes in this patch.
Change-Id: I5ae2c3a9d2b9711e2788932768a4386cf692f677
Reviewed-on: http://gerrit.cloudera.org:8080/5455
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/integration-tests/delete_table-test.cc
1 file changed, 98 insertions(+), 85 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5ae2c3a9d2b9711e2788932768a4386cf692f677
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>