[GitHub] [pulsar-client-node] Anonymitaet commented on a change in pull request #169: [Build] Add windows building configurations

[GitBox <gi...@apache.org>]

Anonymitaet commented on a change in pull request #169:
URL: https://github.com/apache/pulsar-client-node/pull/169#discussion_r695336948



##########
File path: README.md
##########
@@ -52,6 +52,17 @@ If an incompatible version of the C++ client is installed, you may fail to build
 
 ## How to install
 
+### Install in windows

Review comment:
       ```suggestion
   ### Install on windows
   ```

##########
File path: README.md
##########
@@ -52,6 +52,17 @@ If an incompatible version of the C++ client is installed, you may fail to build
 
 ## How to install
 
+### Install in windows
+
+You need to clone the Pulsar repo and build the Pulsar c++ client in windows, refer to https://pulsar.apache.org/docs/en/next/client-libraries-cpp/.
+
+After building pulsar-client-cpp, you could open windows cmd tool, and using the pulsar-client-cpp path to set the variable `PULSAR_CPP_DIR`.

Review comment:
       ```suggestion
   3. Set the variable `PULSAR_CPP_DIR` with the `pulsar-client-cpp` path in a Windows command tool.
   ```

##########
File path: README.md
##########
@@ -52,6 +52,17 @@ If an incompatible version of the C++ client is installed, you may fail to build
 
 ## How to install
 
+### Install in windows
+
+You need to clone the Pulsar repo and build the Pulsar c++ client in windows, refer to https://pulsar.apache.org/docs/en/next/client-libraries-cpp/.
+
+After building pulsar-client-cpp, you could open windows cmd tool, and using the pulsar-client-cpp path to set the variable `PULSAR_CPP_DIR`.
+
+Open windows cmd tool and set the variable `PULSAR_CPP_DIR`, for example.

Review comment:
       delete this since it is duplicated with the previous sentence?

##########
File path: README.md
##########
@@ -52,6 +52,17 @@ If an incompatible version of the C++ client is installed, you may fail to build
 
 ## How to install
 
+### Install in windows
+
+You need to clone the Pulsar repo and build the Pulsar c++ client in windows, refer to https://pulsar.apache.org/docs/en/next/client-libraries-cpp/.
+
+After building pulsar-client-cpp, you could open windows cmd tool, and using the pulsar-client-cpp path to set the variable `PULSAR_CPP_DIR`.
+
+Open windows cmd tool and set the variable `PULSAR_CPP_DIR`, for example.
+```shell
+set PULSAR_CPP_DIR=C:\pulsar\pulsar-client-cpp
+```
+
 ### Please install pulsar-client in your project:

Review comment:
       ```suggestion
   ### Install pulsar-client to your project
   ```

##########
File path: README.md
##########
@@ -52,6 +52,17 @@ If an incompatible version of the C++ client is installed, you may fail to build
 
 ## How to install
 
+### Install in windows
+
+You need to clone the Pulsar repo and build the Pulsar c++ client in windows, refer to https://pulsar.apache.org/docs/en/next/client-libraries-cpp/.

Review comment:
       ```suggestion
   1. [Start Pulsar](https://pulsar.apache.org/docs/en/next/standalone/). 
   
   2. [Build the Pulsar C++ client on windows](https://pulsar.apache.org/docs/en/next/client-libraries-cpp/).
   ```
   
   do you mean this?

##########
File path: README.md
##########
@@ -52,6 +52,17 @@ If an incompatible version of the C++ client is installed, you may fail to build
 
 ## How to install
 
+### Install in windows
+
+You need to clone the Pulsar repo and build the Pulsar c++ client in windows, refer to https://pulsar.apache.org/docs/en/next/client-libraries-cpp/.
+
+After building pulsar-client-cpp, you could open windows cmd tool, and using the pulsar-client-cpp path to set the variable `PULSAR_CPP_DIR`.
+
+Open windows cmd tool and set the variable `PULSAR_CPP_DIR`, for example.

Review comment:
       ```suggestion
   
   ```

##########
File path: README.md
##########
@@ -72,6 +83,8 @@ $ cd pulsar-client-node
 $ npm install
 ```
 
+> (Notice: If you build pulsar-client-node in windows,you need to set the variable `PULSAR_CPP_DIR` first, and run the command `npm install` in cmd tool)

Review comment:
       ```suggestion
   > **Note**
   >
   > If you build `pulsar-client-node on` windows, you need to set the variable `PULSAR_CPP_DIR` first and then install npm (run the command `npm install`) later in a Windows command-line tool.
   ```
   
   do you mean this?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org