[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #509: [FLINK-30653] Trigger resource Events on autoscaler actions

["morhidi (via GitHub)" <gi...@apache.org>]

morhidi commented on code in PR #509:
URL: https://github.com/apache/flink-kubernetes-operator/pull/509#discussion_r1087187329


##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/ScalingExecutor.java:
##########
@@ -99,14 +103,27 @@ public boolean scaleResource(
             return false;
         }
 
+        var scalingReport = scalingReport(scalingSummaries);
+        eventRecorder.triggerEvent(
+                resource,
+                EventRecorder.Type.Normal,
+                EventRecorder.Reason.ScalingReport,
+                EventRecorder.Component.Operator,
+                scalingReport);
+
+        if (!conf.get(SCALING_ENABLED)) {
+            return false;
+        }

Review Comment:
   I hear you, how about this:
   ```
   2023-01-25 13:16:04,184 o.a.f.k.o.u.EventCollector     [INFO ] >>> Event  | Info    | SCALINGREPORT   | Scaling vertices: Vertex ID 611fc81374e72d3d19e2d14196df735c | Parallelism 1 -> 2 | Processing capacity 100,00 -> 157,00 | Target data rate 110,00
   ```
   vs
   
   ```
   2023-01-25 13:16:04,274 o.a.f.k.o.u.EventCollector     [INFO ] >>> Event  | Info    | SCALINGREPORT   | Recommended parallelism change: Vertex ID b6844a4ed9bebdbbd33e4ebc1662745e | Parallelism 1 -> 2 | Processing capacity 100,00 -> 157,00 | Target data rate 110,00
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org