You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "michaeljmarshall (via GitHub)" <gi...@apache.org> on 2023/02/27 23:17:05 UTC
[GitHub] [pulsar] michaeljmarshall opened a new issue, #19652: [Bug] Some netty native libraries are not relocated
michaeljmarshall opened a new issue, #19652:
URL: https://github.com/apache/pulsar/issues/19652
### Search before asking
- [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar.
### Version
All of them
### Minimal reproduce step
Download a `pulsar-client-all.jar`, then view the `META-INF/native/` directory.
### What did you expect to see?
Properly relocated binaries.
### What did you see instead?
```
META-INF/native/
META-INF/native/liborg_apache_pulsar_shade_netty_tcnative_linux_x86_64.so
META-INF/native/liborg_apache_pulsar_shade_netty_resolver_dns_native_macos_aarch_64.jnilib
META-INF/native/libnetty_tcnative_osx_aarch_64.jnilib
META-INF/native/liborg_apache_pulsar_shade_netty_transport_native_epoll_x86_64.so
META-INF/native/include/
META-INF/native/include/netty_unix_jni.h
META-INF/native/include/netty_jni_util.h
META-INF/native/include/netty_unix_limits.h
META-INF/native/include/netty_unix_util.h
META-INF/native/include/netty_unix_filedescriptor.h
META-INF/native/include/netty_unix_errors.h
META-INF/native/include/netty_unix_buffer.h
META-INF/native/include/netty_unix.h
META-INF/native/include/netty_unix_socket.h
META-INF/native/netty_tcnative_windows_x86_64.dll
META-INF/native/liborg_apache_pulsar_shade_netty_resolver_dns_native_macos_x86_64.jnilib
META-INF/native/lib/
META-INF/native/lib/libnetty-unix-common.a
META-INF/native/libnetty_transport_native_io_uring_aarch_64.so
META-INF/native/libnetty_tcnative_linux_aarch_64.so
META-INF/native/libnetty_transport_native_io_uring_x86_64.so
META-INF/native/libnetty_tcnative_osx_x86_64.jnilib
```
### Anything else?
See https://github.com/apache/pulsar/pull/18646#pullrequestreview-1201600977 for more context.
### Are you willing to submit a PR?
- [ ] I'm willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on issue #19652: [Bug] Some netty native libraries are not relocated
Posted by "michaeljmarshall (via GitHub)" <gi...@apache.org>.
michaeljmarshall commented on issue #19652:
URL: https://github.com/apache/pulsar/issues/19652#issuecomment-1639457049
> Does this layout cause any real-world issue?
I haven't confirmed, but I assume it just leads to slower execution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug] Some netty native libraries are not relocated [pulsar]
Posted by "merlimat (via GitHub)" <gi...@apache.org>.
merlimat commented on issue #19652:
URL: https://github.com/apache/pulsar/issues/19652#issuecomment-6386657691
Thanks @michaeljmarshall for the report. This was reported on a Pulsar release before 3.0, which is no longer supported; the supported releases are 4.0.x, 4.2.x and 5.0.x. Much of the code involved has changed since, and the problem hasn't been confirmed on a current release, so I'm closing it as part of cleaning up old reports. If you still see it on a supported release, please open a new issue with the version and steps to reproduce, and link this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on issue #19652: [Bug] Some netty native libraries are not relocated
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #19652:
URL: https://github.com/apache/pulsar/issues/19652#issuecomment-1633432423
The issue had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on issue #19652: [Bug] Some netty native libraries are not relocated
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on issue #19652:
URL: https://github.com/apache/pulsar/issues/19652#issuecomment-1587515484
What do you mean by "relocated" here? IIRC Netty searches under `/native` folder and this logic has nothing to do with relocated.
Does this layout cause any real-world issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on issue #19652: [Bug] Some netty native libraries are not relocated
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #19652:
URL: https://github.com/apache/pulsar/issues/19652#issuecomment-1684664574
The issue had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on issue #19652: [Bug] Some netty native libraries are not relocated
Posted by "michaeljmarshall (via GitHub)" <gi...@apache.org>.
michaeljmarshall commented on issue #19652:
URL: https://github.com/apache/pulsar/issues/19652#issuecomment-1447268780
@lhotari - I took a quick look at https://github.com/apache/pulsar/blob/cfe643bc9d45e74271df6f4d16d46087572e285b/src/rename-netty-native-libs.sh, which needs to be updated to fix this. Do you know if we can simply relocate the files that have netty in their name, or do we need to enumerate each file? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on issue #19652: [Bug] Some netty native libraries are not relocated
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #19652:
URL: https://github.com/apache/pulsar/issues/19652#issuecomment-1489574498
The issue had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug] Some netty native libraries are not relocated [pulsar]
Posted by "merlimat (via GitHub)" <gi...@apache.org>.
merlimat closed issue #19652: [Bug] Some netty native libraries are not relocated
URL: https://github.com/apache/pulsar/issues/19652
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org