You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by felixcheung <gi...@git.apache.org> on 2017/10/05 05:19:22 UTC
[GitHub] spark pull request #19436: [SPARK-22206][SQL][SparkR] gapply in R can't work...
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19436#discussion_r142849580
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/objects.scala ---
@@ -394,7 +394,11 @@ case class FlatMapGroupsInRExec(
override def producedAttributes: AttributeSet = AttributeSet(outputObjAttr)
override def requiredChildDistribution: Seq[Distribution] =
- ClusteredDistribution(groupingAttributes) :: Nil
+ if (groupingAttributes.isEmpty) {
+ AllTuples :: Nil
--- End diff --
should empty == all?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org