You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2017/11/01 00:20:08 UTC
Review Request 63457: Add service dependencies
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63457/
-----------------------------------------------------------
Review request for Ambari, Jayush Luniya and Swapan Shridhar.
Bugs: AMBARI-22345
https://issues.apache.org/jira/browse/AMBARI-22345
Repository: ambari
Description
-------
API:
{code}
POST http://SERVER:8080/api/v2/clusters/{cluster-id}/servicegroups/{sgId}/services
Request
{
"ServiceInfo" : {
"service_name" : "{service-name}",
"service_display_name" : "{service-display-name}",
"service_version" : "{service-version}",
"stack_id" : "{stack-id}",
"hosting_platform" : "Ambari|Yarn"
}
"dependencies" : [
{
"ServiceInfo" : {
"service_id" : "{dependent-service-id}",
"cluster_id" : "{dependent-cluster-id}",
"service_group_id" : "{dependent-service-group-id}",
}
}
]
}
{code}
DB:
Add table {{servicedependencies}}
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 737b9b4
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ServiceDependencyResourceDefinition.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ServiceResourceDefinition.java 8255674
ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceKey.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java cb0ad20
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 3117186
ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java f75a7d5
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceDependencyRequest.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceDependencyResponse.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java b8c1674
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java cfab185
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceDependencyResourceProvider.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java 6a76fff
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterServiceEntity.java 9fca099
ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 8fd878e
ambari-server/src/main/java/org/apache/ambari/server/state/Service.java b9ab79f
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceFactory.java b48d825
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 167e4ca
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 1e4d81f
ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java 0434728
ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b8c0a42
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c56e486
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 8917d48
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f48bcd6
ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql e7c5c72
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql f87af4c
Diff: https://reviews.apache.org/r/63457/diff/1/
Testing
-------
Thanks,
Vitalyi Brodetskyi
Re: Review Request 63457: Add service dependencies
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63457/#review189814
-----------------------------------------------------------
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql
Lines 172 (patched)
<https://reviews.apache.org/r/63457/#comment267023>
Similar feedback for using id as primary key as in the case of servicegroupdependencies. Please address those in a follow up commit.
- Jayush Luniya
On Nov. 1, 2017, 12:20 a.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63457/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2017, 12:20 a.m.)
>
>
> Review request for Ambari, Jayush Luniya and Swapan Shridhar.
>
>
> Bugs: AMBARI-22345
> https://issues.apache.org/jira/browse/AMBARI-22345
>
>
> Repository: ambari
>
>
> Description
> -------
>
> API:
> {code}
> POST http://SERVER:8080/api/v2/clusters/{cluster-id}/servicegroups/{sgId}/services
>
> Request
>
> {
> "ServiceInfo" : {
> "service_name" : "{service-name}",
> "service_display_name" : "{service-display-name}",
> "service_version" : "{service-version}",
> "stack_id" : "{stack-id}",
> "hosting_platform" : "Ambari|Yarn"
> }
> "dependencies" : [
> {
> "ServiceInfo" : {
> "service_id" : "{dependent-service-id}",
> "cluster_id" : "{dependent-cluster-id}",
> "service_group_id" : "{dependent-service-group-id}",
> }
> }
> ]
> }
> {code}
>
> DB:
> Add table {{servicedependencies}}
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 737b9b4
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ServiceDependencyResourceDefinition.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ServiceResourceDefinition.java 8255674
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceKey.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java cb0ad20
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 3117186
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java f75a7d5
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceDependencyRequest.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceDependencyResponse.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java b8c1674
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java cfab185
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceDependencyResourceProvider.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java 6a76fff
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterServiceEntity.java 9fca099
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 8fd878e
> ambari-server/src/main/java/org/apache/ambari/server/state/Service.java b9ab79f
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceFactory.java b48d825
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 167e4ca
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 1e4d81f
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java 0434728
> ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b8c0a42
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c56e486
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 8917d48
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f48bcd6
> ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql e7c5c72
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql f87af4c
>
>
> Diff: https://reviews.apache.org/r/63457/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 63457: Add service dependencies
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63457/#review189815
-----------------------------------------------------------
Ship it!
Ship It!
- Jayush Luniya
On Nov. 1, 2017, 12:20 a.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63457/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2017, 12:20 a.m.)
>
>
> Review request for Ambari, Jayush Luniya and Swapan Shridhar.
>
>
> Bugs: AMBARI-22345
> https://issues.apache.org/jira/browse/AMBARI-22345
>
>
> Repository: ambari
>
>
> Description
> -------
>
> API:
> {code}
> POST http://SERVER:8080/api/v2/clusters/{cluster-id}/servicegroups/{sgId}/services
>
> Request
>
> {
> "ServiceInfo" : {
> "service_name" : "{service-name}",
> "service_display_name" : "{service-display-name}",
> "service_version" : "{service-version}",
> "stack_id" : "{stack-id}",
> "hosting_platform" : "Ambari|Yarn"
> }
> "dependencies" : [
> {
> "ServiceInfo" : {
> "service_id" : "{dependent-service-id}",
> "cluster_id" : "{dependent-cluster-id}",
> "service_group_id" : "{dependent-service-group-id}",
> }
> }
> ]
> }
> {code}
>
> DB:
> Add table {{servicedependencies}}
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 737b9b4
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ServiceDependencyResourceDefinition.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ServiceResourceDefinition.java 8255674
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceKey.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java cb0ad20
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 3117186
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java f75a7d5
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceDependencyRequest.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceDependencyResponse.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java b8c1674
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java cfab185
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceDependencyResourceProvider.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java 6a76fff
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterServiceEntity.java 9fca099
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 8fd878e
> ambari-server/src/main/java/org/apache/ambari/server/state/Service.java b9ab79f
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceFactory.java b48d825
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 167e4ca
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 1e4d81f
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java 0434728
> ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b8c0a42
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c56e486
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 8917d48
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f48bcd6
> ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql e7c5c72
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql f87af4c
>
>
> Diff: https://reviews.apache.org/r/63457/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 63457: Add service dependencies
Posted by Madhuvanthi Radhakrishnan <mr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63457/#review190223
-----------------------------------------------------------
ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql
Lines 180 (patched)
<https://reviews.apache.org/r/63457/#comment267519>
Hi Vitaly,
Can you please fix the syntax error for this one in all the SQL files?
- Madhuvanthi Radhakrishnan
On Nov. 1, 2017, 12:20 a.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63457/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2017, 12:20 a.m.)
>
>
> Review request for Ambari, Jayush Luniya and Swapan Shridhar.
>
>
> Bugs: AMBARI-22345
> https://issues.apache.org/jira/browse/AMBARI-22345
>
>
> Repository: ambari
>
>
> Description
> -------
>
> API:
> {code}
> POST http://SERVER:8080/api/v2/clusters/{cluster-id}/servicegroups/{sgId}/services
>
> Request
>
> {
> "ServiceInfo" : {
> "service_name" : "{service-name}",
> "service_display_name" : "{service-display-name}",
> "service_version" : "{service-version}",
> "stack_id" : "{stack-id}",
> "hosting_platform" : "Ambari|Yarn"
> }
> "dependencies" : [
> {
> "ServiceInfo" : {
> "service_id" : "{dependent-service-id}",
> "cluster_id" : "{dependent-cluster-id}",
> "service_group_id" : "{dependent-service-group-id}",
> }
> }
> ]
> }
> {code}
>
> DB:
> Add table {{servicedependencies}}
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 737b9b4
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ServiceDependencyResourceDefinition.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ServiceResourceDefinition.java 8255674
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceKey.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java cb0ad20
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 3117186
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java f75a7d5
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceDependencyRequest.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceDependencyResponse.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java b8c1674
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java cfab185
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceDependencyResourceProvider.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java 6a76fff
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterServiceEntity.java 9fca099
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 8fd878e
> ambari-server/src/main/java/org/apache/ambari/server/state/Service.java b9ab79f
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceFactory.java b48d825
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 167e4ca
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 1e4d81f
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java 0434728
> ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b8c0a42
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c56e486
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 8917d48
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f48bcd6
> ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql e7c5c72
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql f87af4c
>
>
> Diff: https://reviews.apache.org/r/63457/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>