You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@iotdb.apache.org by Julian Feinauer <j....@pragmaticminds.de> on 2019/07/23 15:17:33 UTC
Next steps for release 0.8.0-rc1
Hi all,
first, thanks to all, especially xiangdong and jialin for your effort and all the work.
With the last PR merged we are (I think) on an excellent way for the release.
I opened a Ticket for INFRA to prepare a Staging repository for us [1].
This is the last step, I think to make the `source-assembly` build which will then be staged.
I already started to prepare the release in maven, create the KEYS file and stage the first files for the release in svn and so on (see [2]).
So, as soon as INFRA resolves the ticket I can do the next steps and hopefully provide a complete RC, just to keep you updated : )
Julian
[1] https://issues.apache.org/jira/browse/INFRA-18788
[2] https://dist.apache.org/repos/dist/dev/iotdb/
Re: Next steps for release 0.8.0-rc1
Posted by Christofer Dutz <ch...@c-ware.de>.
Just a quick shot... Try without the "release" profile and just with apache-release enabled.
Chris
Holen Sie sich Outlook für Android<https://aka.ms/ghei36>
________________________________
From: Julian Feinauer <j....@pragmaticminds.de>
Sent: Thursday, July 25, 2019 9:59:40 AM
To: dev@iotdb.apache.org <de...@iotdb.apache.org>
Subject: Re: Next steps for release 0.8.0-rc1
Hi Justin,
thanks for the input.
These are the things why I wanted a first release to sort all that out : )
I guess we wait until tomorrow with preparation of an RC as Chris can surely assist a bit with things like artefact names and all that stuff.
Julian
Am 25.07.19, 08:46 schrieb "Justin Mclean" <ju...@classsoftware.com>:
Hi,
> Or, we provide a RC1 (which we do not expect to be the final release) but have then the community and the mentors check everything.
I can check it tomorrow (my time). But a quick quick shows a couple of issues:
- Missing incubating in name of artefact
- Jars in the source release
- Name seem wrong "IoTDB Root”?
- Docker file seems to using master?
- Wrong header on this file? /.mvn/wrapper/MavenWrapperDownloader.java
- It not immediately obvious of there is any 3rd party code in the source which make license and notice a lot simpler
Also being a first release, as long as there’s not significant issues, i’s likely to pass an IPMC vote.
Thanks,
Justin
Re: Next steps for release 0.8.0-rc1
Posted by Julian Feinauer <j....@pragmaticminds.de>.
Hi Justin,
thanks for the input.
These are the things why I wanted a first release to sort all that out : )
I guess we wait until tomorrow with preparation of an RC as Chris can surely assist a bit with things like artefact names and all that stuff.
Julian
Am 25.07.19, 08:46 schrieb "Justin Mclean" <ju...@classsoftware.com>:
Hi,
> Or, we provide a RC1 (which we do not expect to be the final release) but have then the community and the mentors check everything.
I can check it tomorrow (my time). But a quick quick shows a couple of issues:
- Missing incubating in name of artefact
- Jars in the source release
- Name seem wrong "IoTDB Root”?
- Docker file seems to using master?
- Wrong header on this file? /.mvn/wrapper/MavenWrapperDownloader.java
- It not immediately obvious of there is any 3rd party code in the source which make license and notice a lot simpler
Also being a first release, as long as there’s not significant issues, i’s likely to pass an IPMC vote.
Thanks,
Justin
Re: Next steps for release 0.8.0-rc1
Posted by Justin Mclean <ju...@me.com>.
Hi,
> Current compiled binary file looks quite good! I have modified the
> Dockerfile once again to use the new compiled binary file.
What do you mean by that? The ASF has policies on how software needs to be releases and only official releases can be provided to the general public. The main reason for this is that it give everyone involved legal protection.
Thanks,
Justin
Re: Next steps for release 0.8.0-rc1
Posted by Xiangdong Huang <sa...@gmail.com>.
Hi,
Current compiled binary file looks quite good! I have modified the
Dockerfile once again to use the new compiled binary file.
Best,
-----------------------------------
Xiangdong Huang
School of Software, Tsinghua University
黄向东
清华大学 软件学院
Julian Feinauer <j....@pragmaticminds.de> 于2019年7月26日周五 下午6:52写道：
> Hi all,
>
> Someone (xiangdong I think) renamed the artifactId of the "root" to
> "incubating-iotdb-parent" to have the incubating in artefact name.
> As Chris just send over a patch to include that via assembly plugin I
> suggest to change this back to "iotdb-parent" which is in accordance with
> what many other projects do.
>
> I submitted a PR (with many help from Chris!) which does some other
> necessary final fixed and hope that everybody agrees:
> https://github.com/apache/incubator-iotdb/pull/310
>
> Content is:
> Removed "build" module and moved this to parent pom.
> Renamed parent pom without incubating.
> Added incubating artefact names in assembly plugin.
> Added SHA512 for all artefacts.
>
> As soon as the PR is merged I will finally check and prepare an RC this
> weekend, I think.
>
> Best
> Julian
>
> Am 26.07.19, 10:45 schrieb "Christofer Dutz" <ch...@c-ware.de>:
>
> HI all,
>
> I sent Julian a patch with my changes. Got a lot to do today so I have
> to keep it simple.
>
> Chris
>
>
> Am 26.07.19, 10:05 schrieb "Jialin Qiao" <qjl16@mails.tsinghua.edu.cn
> >:
>
> Hi Chris,
>
> Glad to see you back! Our PR [1] separates the license with
> license-binary, updates the artifact in pom and adds "incubating" as the
> prefix of the artefact name. You can check and work in this PR.
>
> [1] https://github.com/apache/incubator-iotdb/pull/300
>
> Best,
> --
> Jialin Qiao
> School of Software, Tsinghua University
>
> 乔嘉林
> 清华大学 软件学院
>
> > -----原始邮件-----
> > 发件人: "Xiangdong Huang" <sa...@gmail.com>
> > 发送时间: 2019-07-26 15:47:29 (星期五)
> > 收件人: dev@iotdb.apache.org
> > 抄送:
> > 主题: Re: Next steps for release 0.8.0-rc1
> >
> > Hi Chris,
> >
> > I think It could not be better if there is a PR. The PR makes it
> easier to
> > let us know how to do the same thing in the future..
> >
> > Best
> >
> > Christofer Dutz <ch...@c-ware.de>于2019年7月26日
> 周五下午3:39写道：
> >
> > > Hi Justin,
> > >
> > > As I see it, it was producing a source-release without the
> "incubating" in
> > > it ... I just whipped up a patch for that and one that also
> generated the
> > > required sha512 hashes.
> > > Can I just commit that to the release branch, or do we have to
> do the full
> > > PR procedure?
> > >
> > > Chris
> > >
> > >
> > > Am 26.07.19, 09:16 schrieb "Justin Mclean" <
> justin@classsoftware.com>:
> > >
> > > Hi,
> > >
> > > > I am sure I can help with all the issues you are having.
> Could you
> > > please make a list that I can work off?
> > >
> > > I think everything been sort, but you could take a look at
> the product
> > > artefact to see if you think it has been.
> > >
> > > Thanks,
> > > Justin
> > >
> > > --
> > -----------------------------------
> > Xiangdong Huang
> > School of Software, Tsinghua University
> >
> > 黄向东
> > 清华大学 软件学院
>
>
>
>
>
Re: Next steps for release 0.8.0-rc1
Posted by Julian Feinauer <j....@pragmaticminds.de>.
Hi all,
Someone (xiangdong I think) renamed the artifactId of the "root" to "incubating-iotdb-parent" to have the incubating in artefact name.
As Chris just send over a patch to include that via assembly plugin I suggest to change this back to "iotdb-parent" which is in accordance with what many other projects do.
I submitted a PR (with many help from Chris!) which does some other necessary final fixed and hope that everybody agrees: https://github.com/apache/incubator-iotdb/pull/310
Content is:
Removed "build" module and moved this to parent pom.
Renamed parent pom without incubating.
Added incubating artefact names in assembly plugin.
Added SHA512 for all artefacts.
As soon as the PR is merged I will finally check and prepare an RC this weekend, I think.
Best
Julian
Am 26.07.19, 10:45 schrieb "Christofer Dutz" <ch...@c-ware.de>:
HI all,
I sent Julian a patch with my changes. Got a lot to do today so I have to keep it simple.
Chris
Am 26.07.19, 10:05 schrieb "Jialin Qiao" <qj...@mails.tsinghua.edu.cn>:
Hi Chris,
Glad to see you back! Our PR [1] separates the license with license-binary, updates the artifact in pom and adds "incubating" as the prefix of the artefact name. You can check and work in this PR.
[1] https://github.com/apache/incubator-iotdb/pull/300
Best,
--
Jialin Qiao
School of Software, Tsinghua University
乔嘉林
清华大学 软件学院
> -----原始邮件-----
> 发件人: "Xiangdong Huang" <sa...@gmail.com>
> 发送时间: 2019-07-26 15:47:29 (星期五)
> 收件人: dev@iotdb.apache.org
> 抄送:
> 主题: Re: Next steps for release 0.8.0-rc1
>
> Hi Chris,
>
> I think It could not be better if there is a PR. The PR makes it easier to
> let us know how to do the same thing in the future..
>
> Best
>
> Christofer Dutz <ch...@c-ware.de>于2019年7月26日 周五下午3:39写道：
>
> > Hi Justin,
> >
> > As I see it, it was producing a source-release without the "incubating" in
> > it ... I just whipped up a patch for that and one that also generated the
> > required sha512 hashes.
> > Can I just commit that to the release branch, or do we have to do the full
> > PR procedure?
> >
> > Chris
> >
> >
> > Am 26.07.19, 09:16 schrieb "Justin Mclean" <ju...@classsoftware.com>:
> >
> > Hi,
> >
> > > I am sure I can help with all the issues you are having. Could you
> > please make a list that I can work off?
> >
> > I think everything been sort, but you could take a look at the product
> > artefact to see if you think it has been.
> >
> > Thanks,
> > Justin
> >
> > --
> -----------------------------------
> Xiangdong Huang
> School of Software, Tsinghua University
>
> 黄向东
> 清华大学 软件学院
Re: Next steps for release 0.8.0-rc1
Posted by Christofer Dutz <ch...@c-ware.de>.
HI all,
I sent Julian a patch with my changes. Got a lot to do today so I have to keep it simple.
Chris
Am 26.07.19, 10:05 schrieb "Jialin Qiao" <qj...@mails.tsinghua.edu.cn>:
Hi Chris,
Glad to see you back! Our PR [1] separates the license with license-binary, updates the artifact in pom and adds "incubating" as the prefix of the artefact name. You can check and work in this PR.
[1] https://github.com/apache/incubator-iotdb/pull/300
Best,
--
Jialin Qiao
School of Software, Tsinghua University
乔嘉林
清华大学 软件学院
> -----原始邮件-----
> 发件人: "Xiangdong Huang" <sa...@gmail.com>
> 发送时间: 2019-07-26 15:47:29 (星期五)
> 收件人: dev@iotdb.apache.org
> 抄送:
> 主题: Re: Next steps for release 0.8.0-rc1
>
> Hi Chris,
>
> I think It could not be better if there is a PR. The PR makes it easier to
> let us know how to do the same thing in the future..
>
> Best
>
> Christofer Dutz <ch...@c-ware.de>于2019年7月26日 周五下午3:39写道：
>
> > Hi Justin,
> >
> > As I see it, it was producing a source-release without the "incubating" in
> > it ... I just whipped up a patch for that and one that also generated the
> > required sha512 hashes.
> > Can I just commit that to the release branch, or do we have to do the full
> > PR procedure?
> >
> > Chris
> >
> >
> > Am 26.07.19, 09:16 schrieb "Justin Mclean" <ju...@classsoftware.com>:
> >
> > Hi,
> >
> > > I am sure I can help with all the issues you are having. Could you
> > please make a list that I can work off?
> >
> > I think everything been sort, but you could take a look at the product
> > artefact to see if you think it has been.
> >
> > Thanks,
> > Justin
> >
> > --
> -----------------------------------
> Xiangdong Huang
> School of Software, Tsinghua University
>
> 黄向东
> 清华大学 软件学院
Re: Next steps for release 0.8.0-rc1
Posted by Jialin Qiao <qj...@mails.tsinghua.edu.cn>.
Hi Chris,
Glad to see you back! Our PR [1] separates the license with license-binary, updates the artifact in pom and adds "incubating" as the prefix of the artefact name. You can check and work in this PR.
[1] https://github.com/apache/incubator-iotdb/pull/300
Best,
--
Jialin Qiao
School of Software, Tsinghua University
乔嘉林
清华大学 软件学院
> -----原始邮件-----
> 发件人: "Xiangdong Huang" <sa...@gmail.com>
> 发送时间: 2019-07-26 15:47:29 (星期五)
> 收件人: dev@iotdb.apache.org
> 抄送:
> 主题: Re: Next steps for release 0.8.0-rc1
>
> Hi Chris,
>
> I think It could not be better if there is a PR. The PR makes it easier to
> let us know how to do the same thing in the future..
>
> Best
>
> Christofer Dutz <ch...@c-ware.de>于2019年7月26日 周五下午3:39写道：
>
> > Hi Justin,
> >
> > As I see it, it was producing a source-release without the "incubating" in
> > it ... I just whipped up a patch for that and one that also generated the
> > required sha512 hashes.
> > Can I just commit that to the release branch, or do we have to do the full
> > PR procedure?
> >
> > Chris
> >
> >
> > Am 26.07.19, 09:16 schrieb "Justin Mclean" <ju...@classsoftware.com>:
> >
> > Hi,
> >
> > > I am sure I can help with all the issues you are having. Could you
> > please make a list that I can work off?
> >
> > I think everything been sort, but you could take a look at the product
> > artefact to see if you think it has been.
> >
> > Thanks,
> > Justin
> >
> > --
> -----------------------------------
> Xiangdong Huang
> School of Software, Tsinghua University
>
> 黄向东
> 清华大学 软件学院
Re: Next steps for release 0.8.0-rc1
Posted by Xiangdong Huang <sa...@gmail.com>.
Hi Chris,
I think It could not be better if there is a PR. The PR makes it easier to
let us know how to do the same thing in the future..
Best
Christofer Dutz <ch...@c-ware.de>于2019年7月26日 周五下午3:39写道：
> Hi Justin,
>
> As I see it, it was producing a source-release without the "incubating" in
> it ... I just whipped up a patch for that and one that also generated the
> required sha512 hashes.
> Can I just commit that to the release branch, or do we have to do the full
> PR procedure?
>
> Chris
>
>
> Am 26.07.19, 09:16 schrieb "Justin Mclean" <ju...@classsoftware.com>:
>
> Hi,
>
> > I am sure I can help with all the issues you are having. Could you
> please make a list that I can work off?
>
> I think everything been sort, but you could take a look at the product
> artefact to see if you think it has been.
>
> Thanks,
> Justin
>
> --
-----------------------------------
Xiangdong Huang
School of Software, Tsinghua University
黄向东
清华大学 软件学院
AW: Next steps for release 0.8.0-rc1
Posted by Julian Feinauer <j....@pragmaticminds.de>.
Hi Chris,
There is already a pr in place from jialin and xiangdong.
Perhaps it would be good to check that.
Julian
Von meinem Mobiltelefon gesendet
-------- Ursprüngliche Nachricht --------
Betreff: Re: Next steps for release 0.8.0-rc1
Von: Christofer Dutz
An: dev@iotdb.apache.org
Cc:
Hi Justin,
As I see it, it was producing a source-release without the "incubating" in it ... I just whipped up a patch for that and one that also generated the required sha512 hashes.
Can I just commit that to the release branch, or do we have to do the full PR procedure?
Chris
Am 26.07.19, 09:16 schrieb "Justin Mclean" <ju...@classsoftware.com>:
Hi,
> I am sure I can help with all the issues you are having. Could you please make a list that I can work off?
I think everything been sort, but you could take a look at the product artefact to see if you think it has been.
Thanks,
Justin
Re: Next steps for release 0.8.0-rc1
Posted by Christofer Dutz <ch...@c-ware.de>.
Hi Justin,
As I see it, it was producing a source-release without the "incubating" in it ... I just whipped up a patch for that and one that also generated the required sha512 hashes.
Can I just commit that to the release branch, or do we have to do the full PR procedure?
Chris
Am 26.07.19, 09:16 schrieb "Justin Mclean" <ju...@classsoftware.com>:
Hi,
> I am sure I can help with all the issues you are having. Could you please make a list that I can work off?
I think everything been sort, but you could take a look at the product artefact to see if you think it has been.
Thanks,
Justin
Re: Next steps for release 0.8.0-rc1
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> I am sure I can help with all the issues you are having. Could you please make a list that I can work off?
I think everything been sort, but you could take a look at the product artefact to see if you think it has been.
Thanks,
Justin
Re: Next steps for release 0.8.0-rc1
Posted by Christofer Dutz <ch...@c-ware.de>.
Hi all,
I am sure I can help with all the issues you are having. Could you please make a list that I can work off? I need to do a lot of TAC related stuff today so this could really help me.
Chris
Am 26.07.19, 05:12 schrieb "Jialin Qiao" <qj...@mails.tsinghua.edu.cn>:
Hi,
I have fixed three problems in PR [1]
(1) change the "incubator" to "incubating"
(2) add DISCLAIMER file and package it into the tar.gz file
(3) change the tar.gz file name to incubating-iotdb-0.8.0-release.tar.gz
[1] https://github.com/apache/incubator-iotdb/pull/300
Best,
--
Jialin Qiao
School of Software, Tsinghua University
乔嘉林
清华大学 软件学院
> -----原始邮件-----
> 发件人: "Justin Mclean" <ju...@me.com>
> 发送时间: 2019-07-26 08:25:08 (星期五)
> 收件人: dev@iotdb.apache.org
> 抄送:
> 主题: Re: Next steps for release 0.8.0-rc1
>
> HI,
>
> > Thanks, I have fix both of them. Now the root artificatID is called
> > incubator-iotdb-parent.
>
> It needs to be “incubating" not “incubator”. See [1] and [2].
>
> Thanks,
> Justin
>
> 1. https://incubator.apache.org/policy/incubation.html#releases
> 2. https://incubator.apache.org/cookbook/#podling_releases
Re: Next steps for release 0.8.0-rc1
Posted by Jialin Qiao <qj...@mails.tsinghua.edu.cn>.
Hi,
I have fixed three problems in PR [1]
(1) change the "incubator" to "incubating"
(2) add DISCLAIMER file and package it into the tar.gz file
(3) change the tar.gz file name to incubating-iotdb-0.8.0-release.tar.gz
[1] https://github.com/apache/incubator-iotdb/pull/300
Best,
--
Jialin Qiao
School of Software, Tsinghua University
乔嘉林
清华大学 软件学院
> -----原始邮件-----
> 发件人: "Justin Mclean" <ju...@me.com>
> 发送时间: 2019-07-26 08:25:08 (星期五)
> 收件人: dev@iotdb.apache.org
> 抄送:
> 主题: Re: Next steps for release 0.8.0-rc1
>
> HI,
>
> > Thanks, I have fix both of them. Now the root artificatID is called
> > incubator-iotdb-parent.
>
> It needs to be “incubating" not “incubator”. See [1] and [2].
>
> Thanks,
> Justin
>
> 1. https://incubator.apache.org/policy/incubation.html#releases
> 2. https://incubator.apache.org/cookbook/#podling_releases
Re: Next steps for release 0.8.0-rc1
Posted by Justin Mclean <ju...@me.com>.
HI,
> Thanks, I have fix both of them. Now the root artificatID is called
> incubator-iotdb-parent.
It needs to be “incubating" not “incubator”. See [1] and [2].
Thanks,
Justin
1. https://incubator.apache.org/policy/incubation.html#releases
2. https://incubator.apache.org/cookbook/#podling_releases
Re: Next steps for release 0.8.0-rc1
Posted by Xiangdong Huang <sa...@gmail.com>.
Hi,
Thanks, I have fix both of them. Now the root artificatID is called
incubator-iotdb-parent. And the mavenWrapper is declared in LICENSE and
LICENSE-binary.
Best,
-----------------------------------
Xiangdong Huang
School of Software, Tsinghua University
黄向东
清华大学 软件学院
Justin Mclean <ju...@classsoftware.com> 于2019年7月26日周五 上午6:53写道：
> Hi,
>
> > I think it is not very good to add "incubating" on the artifactId of the
> > root pom.xml. Otherwise we have to change it if the project is
> graduated..
> > By the way, I checked the artifactId of Hadoop and Spark's pom.xml files,
> > one is called Hadoop-main while the other is called Spark-parent (PLC4x
> > also use plc4x-parent).
>
> It a requirement of all incubating projects to have incubating in the name
> of their releases. Spark and Hadoop are top level projects and no longer
> have this requirement.
>
> Here’s a release checklist that good too follow. [1]
>
> > - Wrong header on this file? /.mvn/wrapper/MavenWrapperDownloader.java
> >
> > It seems the header is correct... (A apache header for java file.)
>
> This code is not from an ASF project, so it should use a 3rd party ALv2
> header not the ASF one, see [2]. You might also want to mention it it
> LICENSE.
>
> Thanks,
> Justin
>
> 1.
> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
> 2. https://github.com/takari/maven-wrapper
Re: Next steps for release 0.8.0-rc1
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> I think it is not very good to add "incubating" on the artifactId of the
> root pom.xml. Otherwise we have to change it if the project is graduated..
> By the way, I checked the artifactId of Hadoop and Spark's pom.xml files,
> one is called Hadoop-main while the other is called Spark-parent (PLC4x
> also use plc4x-parent).
It a requirement of all incubating projects to have incubating in the name of their releases. Spark and Hadoop are top level projects and no longer have this requirement.
Here’s a release checklist that good too follow. [1]
> - Wrong header on this file? /.mvn/wrapper/MavenWrapperDownloader.java
>
> It seems the header is correct... (A apache header for java file.)
This code is not from an ASF project, so it should use a 3rd party ALv2 header not the ASF one, see [2]. You might also want to mention it it LICENSE.
Thanks,
Justin
1. https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
2. https://github.com/takari/maven-wrapper
Re: Next steps for release 0.8.0-rc1
Posted by Xiangdong Huang <sa...@gmail.com>.
Hi Justin,
PR 300 [1] has been updated according to the comments.
> - Missing incubating in name of artefact
> - Name seem wrong "IoTDB Root”?
I think it is not very good to add "incubating" on the artifactId of the
root pom.xml. Otherwise we have to change it if the project is graduated..
By the way, I checked the artifactId of Hadoop and Spark's pom.xml files,
one is called Hadoop-main while the other is called Spark-parent (PLC4x
also use plc4x-parent).
Therefore, I change the artifactId as "iotdb-parent".
Besides, I change the name field as "Apache IoTDB (incubating) Project
Parent POM"
> - Jars in the source release
> - It not immediately obvious of there is any 3rd party code in the source
which make license and notice a lot simpler
I think there should not be any jars in the source release... Besides, we
just modify several source files from Apache Hive (for parsing SQL), so, I
think the license (for source code) can be simple...
(Now there is no script to get a source-release.tar.gz file, but I think if
we download source codes from github, all files except .git can form the
source-release.tar.gz file...)
> - Docker file seems to using master?
I have fixed it in another PR #305 [2].
- Wrong header on this file? /.mvn/wrapper/MavenWrapperDownloader.java
It seems the header is correct... (A apache header for java file.)
[1] https://github.com/apache/incubator-iotdb/pull/300
[2] https://github.com/apache/incubator-iotdb/pull/305
Best,
-----------------------------------
Xiangdong Huang
School of Software, Tsinghua University
黄向东
清华大学 软件学院
Justin Mclean <ju...@classsoftware.com> 于2019年7月25日周四 下午2:46写道：
> Hi,
>
> > Or, we provide a RC1 (which we do not expect to be the final release)
> but have then the community and the mentors check everything.
>
> I can check it tomorrow (my time). But a quick quick shows a couple of
> issues:
> - Missing incubating in name of artefact
> - Jars in the source release
> - Name seem wrong "IoTDB Root”?
> - Docker file seems to using master?
> - Wrong header on this file? /.mvn/wrapper/MavenWrapperDownloader.java
> - It not immediately obvious of there is any 3rd party code in the source
> which make license and notice a lot simpler
>
> Also being a first release, as long as there’s not significant issues, i’s
> likely to pass an IPMC vote.
>
> Thanks,
> Justin
Re: Next steps for release 0.8.0-rc1
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> Or, we provide a RC1 (which we do not expect to be the final release) but have then the community and the mentors check everything.
I can check it tomorrow (my time). But a quick quick shows a couple of issues:
- Missing incubating in name of artefact
- Jars in the source release
- Name seem wrong "IoTDB Root”?
- Docker file seems to using master?
- Wrong header on this file? /.mvn/wrapper/MavenWrapperDownloader.java
- It not immediately obvious of there is any 3rd party code in the source which make license and notice a lot simpler
Also being a first release, as long as there’s not significant issues, i’s likely to pass an IPMC vote.
Thanks,
Justin
Re: Next steps for release 0.8.0-rc1
Posted by Julian Feinauer <j....@pragmaticminds.de>.
Hi all,
after everything is setup for the release, EXCEPT for some unclarity with regards to LICENSE, NOTICE and binary “supplementary files” I ask myself whats the best way to proceed.
Either we check our current material with the help of our mentors (like the PR https://github.com/apache/incubator-iotdb/pull/300).
Or, we provide a RC1 (which we do not expect to be the final release) but have then the community and the mentors check everything.
Then we can collect all necessary changes and fix them and come back with a RC2 which will hopefully pass then.
Perhaps the second version is a bit better and clearer and eases things for our mentors as its just an RC as they know it and can do their regular checks.
What do others (and also our mentors) think?
Julian
Am 25.07.19, 08:20 schrieb "Julian Feinauer" <j....@pragmaticminds.de>:
Hi Justin,
from Chris email it should work with:
> You can test what happens during a release by doing a "mvn package -P release,apache-release".
Julian
Am 25.07.19, 08:18 schrieb "Justin Mclean" <ju...@classsoftware.com>:
HI,
> short update on that... INFRA already set up the staging profile on nexus and I just did a quick dry-run and everything works.
So how can I locally produce a source release?
Thanks,
Justin
Re: Next steps for release 0.8.0-rc1
Posted by Julian Feinauer <j....@pragmaticminds.de>.
Hi Justin,
from Chris email it should work with:
> You can test what happens during a release by doing a "mvn package -P release,apache-release".
Julian
Am 25.07.19, 08:18 schrieb "Justin Mclean" <ju...@classsoftware.com>:
HI,
> short update on that... INFRA already set up the staging profile on nexus and I just did a quick dry-run and everything works.
So how can I locally produce a source release?
Thanks,
Justin
Re: Next steps for release 0.8.0-rc1
Posted by Justin Mclean <ju...@classsoftware.com>.
HI,
> short update on that... INFRA already set up the staging profile on nexus and I just did a quick dry-run and everything works.
So how can I locally produce a source release?
Thanks,
Justin
Re: Next steps for release 0.8.0-rc1
Posted by Julian Feinauer <j....@pragmaticminds.de>.
Hey all,
short update on that... INFRA already set up the staging profile on nexus and I just did a quick dry-run and everything works.
So we are absolutely ready to go for a RC1 as soon as LICENSE and NOTICE changes are sorted out (https://github.com/apache/incubator-iotdb/pull/300).
Julian
Am 24.07.19, 13:47 schrieb "Julian Feinauer" <j....@pragmaticminds.de>:
Hi Chris,
Thanks for the comment.
I already requested a profile at infra (https://issues.apache.org/jira/plugins/servlet/mobile#issue/INFRA-18788).
But will be good to have your support for the next steps.
Julian
PS: have a nice list day!
Von meinem Mobiltelefon gesendet
-------- Ursprüngliche Nachricht --------
Betreff: Re: Next steps for release 0.8.0-rc1
Von: Christofer Dutz
An: dev@iotdb.apache.org
Cc:
Hi guys,
I'm actually writing this lying in a sun bed at the beach on creta ;-)
You can test what happens during a release by doing a "mvn package -P release,apache-release".
Then it should also build the source release artifacts.
The only thing we need to do is that nexus is prepared for the iotdb group ID. Without that performing the releases would be a challenge 😉
But feel free to build a test - release with the apache-release profile enabled and check the contents of the artifacts. If you already did the release prepare, you can even manually build the release.
I'll be traveling home tomorrow so I'll be more accessible to help from Friday on.
Chris
Holen Sie sich Outlook für Android<https://aka.ms/ghei36>
________________________________
From: Julian Feinauer <j....@pragmaticminds.de>
Sent: Wednesday, July 24, 2019 11:21:38 AM
To: dev@iotdb.apache.org <de...@iotdb.apache.org>
Subject: AW: Next steps for release 0.8.0-rc1
Hey,
Indeed he made the build and i rely on the build setup we used in plc4x which he build the iotdb on as he told me.
And I'm totally against reinventing the wheel for each project so I think the way we used it in plc4x is fine as you only need those artifacts for a release and then staging needs to be done also.
Julian
Von meinem Mobiltelefon gesendet
-------- Ursprüngliche Nachricht --------
Betreff: Re: Next steps for release 0.8.0-rc1
Von: Justin Mclean
An: dev@iotdb.apache.org
Cc:
Hi,
Or even better this [1] . My mvn internal knowledge is a little vague, but on most ASF projects you go mvn package and you end up with the source release in the target directory.
Anyway Chris is the person to speak to about this, he probably knows what needs to be done.
Thanks,
Justin
1. http://maven.apache.org/plugins/maven-assembly-plugin/
AW: Next steps for release 0.8.0-rc1
Posted by Julian Feinauer <j....@pragmaticminds.de>.
Hi Chris,
Thanks for the comment.
I already requested a profile at infra (https://issues.apache.org/jira/plugins/servlet/mobile#issue/INFRA-18788).
But will be good to have your support for the next steps.
Julian
PS: have a nice list day!
Von meinem Mobiltelefon gesendet
-------- Ursprüngliche Nachricht --------
Betreff: Re: Next steps for release 0.8.0-rc1
Von: Christofer Dutz
An: dev@iotdb.apache.org
Cc:
Hi guys,
I'm actually writing this lying in a sun bed at the beach on creta ;-)
You can test what happens during a release by doing a "mvn package -P release,apache-release".
Then it should also build the source release artifacts.
The only thing we need to do is that nexus is prepared for the iotdb group ID. Without that performing the releases would be a challenge 😉
But feel free to build a test - release with the apache-release profile enabled and check the contents of the artifacts. If you already did the release prepare, you can even manually build the release.
I'll be traveling home tomorrow so I'll be more accessible to help from Friday on.
Chris
Holen Sie sich Outlook für Android<https://aka.ms/ghei36>
________________________________
From: Julian Feinauer <j....@pragmaticminds.de>
Sent: Wednesday, July 24, 2019 11:21:38 AM
To: dev@iotdb.apache.org <de...@iotdb.apache.org>
Subject: AW: Next steps for release 0.8.0-rc1
Hey,
Indeed he made the build and i rely on the build setup we used in plc4x which he build the iotdb on as he told me.
And I'm totally against reinventing the wheel for each project so I think the way we used it in plc4x is fine as you only need those artifacts for a release and then staging needs to be done also.
Julian
Von meinem Mobiltelefon gesendet
-------- Ursprüngliche Nachricht --------
Betreff: Re: Next steps for release 0.8.0-rc1
Von: Justin Mclean
An: dev@iotdb.apache.org
Cc:
Hi,
Or even better this [1] . My mvn internal knowledge is a little vague, but on most ASF projects you go mvn package and you end up with the source release in the target directory.
Anyway Chris is the person to speak to about this, he probably knows what needs to be done.
Thanks,
Justin
1. http://maven.apache.org/plugins/maven-assembly-plugin/
Re: Next steps for release 0.8.0-rc1
Posted by Christofer Dutz <ch...@c-ware.de>.
Hi guys,
I'm actually writing this lying in a sun bed at the beach on creta ;-)
You can test what happens during a release by doing a "mvn package -P release,apache-release".
Then it should also build the source release artifacts.
The only thing we need to do is that nexus is prepared for the iotdb group ID. Without that performing the releases would be a challenge 😉
But feel free to build a test - release with the apache-release profile enabled and check the contents of the artifacts. If you already did the release prepare, you can even manually build the release.
I'll be traveling home tomorrow so I'll be more accessible to help from Friday on.
Chris
Holen Sie sich Outlook für Android<https://aka.ms/ghei36>
________________________________
From: Julian Feinauer <j....@pragmaticminds.de>
Sent: Wednesday, July 24, 2019 11:21:38 AM
To: dev@iotdb.apache.org <de...@iotdb.apache.org>
Subject: AW: Next steps for release 0.8.0-rc1
Hey,
Indeed he made the build and i rely on the build setup we used in plc4x which he build the iotdb on as he told me.
And I'm totally against reinventing the wheel for each project so I think the way we used it in plc4x is fine as you only need those artifacts for a release and then staging needs to be done also.
Julian
Von meinem Mobiltelefon gesendet
-------- Ursprüngliche Nachricht --------
Betreff: Re: Next steps for release 0.8.0-rc1
Von: Justin Mclean
An: dev@iotdb.apache.org
Cc:
Hi,
Or even better this [1] . My mvn internal knowledge is a little vague, but on most ASF projects you go mvn package and you end up with the source release in the target directory.
Anyway Chris is the person to speak to about this, he probably knows what needs to be done.
Thanks,
Justin
1. http://maven.apache.org/plugins/maven-assembly-plugin/
AW: Next steps for release 0.8.0-rc1
Posted by Julian Feinauer <j....@pragmaticminds.de>.
Hey,
Indeed he made the build and i rely on the build setup we used in plc4x which he build the iotdb on as he told me.
And I'm totally against reinventing the wheel for each project so I think the way we used it in plc4x is fine as you only need those artifacts for a release and then staging needs to be done also.
Julian
Von meinem Mobiltelefon gesendet
-------- Ursprüngliche Nachricht --------
Betreff: Re: Next steps for release 0.8.0-rc1
Von: Justin Mclean
An: dev@iotdb.apache.org
Cc:
Hi,
Or even better this [1] . My mvn internal knowledge is a little vague, but on most ASF projects you go mvn package and you end up with the source release in the target directory.
Anyway Chris is the person to speak to about this, he probably knows what needs to be done.
Thanks,
Justin
1. http://maven.apache.org/plugins/maven-assembly-plugin/
Re: Next steps for release 0.8.0-rc1
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
Or even better this [1] . My mvn internal knowledge is a little vague, but on most ASF projects you go mvn package and you end up with the source release in the target directory.
Anyway Chris is the person to speak to about this, he probably knows what needs to be done.
Thanks,
Justin
1. http://maven.apache.org/plugins/maven-assembly-plugin/
Re: Next steps for release 0.8.0-rc1
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> If I recall correctly it does it only in the release :perform phase which currently fails because we have no profile on nexus :)
That doesn’t seem right to me, you should be able to build the source package locally without needing that. Do you know why this is the case? Why not just use this? [1]
Thanks,
Justin
1. https://maven.apache.org/plugins/maven-source-plugin/usage.html
AW: Next steps for release 0.8.0-rc1
Posted by Julian Feinauer <j....@pragmaticminds.de>.
Hey Justin,
If I recall correctly it does it only in the release :perform phase which currently fails because we have no profile on nexus :)
So as soon as this is done we should have the correct source package.
Julian
Von meinem Mobiltelefon gesendet
-------- Ursprüngliche Nachricht --------
Betreff: Re: Next steps for release 0.8.0-rc1
Von: Justin Mclean
An: dev@iotdb.apache.org
Cc:
Hi,
> I know and what I meant is that sources will be packaged as tarball by the source release goal from the apache parent maven pom.
Which currently doesn’t seem to create a source package when you do a "mvn package”. Hence my confusion of what’s actually in the release or not.
Thanks,
Justin
Re: Next steps for release 0.8.0-rc1
Posted by Justin Mclean <ju...@me.com>.
Hi,
> I know and what I meant is that sources will be packaged as tarball by the source release goal from the apache parent maven pom.
Which currently doesn’t seem to create a source package when you do a "mvn package”. Hence my confusion of what’s actually in the release or not.
Thanks,
Justin
AW: Next steps for release 0.8.0-rc1
Posted by Julian Feinauer <j....@pragmaticminds.de>.
Hi Justin,
I know and what I meant is that sources will be packaged as tarball by the source release goal from the apache parent maven pom.
This indicates pretty clearly what will be inside and what not.
Hope that helps.
Julian
Von meinem Mobiltelefon gesendet
-------- Ursprüngliche Nachricht --------
Betreff: Re: Next steps for release 0.8.0-rc1
Von: Justin Mclean
An: dev@iotdb.apache.org
Cc:
Hi,
> The source release will be a "regular" maven release of the Java project.
Maven is not an official release platform or where the ASF places official releases :-) That may come as a surprise to some people.
You need to create a source tar ball and place it in the distribution area (dist.apache.org) [1] and vote on the contents of that. Once the release has been approved by the IPMC it can be moved here [2] and the Apache mirror system will pick it up.
Thanks,
Justin
1. https://dist.apache.org/repos/dist/dev/incubator/
2. https://dist.apache.org/repos/dist/release/incubator/
AW: Next steps for release 0.8.0-rc1
Posted by Julian Feinauer <j....@pragmaticminds.de>.
Hi Justin,
I know and what I meant is that sources will be packaged as tarball by the source release goal from the apache parent maven pom.
This indicates pretty clearly what will be inside and what not.
Hope that helps.
Julian
Von meinem Mobiltelefon gesendet
-------- Ursprüngliche Nachricht --------
Betreff: Re: Next steps for release 0.8.0-rc1
Von: Justin Mclean
An: dev@iotdb.apache.org
Cc:
Hi,
> The source release will be a "regular" maven release of the Java project.
Maven is not an official release platform or where the ASF places official releases :-) That may come as a surprise to some people.
You need to create a source tar ball and place it in the distribution area (dist.apache.org) [1] and vote on the contents of that. Once the release has been approved by the IPMC it can be moved here [2] and the Apache mirror system will pick it up.
Thanks,
Justin
1. https://dist.apache.org/repos/dist/dev/incubator/
2. https://dist.apache.org/repos/dist/release/incubator/
Re: Next steps for release 0.8.0-rc1
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> The source release will be a "regular" maven release of the Java project.
Maven is not an official release platform or where the ASF places official releases :-) That may come as a surprise to some people.
You need to create a source tar ball and place it in the distribution area (dist.apache.org) [1] and vote on the contents of that. Once the release has been approved by the IPMC it can be moved here [2] and the Apache mirror system will pick it up.
Thanks,
Justin
1. https://dist.apache.org/repos/dist/dev/incubator/
2. https://dist.apache.org/repos/dist/release/incubator/
AW: Next steps for release 0.8.0-rc1
Posted by Julian Feinauer <j....@pragmaticminds.de>.
Hi Justin,
The source release will be a "regular" maven release of the Java project.
So indeed we should check and modify LICENSE and NOTICE files.
Personally I'm lacking experience in that so thanks for your input!
Julian
Von meinem Mobiltelefon gesendet
-------- Ursprüngliche Nachricht --------
Betreff: Re: Next steps for release 0.8.0-rc1
Von: Justin Mclean
An: dev@iotdb.apache.org
Cc:
Hi,
It a little unclear to me what is actually going in the source release. What is in that will determine the content of LICENSE and NOTICE. Can anyone point me at what is actually being consider for release?
Thanks,
Justin
Re: Next steps for release 0.8.0-rc1
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
It a little unclear to me what is actually going in the source release. What is in that will determine the content of LICENSE and NOTICE. Can anyone point me at what is actually being consider for release?
Thanks,
Justin