[GitHub] [spark] LuciferYang commented on a diff in pull request #43049: [SPARK-44113][BUILD][INFRA][DOCS][FOLLOW-UP] Remove Scala version specific comments, and scala-2.13 profile usage

["LuciferYang (via GitHub)" <gi...@apache.org>]

LuciferYang commented on code in PR #43049:
URL: https://github.com/apache/spark/pull/43049#discussion_r1333889711


##########
connector/avro/pom.xml:
##########
@@ -70,12 +70,10 @@
       <groupId>org.apache.spark</groupId>
       <artifactId>spark-tags_${scala.binary.version}</artifactId>
     </dependency>
-    <!-- #if scala-2.13 -->

Review Comment:
   Are we sure about deleting these comments? I was hesitant before, because I didn't know if we would need to use a similar approach to dynamically modify dependencies when supporting Scala 3, so I took a conservative approach and kept them.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org