You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/02 02:45:02 UTC
[GitHub] [spark] LuciferYang opened a new pull request, #38478: [MINOR][SQL] Wrap `given` in backticks to fix compilation warning
LuciferYang opened a new pull request, #38478:
URL: https://github.com/apache/spark/pull/38478
### What changes were proposed in this pull request?
A minor change to fix the a Scala related compilation warning
```
[WARNING] /spark-source/sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala:105: [deprecation @ | origin= | version=2.13.7] Wrap `given` in backticks to use it as an identifier, it will become a keyword in Scala 3.
```
### Why are the changes needed?
Fix a Scala related compilation warning.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Pass GitHub Action
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #38478: [MINOR][SQL] Wrap `given` in backticks to fix compilation warning
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #38478: [MINOR][SQL] Wrap `given` in backticks to fix compilation warning
URL: https://github.com/apache/spark/pull/38478
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #38478: [MINOR][SQL] Wrap `given` in backticks to fix compilation warning
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #38478:
URL: https://github.com/apache/spark/pull/38478#issuecomment-1299585051
+1, LGTM. Merging to master.
Thank you, @LuciferYang.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org