[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #10118: feat: add database dropdown to dashboard import

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #10118:
URL: https://github.com/apache/incubator-superset/pull/10118#discussion_r443140343



##########
File path: superset-frontend/src/components/FlashProvider.tsx
##########
@@ -42,7 +43,9 @@ class FlashProvider extends React.PureComponent<Props> {
     flashMessages.forEach(message => {
       const [type, text] = message;
       const flash = flashObj[type];
-      this.props[flash](text);
+      if (this.props[flash]) {

Review comment:
       Caught this bug as bycatch, this fails for the commonly used "alert" flashes.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org