You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Daniel Becker (Code Review)" <ge...@cloudera.org> on 2023/06/01 09:16:57 UTC

[Impala-ASF-CR] IMPALA-12171: Optimize delimited output

Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19894 )

Change subject: IMPALA-12171: Optimize delimited output
......................................................................


Patch Set 6:

(6 comments)

Thanks Csaba, a few remarks.

http://gerrit.cloudera.org:8080/#/c/19894/6//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19894/6//COMMIT_MSG@16
PS6, Line 16: python2 + hs2: 42s516ms -> 22s335ms
Optional: you could also include a percentage of performance improvement, it's easier to grasp the improvement that way.


http://gerrit.cloudera.org:8080/#/c/19894/6/shell/shell_output.py
File shell/shell_output.py:

http://gerrit.cloudera.org:8080/#/c/19894/6/shell/shell_output.py@102
PS6, Line 102: [
Optional: You could use () instead of [], which would create a lazy iterator instead of a list.


http://gerrit.cloudera.org:8080/#/c/19894/6/tests/shell/test_shell_commandline.py
File tests/shell/test_shell_commandline.py:

http://gerrit.cloudera.org:8080/#/c/19894/6/tests/shell/test_shell_commandline.py@33
PS6, Line 33: try:
Could we check the python version and branch on that instead of try-except?


http://gerrit.cloudera.org:8080/#/c/19894/6/tests/shell/test_shell_commandline.py@1597
PS6, Line 1597: that need special handling
We also test the simple case when there is no need for special handling, right?


http://gerrit.cloudera.org:8080/#/c/19894/6/tests/shell/test_shell_commandline.py@1597
PS6, Line 1597: s
Nit: result sets.


http://gerrit.cloudera.org:8080/#/c/19894/6/tests/shell/test_shell_commandline.py@1599
PS6, Line 1599: ,
Nit: . (full stop).



-- 
To view, visit http://gerrit.cloudera.org:8080/19894
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I671c6f538c588f8ad4ef4067f7bc8a6b8a5220cb
Gerrit-Change-Number: 19894
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Jun 2023 09:16:57 +0000
Gerrit-HasComments: Yes