[jira] [Commented] (BIGTOP-1045) Be consistent with shells, bigtop-detect-javahome, and bigtop-utils versions

["Peter Linnell (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BIGTOP-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13734393#comment-13734393 ] 

Peter Linnell commented on BIGTOP-1045:
---------------------------------------

Lovely :)  +1 to committing and seeing where there might be breakage, which I doubt will happen. Only caveat is to make sure Ubuntu has bash really installed and not just /bin/dash.

Thanks!
                
> Be consistent with shells, bigtop-detect-javahome, and bigtop-utils versions
> ----------------------------------------------------------------------------
>
>                 Key: BIGTOP-1045
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-1045
>             Project: Bigtop
>          Issue Type: Bug
>            Reporter: Sean Mackrory
>            Assignee: Sean Mackrory
>         Attachments: 0001-BIGTOP-1045.-Being-consistent-with-shells-defining-J.patch
>
>
> A while ago we decided to standardize on using /bin/bash (as opposed to /bin/sh), and to keep bigtop-detect-javahome in a centralized location. In addition to JAVA_HOME, there are now other scripts in bigtop-utils that are needed, so we should require the latest version.
> Until now, we've just been replacing /bin/sh when it's been a problem, but it's never obvious that it is the problem and is a low-risk change, so I'd like to just do a mass change now. With regards to bigtop-detect-javahome, we previously made this as a mass change, but several large patches were submitted soon thereafter and had been based off of older examples.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira