[GitHub] [incubator-druid] mcbrewster opened a new pull request #8228: Web-Console: Adds edit-context-dialog

[GitBox <gi...@apache.org>]

mcbrewster opened a new pull request #8228: Web-Console: Adds edit-context-dialog
URL: https://github.com/apache/incubator-druid/pull/8228
 
 
   
   ![localhost_18081_unified-console html (22)](https://user-images.githubusercontent.com/37322608/62393341-bd3c4200-b51e-11e9-9e0a-6ab2f06c4d8e.png)
   ![localhost_18081_unified-console html (21)](https://user-images.githubusercontent.com/37322608/62393344-bdd4d880-b51e-11e9-883b-7974e4f21720.png)
   
   
   ### Description
   
   Adds an additional MenuItem to the run button that opens the edit-context-modal where the user can modify the context object. The submit button will be greyed out if not valid JSON. When the user submits the object the corresponding checkboxes will also update. 
   <hr>
   
   This PR has:
   - [x ] been self-reviewed.
      - [ ] using the [concurrency checklist](https://github.com/apache/incubator-druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
   - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths.
   - [ ] added integration tests.
   - [ ] been tested in a test Druid cluster.
   
   Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the
   items which are not done or not relevant to the PR. None of the items from the checklist above are strictly necessary,
   but it would be very helpful if you at least self-review the PR.
   
   <hr>
   
   For reviewers: the key changed/added classes in this PR are `MyFoo`, `OurBar`, and `TheirBaz`.
   
   (Add this section in big PRs to ease navigation in them for reviewers.)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org