[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #1660: [SCB-1815] Support sdk register on local SC and discover on SCA

[GitBox <gi...@apache.org>]

liubao68 commented on a change in pull request #1660: [SCB-1815] Support sdk register on local SC and discover on SCA
URL: https://github.com/apache/servicecomb-java-chassis/pull/1660#discussion_r399905550
 
 

 ##########
 File path: core/src/main/java/org/apache/servicecomb/core/bootup/AddressInformationCollector.java
 ##########
 @@ -18,15 +18,21 @@
 package org.apache.servicecomb.core.bootup;
 
 import org.apache.servicecomb.deployment.Deployment;
+import org.apache.servicecomb.deployment.DeploymentProvider;
 import org.apache.servicecomb.deployment.SystemBootstrapInfo;
 
 public class AddressInformationCollector implements BootUpInformationCollector {
   @Override
   public String collect() {
-    return "Service Center: "
-        + getCenterInfo(Deployment.getSystemBootStrapInfo("ServiceCenter"))
-        + "\n" + "Config Center: "
-        + getCenterInfo(Deployment.getSystemBootStrapInfo("ConfigCenter"));
+    return "Service Center:\n"
+        + "  Registration: "
+        + getCenterInfo(Deployment.getSystemBootStrapInfo(DeploymentProvider.SYSTEM_KEY_SERVICE_CENTER_REGISTRY))
 
 Review comment:
   not correct, lack of servicecomb.service.registry.address

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services