You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by jiadexin <gi...@git.apache.org> on 2016/07/27 07:46:00 UTC
[GitHub] incubator-hawq pull request #820: HAWQ-953 hawq pxf-hive support partition c...
GitHub user jiadexin opened a pull request:
https://github.com/apache/incubator-hawq/pull/820
HAWQ-953 hawq pxf-hive support partition column filter pushdown whose type is string
not "HAWQ-953 Reverted sending qualifiers when creating PXF plan."
only modify HiveDataFragmenter.java, support partition column filter pushdown whose type is string.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/inspur-insight/incubator-hawq HAWQ-953_2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/820.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #820
----
commit 7625eac224221615403fe6e30da49c8ff0b7f65d
Author: Devin Jia <ji...@inspur.com>
Date: 2016-07-27T07:39:07Z
HAWQ-953 hawq pxf-hive support partition column filter pushdown whose type is string
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #820: HAWQ-953 hawq pxf-hive support partition c...
Posted by kavinderd <gi...@git.apache.org>.
Github user kavinderd commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/820#discussion_r72680060
--- Diff: pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/HiveDataFragmenter.java ---
@@ -331,7 +331,7 @@ String serializePartitionKeys(HiveTablePartition partData) throws Exception {
if (partData.partition == null) /*
* this is a simple hive table - there
* are no partitions
- */{
+ */ {
--- End diff --
Whitespace, please remove
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #820: HAWQ-953 hawq pxf-hive support partition column f...
Posted by shivzone <gi...@git.apache.org>.
Github user shivzone commented on the issue:
https://github.com/apache/incubator-hawq/pull/820
Please refer to comment posted in jira https://issues.apache.org/jira/browse/HAWQ-779?focusedCommentId=15403051.
Combine all the required fixes under one PR against HAWQ-779. Sorry for the inconvenience.
-1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #820: HAWQ-953 hawq pxf-hive support partition c...
Posted by jiadexin <gi...@git.apache.org>.
Github user jiadexin closed the pull request at:
https://github.com/apache/incubator-hawq/pull/820
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #820: HAWQ-953 hawq pxf-hive support partition c...
Posted by kavinderd <gi...@git.apache.org>.
Github user kavinderd commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/820#discussion_r72679690
--- Diff: pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/HiveDataFragmenter.java ---
@@ -20,11 +20,7 @@
*/
import java.io.ByteArrayOutputStream;
-import java.util.List;
-import java.util.ListIterator;
-import java.util.Properties;
-import java.util.Set;
-import java.util.TreeSet;
+import java.util.*;
--- End diff --
Can you revert back to importing each individual library. This imports an unnecessary amount of libraries.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #820: HAWQ-953 hawq pxf-hive support partition c...
Posted by kavinderd <gi...@git.apache.org>.
Github user kavinderd commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/820#discussion_r72680191
--- Diff: pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/HiveDataFragmenter.java ---
@@ -470,3 +476,4 @@ public FragmentsStats getFragmentsStats() throws Exception {
"ANALYZE for Hive plugin is not supported");
}
}
+
--- End diff --
Remove whitespace
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---