You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "Roger Hoover (JIRA)" <ji...@apache.org> on 2015/01/26 18:58:34 UTC
[jira] [Updated] (SAMZA-530) Shell scripts to run jobs do not
properly handle arguments
[ https://issues.apache.org/jira/browse/SAMZA-530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roger Hoover updated SAMZA-530:
-------------------------------
Description:
The run-job.sh and run-class.sh scripts pass along arguments provided to them but do not quote them properly. As a result, shell evaluation happens multiple times. Instead, these scripts should pass along the arguments unchanged like this: "$@" instead of this: $@.
To reproduce:
{noformat}
./run-class.sh org.apache.samza.job.JobRunner "--config=foo=a bar"
{noformat}
What you'll see:
The JVM will see two args passed: "--config=foo=a" and "bar".
What you should see:
The JVM should get a single argument: "--config=foo=a bar"
was:
The run-job.sh and run-class.sh scripts pass along arguments provided to them but do not quote them properly. As a result, shell evaluation happens multiple times. Instead, these scripts should pass along the arguments unchanged like this: "$@" instead of this: $@.
To reproduce:
{noformat}
./run-class.sh org.apache.samza.job.JobRunner "--config=foo=a bar"
{noformat}
What you'll see:
The JVM will see two args passed: "--config=foo=a" and "bar".
What you're should see:
The JVM should get a single argument: "--config=foo=a bar"
> Shell scripts to run jobs do not properly handle arguments
> ----------------------------------------------------------
>
> Key: SAMZA-530
> URL: https://issues.apache.org/jira/browse/SAMZA-530
> Project: Samza
> Issue Type: Bug
> Components: container
> Affects Versions: 0.8.0
> Reporter: Roger Hoover
>
> The run-job.sh and run-class.sh scripts pass along arguments provided to them but do not quote them properly. As a result, shell evaluation happens multiple times. Instead, these scripts should pass along the arguments unchanged like this: "$@" instead of this: $@.
> To reproduce:
> {noformat}
> ./run-class.sh org.apache.samza.job.JobRunner "--config=foo=a bar"
> {noformat}
> What you'll see:
> The JVM will see two args passed: "--config=foo=a" and "bar".
> What you should see:
> The JVM should get a single argument: "--config=foo=a bar"
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)