[GitHub] [beam] lostluck commented on a diff in pull request #26087: [#25582] Use a Pathing Jar instead of long command line class paths in Java Boot loader.

["lostluck (via GitHub)" <gi...@apache.org>]

lostluck commented on code in PR #26087:
URL: https://github.com/apache/beam/pull/26087#discussion_r1157654784


##########
.github/workflows/go_tests.yml:
##########
@@ -48,7 +48,7 @@ jobs:
       - name: Delete old coverage
         run: "cd sdks/go/pkg && rm -rf .coverage || :"
       - name: Run coverage
-        run: cd sdks/go/pkg && go test -coverprofile=coverage.txt -covermode=atomic ./...
+        run: cd sdks && go test -coverprofile=coverage.txt -covermode=atomic ./go/pkg/... ./go/container/... ./java/container/... ./python/container/... ./typescript/container/...

Review Comment:
   It will ignore those files, because it's unaware of files that don't receive any coverage numbers/changes.
   
   I think we also don't have the covbot enabled for these directories either. But I'm less concerned about that than I am about the unit tests being run at all.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org