You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/03/09 17:19:41 UTC
[GitHub] [incubator-superset] rusackas opened a new pull request #9264:
Fixing ACE editor font jank (again?!)
rusackas opened a new pull request #9264: Fixing ACE editor font jank (again?!)
URL: https://github.com/apache/incubator-superset/pull/9264
### CATEGORY
Choose one
- [x] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
Fixes #9253
Playing whack-a-mole with a font width/tracking issue in ACE editor(s). Tried to fix it in Safari, which seemed to work, but somehow now causes issue in Chrome. Undoing the fix, with a net delta of a new typeface, SEEMS to me, to work in both Chrome AND Safari, but I feel like I could use a sanity check from @etr2460 or anyone else.
Also of note, `react-ace` is on v5 in Superset, where they're on v8. I tried upgrading, and ran into all sorts of upgrade woes. It DID seem to solve solve this font width issue, however. I'll try to make an upgrade somewhere between v6 and v8 on a separate PR, so heads up about that, and speak up with any experience/warnings/objections if you have them.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
Chrome:
Safari:
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [x] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
@etr2460
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 merged pull request #9264: Fixing ACE
editor font jank (again?!)
Posted by GitBox <gi...@apache.org>.
etr2460 merged pull request #9264: Fixing ACE editor font jank (again?!)
URL: https://github.com/apache/incubator-superset/pull/9264
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #9264: Fixing
ACE editor font jank (again?!)
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9264: Fixing ACE editor font jank (again?!)
URL: https://github.com/apache/incubator-superset/pull/9264#issuecomment-596741854
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9264?src=pr&el=h1) Report
> Merging [#9264](https://codecov.io/gh/apache/incubator-superset/pull/9264?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8a5b898606d1209742e2dca99b7b05acc7651f15?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9264?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9264 +/- ##
======================================
Coverage 58.9% 58.9%
======================================
Files 373 373
Lines 12026 12026
Branches 2953 2953
======================================
Hits 7084 7084
Misses 4763 4763
Partials 179 179
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9264?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9264?src=pr&el=footer). Last update [8a5b898...6aa1719](https://codecov.io/gh/apache/incubator-superset/pull/9264?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org